Commit 23b424d9 authored by Deepa Dinamani's avatar Deepa Dinamani Committed by Al Viro

fs: Do not overload update_time

update_time() also has an internal function pointer
update_time. Even though this works correctly, it is
confusing to the readers.

Just use a regular if statement to call the generic
function or the function pointer.
Suggested-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarDeepa Dinamani <deepa.kernel@gmail.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ba70609d
...@@ -1675,12 +1675,9 @@ EXPORT_SYMBOL(generic_update_time); ...@@ -1675,12 +1675,9 @@ EXPORT_SYMBOL(generic_update_time);
*/ */
static int update_time(struct inode *inode, struct timespec64 *time, int flags) static int update_time(struct inode *inode, struct timespec64 *time, int flags)
{ {
int (*update_time)(struct inode *, struct timespec64 *, int); if (inode->i_op->update_time)
return inode->i_op->update_time(inode, time, flags);
update_time = inode->i_op->update_time ? inode->i_op->update_time : return generic_update_time(inode, time, flags);
generic_update_time;
return update_time(inode, time, flags);
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment