Commit 2505a210 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab

media: firewire: Using uninitialized values in node_probe()

If fw_csr_string() returns -ENOENT, then "name" is uninitialized.  So
then the "strlen(model_names[i]) <= name_len" is true because strlen()
is unsigned and -ENOENT is type promoted to a very high positive value.
Then the "strncmp(name, model_names[i], name_len)" uses uninitialized
data because "name" is uninitialized.

Fixes: 92374e88 ("[media] firedtv: drop obsolete backend abstraction")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 20171723
...@@ -272,6 +272,8 @@ static int node_probe(struct fw_unit *unit, const struct ieee1394_device_id *id) ...@@ -272,6 +272,8 @@ static int node_probe(struct fw_unit *unit, const struct ieee1394_device_id *id)
name_len = fw_csr_string(unit->directory, CSR_MODEL, name_len = fw_csr_string(unit->directory, CSR_MODEL,
name, sizeof(name)); name, sizeof(name));
if (name_len < 0)
return name_len;
for (i = ARRAY_SIZE(model_names); --i; ) for (i = ARRAY_SIZE(model_names); --i; )
if (strlen(model_names[i]) <= name_len && if (strlen(model_names[i]) <= name_len &&
strncmp(name, model_names[i], name_len) == 0) strncmp(name, model_names[i], name_len) == 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment