Commit 26b68dd2 authored by Mathieu Malaterre's avatar Mathieu Malaterre Committed by Steven Rostedt (VMware)

tracing: Use __printf markup to silence compiler

Silence warnings (triggered at W=1) by adding relevant __printf attributes.

  CC      kernel/trace/trace.o
kernel/trace/trace.c: In function ‘__trace_array_vprintk’:
kernel/trace/trace.c:2979:2: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
  len = vscnprintf(tbuffer, TRACE_BUF_SIZE, fmt, args);
  ^~~
  AR      kernel/trace/built-in.o

Link: http://lkml.kernel.org/r/20180308205843.27447-1-malat@debian.orgSigned-off-by: default avatarMathieu Malaterre <malat@debian.org>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent f26808ba
...@@ -2953,6 +2953,7 @@ int trace_vbprintk(unsigned long ip, const char *fmt, va_list args) ...@@ -2953,6 +2953,7 @@ int trace_vbprintk(unsigned long ip, const char *fmt, va_list args)
} }
EXPORT_SYMBOL_GPL(trace_vbprintk); EXPORT_SYMBOL_GPL(trace_vbprintk);
__printf(3, 0)
static int static int
__trace_array_vprintk(struct ring_buffer *buffer, __trace_array_vprintk(struct ring_buffer *buffer,
unsigned long ip, const char *fmt, va_list args) unsigned long ip, const char *fmt, va_list args)
...@@ -3007,12 +3008,14 @@ __trace_array_vprintk(struct ring_buffer *buffer, ...@@ -3007,12 +3008,14 @@ __trace_array_vprintk(struct ring_buffer *buffer,
return len; return len;
} }
__printf(3, 0)
int trace_array_vprintk(struct trace_array *tr, int trace_array_vprintk(struct trace_array *tr,
unsigned long ip, const char *fmt, va_list args) unsigned long ip, const char *fmt, va_list args)
{ {
return __trace_array_vprintk(tr->trace_buffer.buffer, ip, fmt, args); return __trace_array_vprintk(tr->trace_buffer.buffer, ip, fmt, args);
} }
__printf(3, 0)
int trace_array_printk(struct trace_array *tr, int trace_array_printk(struct trace_array *tr,
unsigned long ip, const char *fmt, ...) unsigned long ip, const char *fmt, ...)
{ {
...@@ -3028,6 +3031,7 @@ int trace_array_printk(struct trace_array *tr, ...@@ -3028,6 +3031,7 @@ int trace_array_printk(struct trace_array *tr,
return ret; return ret;
} }
__printf(3, 4)
int trace_array_printk_buf(struct ring_buffer *buffer, int trace_array_printk_buf(struct ring_buffer *buffer,
unsigned long ip, const char *fmt, ...) unsigned long ip, const char *fmt, ...)
{ {
...@@ -3043,6 +3047,7 @@ int trace_array_printk_buf(struct ring_buffer *buffer, ...@@ -3043,6 +3047,7 @@ int trace_array_printk_buf(struct ring_buffer *buffer,
return ret; return ret;
} }
__printf(2, 0)
int trace_vprintk(unsigned long ip, const char *fmt, va_list args) int trace_vprintk(unsigned long ip, const char *fmt, va_list args)
{ {
return trace_array_vprintk(&global_trace, ip, fmt, args); return trace_array_vprintk(&global_trace, ip, fmt, args);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment