Commit 2a5e6f7e authored by Dmitry Osipenko's avatar Dmitry Osipenko Committed by Linus Walleij

gpio: max77620: Fix missing release of interrupt

The requested interrupt is never released by the driver. Fix this by
using the resource-managed variant of request_threaded_irq().

Fixes: ab3dd9cc ("gpio: max77620: Fix interrupt handling")
Signed-off-by: default avatarDmitry Osipenko <digetx@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarLaxman Dewangan <ldewangan@nvidia.com>
Cc: <stable@vger.kernel.org> # 5.5+
Link: https://lore.kernel.org/r/20200709171203.12950-3-digetx@gmail.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 4ee82256
...@@ -305,8 +305,9 @@ static int max77620_gpio_probe(struct platform_device *pdev) ...@@ -305,8 +305,9 @@ static int max77620_gpio_probe(struct platform_device *pdev)
gpiochip_irqchip_add_nested(&mgpio->gpio_chip, &max77620_gpio_irqchip, gpiochip_irqchip_add_nested(&mgpio->gpio_chip, &max77620_gpio_irqchip,
0, handle_edge_irq, IRQ_TYPE_NONE); 0, handle_edge_irq, IRQ_TYPE_NONE);
ret = request_threaded_irq(gpio_irq, NULL, max77620_gpio_irqhandler, ret = devm_request_threaded_irq(&pdev->dev, gpio_irq, NULL,
IRQF_ONESHOT, "max77620-gpio", mgpio); max77620_gpio_irqhandler, IRQF_ONESHOT,
"max77620-gpio", mgpio);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "failed to request IRQ: %d\n", ret); dev_err(&pdev->dev, "failed to request IRQ: %d\n", ret);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment