Commit 2c4950ea authored by Petr Machata's avatar Petr Machata Committed by David S. Miller

mlxsw: spectrum_flow: Convert a goto to a return

No clean-up is performed at the target label of this goto. Convert it to a
direct return.
Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Reviewed-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2bafb216
...@@ -219,8 +219,7 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port, ...@@ -219,8 +219,7 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port,
mlxsw_sp_tc_block_release); mlxsw_sp_tc_block_release);
if (IS_ERR(block_cb)) { if (IS_ERR(block_cb)) {
mlxsw_sp_flow_block_destroy(flow_block); mlxsw_sp_flow_block_destroy(flow_block);
err = PTR_ERR(block_cb); return PTR_ERR(block_cb);
goto err_cb_register;
} }
register_block = true; register_block = true;
} else { } else {
...@@ -247,7 +246,6 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port, ...@@ -247,7 +246,6 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port,
err_block_bind: err_block_bind:
if (!flow_block_cb_decref(block_cb)) if (!flow_block_cb_decref(block_cb))
flow_block_cb_free(block_cb); flow_block_cb_free(block_cb);
err_cb_register:
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment