Commit 2d27c5db authored by Stanislaw Gruszka's avatar Stanislaw Gruszka

iwlegacy: remove DEBUG_LIMIT

Even if messages are generating fast we want to see all of them
when debugging.
Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
parent 46f16c49
...@@ -477,7 +477,7 @@ static void il3945_pass_packet_to_mac80211(struct il_priv *il, ...@@ -477,7 +477,7 @@ static void il3945_pass_packet_to_mac80211(struct il_priv *il,
/* We only process data packets if the interface is open */ /* We only process data packets if the interface is open */
if (unlikely(!il->is_open)) { if (unlikely(!il->is_open)) {
IL_DEBUG_DROP_LIMIT(il, IL_DEBUG_DROP(il,
"Dropping packet while interface is not open.\n"); "Dropping packet while interface is not open.\n");
return; return;
} }
...@@ -563,7 +563,7 @@ static void il3945_rx_reply_rx(struct il_priv *il, ...@@ -563,7 +563,7 @@ static void il3945_rx_reply_rx(struct il_priv *il,
network_packet = il3945_is_network_packet(il, header); network_packet = il3945_is_network_packet(il, header);
IL_DEBUG_STATS_LIMIT(il, "[%c] %d RSSI:%d Signal:%u, Rate:%u\n", IL_DEBUG_STATS(il, "[%c] %d RSSI:%d Signal:%u, Rate:%u\n",
network_packet ? '*' : ' ', network_packet ? '*' : ' ',
le16_to_cpu(rx_hdr->channel), le16_to_cpu(rx_hdr->channel),
rx_status.signal, rx_status.signal, rx_status.signal, rx_status.signal,
......
...@@ -537,7 +537,7 @@ static void il4965_pass_packet_to_mac80211(struct il_priv *il, ...@@ -537,7 +537,7 @@ static void il4965_pass_packet_to_mac80211(struct il_priv *il,
/* We only process data packets if the interface is open */ /* We only process data packets if the interface is open */
if (unlikely(!il->is_open)) { if (unlikely(!il->is_open)) {
IL_DEBUG_DROP_LIMIT(il, IL_DEBUG_DROP(il,
"Dropping packet while interface is not open.\n"); "Dropping packet while interface is not open.\n");
return; return;
} }
...@@ -647,7 +647,7 @@ void il4965_rx_reply_rx(struct il_priv *il, ...@@ -647,7 +647,7 @@ void il4965_rx_reply_rx(struct il_priv *il,
rx_status.signal = il4965_calc_rssi(il, phy_res); rx_status.signal = il4965_calc_rssi(il, phy_res);
il_dbg_log_rx_data_frame(il, len, header); il_dbg_log_rx_data_frame(il, len, header);
IL_DEBUG_STATS_LIMIT(il, "Rssi %d, TSF %llu\n", IL_DEBUG_STATS(il, "Rssi %d, TSF %llu\n",
rx_status.signal, (unsigned long long)rx_status.mactime); rx_status.signal, (unsigned long long)rx_status.mactime);
/* /*
......
...@@ -817,7 +817,7 @@ il4965_rs_tx_status(void *il_r, struct ieee80211_supported_band *sband, ...@@ -817,7 +817,7 @@ il4965_rs_tx_status(void *il_r, struct ieee80211_supported_band *sband,
struct il_station_priv *sta_priv = (void *)sta->drv_priv; struct il_station_priv *sta_priv = (void *)sta->drv_priv;
struct il_rxon_context *ctx = sta_priv->common.ctx; struct il_rxon_context *ctx = sta_priv->common.ctx;
IL_DEBUG_RATE_LIMIT(il, IL_DEBUG_RATE(il,
"get frame ack response, update rate scale window\n"); "get frame ack response, update rate scale window\n");
/* Treat uninitialized rate scaling data same as non-existing. */ /* Treat uninitialized rate scaling data same as non-existing. */
...@@ -2251,7 +2251,7 @@ il4965_rs_get_rate(void *il_r, struct ieee80211_sta *sta, void *il_sta, ...@@ -2251,7 +2251,7 @@ il4965_rs_get_rate(void *il_r, struct ieee80211_sta *sta, void *il_sta,
struct il_lq_sta *lq_sta = il_sta; struct il_lq_sta *lq_sta = il_sta;
int rate_idx; int rate_idx;
IL_DEBUG_RATE_LIMIT(il, "rate scale calculate new rate for skb\n"); IL_DEBUG_RATE(il, "rate scale calculate new rate for skb\n");
/* Get max rate if user set max rate */ /* Get max rate if user set max rate */
if (lq_sta) { if (lq_sta) {
......
...@@ -1737,7 +1737,7 @@ static u8 il4965_find_station(struct il_priv *il, const u8 *addr) ...@@ -1737,7 +1737,7 @@ static u8 il4965_find_station(struct il_priv *il, const u8 *addr)
goto out; goto out;
} }
IL_DEBUG_ASSOC_LIMIT(il, "can not find STA %pM total %d\n", IL_DEBUG_ASSOC(il, "can not find STA %pM total %d\n",
addr, il->num_stations); addr, il->num_stations);
out: out:
......
...@@ -52,14 +52,6 @@ do { \ ...@@ -52,14 +52,6 @@ do { \
__func__ , ## args); \ __func__ , ## args); \
} while (0) } while (0)
#define IL_DEBUG_LIMIT(__priv, level, fmt, args...) \
do { \
if ((il_get_debug_level(__priv) & (level)) && net_ratelimit()) \
dev_printk(KERN_ERR, &(__priv->hw->wiphy->dev), \
"%c %s " fmt, in_interrupt() ? 'I' : 'U', \
__func__ , ## args); \
} while (0)
#define il_print_hex_dump(il, level, p, len) \ #define il_print_hex_dump(il, level, p, len) \
do { \ do { \
if (il_get_debug_level(il) & level) \ if (il_get_debug_level(il) & level) \
...@@ -69,7 +61,6 @@ do { \ ...@@ -69,7 +61,6 @@ do { \
#else #else
#define IL_DEBUG(__priv, level, fmt, args...) #define IL_DEBUG(__priv, level, fmt, args...)
#define IL_DEBUG_LIMIT(__priv, level, fmt, args...)
static inline void il_print_hex_dump(struct il_priv *il, int level, static inline void il_print_hex_dump(struct il_priv *il, int level,
const void *p, u32 len) const void *p, u32 len)
{} {}
...@@ -169,25 +160,14 @@ static inline void il_dbgfs_unregister(struct il_priv *il) ...@@ -169,25 +160,14 @@ static inline void il_dbgfs_unregister(struct il_priv *il)
#define IL_DEBUG_FW(p, f, a...) IL_DEBUG(p, IL_DL_FW, f, ## a) #define IL_DEBUG_FW(p, f, a...) IL_DEBUG(p, IL_DL_FW, f, ## a)
#define IL_DEBUG_RF_KILL(p, f, a...) IL_DEBUG(p, IL_DL_RF_KILL, f, ## a) #define IL_DEBUG_RF_KILL(p, f, a...) IL_DEBUG(p, IL_DL_RF_KILL, f, ## a)
#define IL_DEBUG_DROP(p, f, a...) IL_DEBUG(p, IL_DL_DROP, f, ## a) #define IL_DEBUG_DROP(p, f, a...) IL_DEBUG(p, IL_DL_DROP, f, ## a)
#define IL_DEBUG_DROP_LIMIT(p, f, a...) \
IL_DEBUG_LIMIT(p, IL_DL_DROP, f, ## a)
#define IL_DEBUG_AP(p, f, a...) IL_DEBUG(p, IL_DL_AP, f, ## a) #define IL_DEBUG_AP(p, f, a...) IL_DEBUG(p, IL_DL_AP, f, ## a)
#define IL_DEBUG_TXPOWER(p, f, a...) IL_DEBUG(p, IL_DL_TXPOWER, f, ## a) #define IL_DEBUG_TXPOWER(p, f, a...) IL_DEBUG(p, IL_DL_TXPOWER, f, ## a)
#define IL_DEBUG_RATE(p, f, a...) IL_DEBUG(p, IL_DL_RATE, f, ## a) #define IL_DEBUG_RATE(p, f, a...) IL_DEBUG(p, IL_DL_RATE, f, ## a)
#define IL_DEBUG_RATE_LIMIT(p, f, a...) \
IL_DEBUG_LIMIT(p, IL_DL_RATE, f, ## a)
#define IL_DEBUG_NOTIF(p, f, a...) IL_DEBUG(p, IL_DL_NOTIF, f, ## a) #define IL_DEBUG_NOTIF(p, f, a...) IL_DEBUG(p, IL_DL_NOTIF, f, ## a)
#define IL_DEBUG_ASSOC(p, f, a...) \ #define IL_DEBUG_ASSOC(p, f, a...) IL_DEBUG(p, IL_DL_ASSOC, f, ## a)
IL_DEBUG(p, IL_DL_ASSOC | IL_DL_INFO, f, ## a)
#define IL_DEBUG_ASSOC_LIMIT(p, f, a...) \
IL_DEBUG_LIMIT(p, IL_DL_ASSOC | IL_DL_INFO, f, ## a)
#define IL_DEBUG_HT(p, f, a...) IL_DEBUG(p, IL_DL_HT, f, ## a) #define IL_DEBUG_HT(p, f, a...) IL_DEBUG(p, IL_DL_HT, f, ## a)
#define IL_DEBUG_STATS(p, f, a...) IL_DEBUG(p, IL_DL_STATS, f, ## a) #define IL_DEBUG_STATS(p, f, a...) IL_DEBUG(p, IL_DL_STATS, f, ## a)
#define IL_DEBUG_STATS_LIMIT(p, f, a...) \
IL_DEBUG_LIMIT(p, IL_DL_STATS, f, ## a)
#define IL_DEBUG_TX_REPLY(p, f, a...) IL_DEBUG(p, IL_DL_TX_REPLY, f, ## a) #define IL_DEBUG_TX_REPLY(p, f, a...) IL_DEBUG(p, IL_DL_TX_REPLY, f, ## a)
#define IL_DEBUG_TX_REPLY_LIMIT(p, f, a...) \
IL_DEBUG_LIMIT(p, IL_DL_TX_REPLY, f, ## a)
#define IL_DEBUG_QOS(p, f, a...) IL_DEBUG(p, IL_DL_QOS, f, ## a) #define IL_DEBUG_QOS(p, f, a...) IL_DEBUG(p, IL_DL_QOS, f, ## a)
#define IL_DEBUG_RADIO(p, f, a...) IL_DEBUG(p, IL_DL_RADIO, f, ## a) #define IL_DEBUG_RADIO(p, f, a...) IL_DEBUG(p, IL_DL_RADIO, f, ## a)
#define IL_DEBUG_POWER(p, f, a...) IL_DEBUG(p, IL_DL_POWER, f, ## a) #define IL_DEBUG_POWER(p, f, a...) IL_DEBUG(p, IL_DL_POWER, f, ## a)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment