Commit 2d78b3c1 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

lustre: lov: Drop rq_buflen field

The rq_buflen field of the lov_request structure is never initialized.  It
is only used in the free of req->rq_oi.oi_md in lov_finish_set.  But no
oi_md field is ever initialized to the result of calling OBD_ALLOC_LARGE.
So it seems that the call to OBD_FREE_LARGE in lov_finish_set and the
rq_buflen in the lov_request structure are simply not needed.
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2b692c2e
...@@ -81,7 +81,6 @@ struct lov_request { ...@@ -81,7 +81,6 @@ struct lov_request {
int rq_stripe; /* stripe number */ int rq_stripe; /* stripe number */
int rq_complete; int rq_complete;
int rq_rc; int rq_rc;
int rq_buflen; /* length of sub_md */
u32 rq_oabufs; u32 rq_oabufs;
u32 rq_pgaidx; u32 rq_pgaidx;
......
...@@ -68,8 +68,6 @@ void lov_finish_set(struct lov_request_set *set) ...@@ -68,8 +68,6 @@ void lov_finish_set(struct lov_request_set *set)
if (req->rq_oi.oi_oa) if (req->rq_oi.oi_oa)
OBDO_FREE(req->rq_oi.oi_oa); OBDO_FREE(req->rq_oi.oi_oa);
if (req->rq_oi.oi_md)
OBD_FREE_LARGE(req->rq_oi.oi_md, req->rq_buflen);
kfree(req->rq_oi.oi_osfs); kfree(req->rq_oi.oi_osfs);
kfree(req); kfree(req);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment