Commit 2f27a3e2 authored by Bhumika Goyal's avatar Bhumika Goyal Committed by Greg Kroah-Hartman

Staging: lustre: Remove print statement on function failure

The  memory allocation functions generates a call stack containing
all the context information on failure, so print statements can be
removed on failure of these functions. Also remove
unwanted {} around if block after removal of these statements.
Done using coccinelle:

@@
expression e,e1,e2;
identifier x;
@@
e=\(kmalloc\|kmalloc_array\|kzalloc\|
   devm_kzalloc\)(...);
...when!=e=e1
if(!e)
-{
- \(printk\|DBG_8723A\|pr_err\|CERROR\|DBG_88E\)(...);
(
goto x;
|
return e2;
|
return;
)
-}
Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 04697f7b
...@@ -251,10 +251,8 @@ static int cfs_crypto_test_hashes(void) ...@@ -251,10 +251,8 @@ static int cfs_crypto_test_hashes(void)
unsigned int data_len = 1 * 128 * 1024; unsigned int data_len = 1 * 128 * 1024;
data = kmalloc(data_len, 0); data = kmalloc(data_len, 0);
if (!data) { if (!data)
CERROR("Failed to allocate mem\n");
return -ENOMEM; return -ENOMEM;
}
for (j = 0; j < data_len; j++) for (j = 0; j < data_len; j++)
data[j] = j & 0xff; data[j] = j & 0xff;
......
...@@ -365,10 +365,8 @@ int llog_process_or_fork(const struct lu_env *env, ...@@ -365,10 +365,8 @@ int llog_process_or_fork(const struct lu_env *env,
int rc; int rc;
lpi = kzalloc(sizeof(*lpi), GFP_NOFS); lpi = kzalloc(sizeof(*lpi), GFP_NOFS);
if (!lpi) { if (!lpi)
CERROR("cannot alloc pointer\n");
return -ENOMEM; return -ENOMEM;
}
lpi->lpi_loghandle = loghandle; lpi->lpi_loghandle = loghandle;
lpi->lpi_cb = cb; lpi->lpi_cb = cb;
lpi->lpi_cbdata = data; lpi->lpi_cbdata = data;
......
...@@ -1768,11 +1768,8 @@ static int echo_client_setup(const struct lu_env *env, ...@@ -1768,11 +1768,8 @@ static int echo_client_setup(const struct lu_env *env,
ec->ec_unique = 0; ec->ec_unique = 0;
ocd = kzalloc(sizeof(*ocd), GFP_NOFS); ocd = kzalloc(sizeof(*ocd), GFP_NOFS);
if (!ocd) { if (!ocd)
CERROR("Can't alloc ocd connecting to %s\n",
lustre_cfg_string(lcfg, 1));
return -ENOMEM; return -ENOMEM;
}
ocd->ocd_connect_flags = OBD_CONNECT_VERSION | OBD_CONNECT_REQPORTAL | ocd->ocd_connect_flags = OBD_CONNECT_VERSION | OBD_CONNECT_REQPORTAL |
OBD_CONNECT_BRW_SIZE | OBD_CONNECT_BRW_SIZE |
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment