Commit 2f6f0a99 authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'linux-kselftest-5.3-rc3' of...

Merge tag 'linux-kselftest-5.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest

Pull kselftest fixes from Shuah Khan:
 "Minor fixes to tests and one major fix to livepatch test to add skip
  handling to avoid false fail reports when livepatch is disabled"

* tag 'linux-kselftest-5.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest:
  selftests/livepatch: add test skip handling
  selftests: mlxsw: Fix typo in qos_mc_aware.sh
  selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
  selftests: kmod: Fix typo in kmod.sh
parents 32a024b9 527d37e9
...@@ -262,7 +262,7 @@ test_mc_aware() ...@@ -262,7 +262,7 @@ test_mc_aware()
stop_traffic stop_traffic
log_test "UC performace under MC overload" log_test "UC performance under MC overload"
echo "UC-only throughput $(humanize $ucth1)" echo "UC-only throughput $(humanize $ucth1)"
echo "UC+MC throughput $(humanize $ucth2)" echo "UC+MC throughput $(humanize $ucth2)"
...@@ -316,7 +316,7 @@ test_uc_aware() ...@@ -316,7 +316,7 @@ test_uc_aware()
stop_traffic stop_traffic
log_test "MC performace under UC overload" log_test "MC performance under UC overload"
echo " ingress UC throughput $(humanize ${uc_ir})" echo " ingress UC throughput $(humanize ${uc_ir})"
echo " egress UC throughput $(humanize ${uc_er})" echo " egress UC throughput $(humanize ${uc_er})"
echo " sent $attempts BC ARPs, got $passes responses" echo " sent $attempts BC ARPs, got $passes responses"
......
...@@ -28,7 +28,7 @@ ...@@ -28,7 +28,7 @@
# override by exporting to your environment prior running this script. # override by exporting to your environment prior running this script.
# For instance this script assumes you do not have xfs loaded upon boot. # For instance this script assumes you do not have xfs loaded upon boot.
# If this is false, export DEFAULT_KMOD_FS="ext4" prior to running this # If this is false, export DEFAULT_KMOD_FS="ext4" prior to running this
# script if the filesyste module you don't have loaded upon bootup # script if the filesystem module you don't have loaded upon bootup
# is ext4 instead. Refer to allow_user_defaults() for a list of user # is ext4 instead. Refer to allow_user_defaults() for a list of user
# override variables possible. # override variables possible.
# #
...@@ -263,7 +263,7 @@ config_get_test_result() ...@@ -263,7 +263,7 @@ config_get_test_result()
config_reset() config_reset()
{ {
if ! echo -n "1" >"$DIR"/reset; then if ! echo -n "1" >"$DIR"/reset; then
echo "$0: reset shuld have worked" >&2 echo "$0: reset should have worked" >&2
exit 1 exit 1
fi fi
} }
...@@ -488,7 +488,7 @@ usage() ...@@ -488,7 +488,7 @@ usage()
echo Example uses: echo Example uses:
echo echo
echo "${TEST_NAME}.sh -- executes all tests" echo "${TEST_NAME}.sh -- executes all tests"
echo "${TEST_NAME}.sh -t 0008 -- Executes test ID 0008 number of times is recomended" echo "${TEST_NAME}.sh -t 0008 -- Executes test ID 0008 number of times is recommended"
echo "${TEST_NAME}.sh -w 0008 -- Watch test ID 0008 run until an error occurs" echo "${TEST_NAME}.sh -w 0008 -- Watch test ID 0008 run until an error occurs"
echo "${TEST_NAME}.sh -s 0008 -- Run test ID 0008 once" echo "${TEST_NAME}.sh -s 0008 -- Run test ID 0008 once"
echo "${TEST_NAME}.sh -c 0008 3 -- Run test ID 0008 three times" echo "${TEST_NAME}.sh -c 0008 3 -- Run test ID 0008 three times"
......
...@@ -13,6 +13,14 @@ function log() { ...@@ -13,6 +13,14 @@ function log() {
echo "$1" > /dev/kmsg echo "$1" > /dev/kmsg
} }
# skip(msg) - testing can't proceed
# msg - explanation
function skip() {
log "SKIP: $1"
echo "SKIP: $1" >&2
exit 4
}
# die(msg) - game over, man # die(msg) - game over, man
# msg - dying words # msg - dying words
function die() { function die() {
...@@ -43,6 +51,12 @@ function loop_until() { ...@@ -43,6 +51,12 @@ function loop_until() {
done done
} }
function assert_mod() {
local mod="$1"
modprobe --dry-run "$mod" &>/dev/null
}
function is_livepatch_mod() { function is_livepatch_mod() {
local mod="$1" local mod="$1"
...@@ -75,6 +89,9 @@ function __load_mod() { ...@@ -75,6 +89,9 @@ function __load_mod() {
function load_mod() { function load_mod() {
local mod="$1"; shift local mod="$1"; shift
assert_mod "$mod" ||
skip "unable to load module ${mod}, verify CONFIG_TEST_LIVEPATCH=m and run self-tests as root"
is_livepatch_mod "$mod" && is_livepatch_mod "$mod" &&
die "use load_lp() to load the livepatch module $mod" die "use load_lp() to load the livepatch module $mod"
...@@ -88,6 +105,9 @@ function load_mod() { ...@@ -88,6 +105,9 @@ function load_mod() {
function load_lp_nowait() { function load_lp_nowait() {
local mod="$1"; shift local mod="$1"; shift
assert_mod "$mod" ||
skip "unable to load module ${mod}, verify CONFIG_TEST_LIVEPATCH=m and run self-tests as root"
is_livepatch_mod "$mod" || is_livepatch_mod "$mod" ||
die "module $mod is not a livepatch" die "module $mod is not a livepatch"
......
...@@ -451,7 +451,7 @@ static int test_vsys_x(void) ...@@ -451,7 +451,7 @@ static int test_vsys_x(void)
printf("[OK]\tExecuting the vsyscall page failed: #PF(0x%lx)\n", printf("[OK]\tExecuting the vsyscall page failed: #PF(0x%lx)\n",
segv_err); segv_err);
} else { } else {
printf("[FAILT]\tExecution failed with the wrong error: #PF(0x%lx)\n", printf("[FAIL]\tExecution failed with the wrong error: #PF(0x%lx)\n",
segv_err); segv_err);
return 1; return 1;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment