Commit 307a54cc authored by Julia Lawall's avatar Julia Lawall Committed by Benjamin Herrenschmidt

powerpc/iseries: Use kstrdup

Use kstrdup when the goal of an allocation is copy a string into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to;
expression flag,E1,E2;
statement S;
@@

-  to = kmalloc(strlen(from) + 1,flag);
+  to = kstrdup(from, flag);
   ... when != \(from = E1 \| to = E1 \)
   if (to==NULL || ...) S
   ... when != \(from = E2 \| to = E2 \)
-  strcpy(to, from);
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 41eab6f8
...@@ -87,12 +87,11 @@ static struct device_node *new_node(const char *path, ...@@ -87,12 +87,11 @@ static struct device_node *new_node(const char *path,
if (!np) if (!np)
return NULL; return NULL;
np->full_name = kmalloc(strlen(path) + 1, GFP_KERNEL); np->full_name = kstrdup(path, GFP_KERNEL);
if (!np->full_name) { if (!np->full_name) {
kfree(np); kfree(np);
return NULL; return NULL;
} }
strcpy(np->full_name, path);
of_node_set_flag(np, OF_DYNAMIC); of_node_set_flag(np, OF_DYNAMIC);
kref_init(&np->kref); kref_init(&np->kref);
np->parent = of_node_get(parent); np->parent = of_node_get(parent);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment