Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
linux
Commits
309811e3
Commit
309811e3
authored
Apr 12, 2004
by
Dave Kleikamp
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
JFS: Fix race in jfs_sync
Don't let final iput happen while jfs_sync is processing inode.
parent
196c4ebd
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
5 deletions
+12
-5
fs/jfs/jfs_txnmgr.c
fs/jfs/jfs_txnmgr.c
+12
-5
No files found.
fs/jfs/jfs_txnmgr.c
View file @
309811e3
...
@@ -2977,11 +2977,12 @@ int jfs_sync(void *arg)
...
@@ -2977,11 +2977,12 @@ int jfs_sync(void *arg)
anon_inode_list
);
anon_inode_list
);
ip
=
&
jfs_ip
->
vfs_inode
;
ip
=
&
jfs_ip
->
vfs_inode
;
if
(
!
igrab
(
ip
))
{
/*
/*
* down_trylock returns 0 on success. This is
* Inode is being freed
* inconsistent with spin_trylock.
*/
*/
if
(
!
down_trylock
(
&
jfs_ip
->
commit_sem
))
{
list_del_init
(
&
jfs_ip
->
anon_inode_list
);
}
else
if
(
!
down_trylock
(
&
jfs_ip
->
commit_sem
))
{
/*
/*
* inode will be removed from anonymous list
* inode will be removed from anonymous list
* when it is committed
* when it is committed
...
@@ -2991,6 +2992,8 @@ int jfs_sync(void *arg)
...
@@ -2991,6 +2992,8 @@ int jfs_sync(void *arg)
rc
=
txCommit
(
tid
,
1
,
&
ip
,
0
);
rc
=
txCommit
(
tid
,
1
,
&
ip
,
0
);
txEnd
(
tid
);
txEnd
(
tid
);
up
(
&
jfs_ip
->
commit_sem
);
up
(
&
jfs_ip
->
commit_sem
);
iput
(
ip
);
/*
/*
* Just to be safe. I don't know how
* Just to be safe. I don't know how
* long we can run without blocking
* long we can run without blocking
...
@@ -3010,6 +3013,10 @@ int jfs_sync(void *arg)
...
@@ -3010,6 +3013,10 @@ int jfs_sync(void *arg)
/* Put on anon_list2 */
/* Put on anon_list2 */
list_add
(
&
jfs_ip
->
anon_inode_list
,
list_add
(
&
jfs_ip
->
anon_inode_list
,
&
TxAnchor
.
anon_list2
);
&
TxAnchor
.
anon_list2
);
TXN_UNLOCK
();
iput
(
ip
);
TXN_LOCK
();
}
}
}
}
/* Add anon_list2 back to anon_list */
/* Add anon_list2 back to anon_list */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment