Commit 30c67e93 authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'gpio-for-linus' of git://git.secretlab.ca/git/linux

Pull GPIO changes from Grant Likely:
 "The usual selection of bug fixes and driver updates for GPIO.  Nothing
  really stands out except the addition of the GRGPIO driver and some
  enhacements to ACPI support"

I'm pulling this despite the earlier mess.  Let's hope it compiles these
days.

* tag 'gpio-for-linus' of git://git.secretlab.ca/git/linux: (46 commits)
  gpio: grgpio: Add irq support
  gpio: grgpio: Add device driver for GRGPIO cores
  gpiolib-acpi: introduce acpi_get_gpio_by_index() helper
  GPIO: gpio-generic: remove kfree() from bgpio_remove call
  gpio / ACPI: Handle ACPI events in accordance with the spec
  gpio: lpc32xx: Fix off-by-one valid range checking for bank
  gpio: mcp23s08: convert driver to DT
  gpio/omap: force restore if context loss is not detectable
  gpio/omap: optimise interrupt service routine
  gpio/omap: remove extra context restores in *_runtime_resume()
  gpio/omap: free irq domain in probe() failure paths
  gpio: gpio-generic: Add 16 and 32 bit big endian byte order support
  gpio: samsung: Add terminating entry for exynos_pinctrl_ids
  gpio: mvebu: add dbg_show function
  MAX7301 GPIO: Do not force SPI speed when using OF Platform
  gpio: gpio-tps65910.c: fix checkpatch error
  gpio: gpio-timberdale.c: fix checkpatch error
  gpio: gpio-tc3589x.c: fix checkpatch errors
  gpio: gpio-stp-xway.c: fix checkpatch error
  gpio: gpio-sch.c: fix checkpatch error
  ...
parents f87bb9ee 08ffb222
...@@ -199,6 +199,8 @@ the device to the driver. For example: ...@@ -199,6 +199,8 @@ the device to the driver. For example:
{ {
Name (SBUF, ResourceTemplate() Name (SBUF, ResourceTemplate()
{ {
...
// Used to power on/off the device
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, GpioIo (Exclusive, PullDefault, 0x0000, 0x0000,
IoRestrictionOutputOnly, "\\_SB.PCI0.GPI0", IoRestrictionOutputOnly, "\\_SB.PCI0.GPI0",
0x00, ResourceConsumer,,) 0x00, ResourceConsumer,,)
...@@ -206,10 +208,20 @@ the device to the driver. For example: ...@@ -206,10 +208,20 @@ the device to the driver. For example:
// Pin List // Pin List
0x0055 0x0055
} }
// Interrupt for the device
GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullNone,
0x0000, "\\_SB.PCI0.GPI0", 0x00, ResourceConsumer,,)
{
// Pin list
0x0058
}
... ...
Return (SBUF)
} }
Return (SBUF)
} }
These GPIO numbers are controller relative and path "\\_SB.PCI0.GPI0" These GPIO numbers are controller relative and path "\\_SB.PCI0.GPI0"
...@@ -220,6 +232,24 @@ The driver can do this by including <linux/acpi_gpio.h> and then calling ...@@ -220,6 +232,24 @@ The driver can do this by including <linux/acpi_gpio.h> and then calling
acpi_get_gpio(path, gpio). This will return the Linux GPIO number or acpi_get_gpio(path, gpio). This will return the Linux GPIO number or
negative errno if there was no translation found. negative errno if there was no translation found.
In a simple case of just getting the Linux GPIO number from device
resources one can use acpi_get_gpio_by_index() helper function. It takes
pointer to the device and index of the GpioIo/GpioInt descriptor in the
device resources list. For example:
int gpio_irq, gpio_power;
int ret;
gpio_irq = acpi_get_gpio_by_index(dev, 1, NULL);
if (gpio_irq < 0)
/* handle error */
gpio_power = acpi_get_gpio_by_index(dev, 0, NULL);
if (gpio_power < 0)
/* handle error */
/* Now we can use the GPIO numbers */
Other GpioIo parameters must be converted first by the driver to be Other GpioIo parameters must be converted first by the driver to be
suitable to the gpiolib before passing them. suitable to the gpiolib before passing them.
......
Aeroflex Gaisler GRGPIO General Purpose I/O cores.
The GRGPIO GPIO core is available in the GRLIB VHDL IP core library.
Note: In the ordinary environment for the GRGPIO core, a Leon SPARC system,
these properties are built from information in the AMBA plug&play.
Required properties:
- name : Should be "GAISLER_GPIO" or "01_01a"
- reg : Address and length of the register set for the device
- interrupts : Interrupt numbers for this device
Optional properties:
- nbits : The number of gpio lines. If not present driver assumes 32 lines.
- irqmap : An array with an index for each gpio line. An index is either a valid
index into the interrupts property array, or 0xffffffff that indicates
no irq for that line. Driver provides no interrupt support if not
present.
For further information look in the documentation for the GLIB IP core library:
http://www.gaisler.com/products/grlib/grip.pdf
Microchip MCP2308/MCP23S08/MCP23017/MCP23S17 driver for
8-/16-bit I/O expander with serial interface (I2C/SPI)
Required properties:
- compatible : Should be
- "mcp,mcp23s08" for 8 GPIO SPI version
- "mcp,mcp23s17" for 16 GPIO SPI version
- "mcp,mcp23008" for 8 GPIO I2C version or
- "mcp,mcp23017" for 16 GPIO I2C version of the chip
- #gpio-cells : Should be two.
- first cell is the pin number
- second cell is used to specify flags. Flags are currently unused.
- gpio-controller : Marks the device node as a GPIO controller.
- reg : For an address on its bus. I2C uses this a the I2C address of the chip.
SPI uses this to specify the chipselect line which the chip is
connected to. The driver and the SPI variant of the chip support
multiple chips on the same chipselect. Have a look at
mcp,spi-present-mask below.
Required device specific properties (only for SPI chips):
- mcp,spi-present-mask : This is a present flag, that makes only sense for SPI
chips - as the name suggests. Multiple SPI chips can share the same
SPI chipselect. Set a bit in bit0-7 in this mask to 1 if there is a
chip connected with the corresponding spi address set. For example if
you have a chip with address 3 connected, you have to set bit3 to 1,
which is 0x08. mcp23s08 chip variant only supports bits 0-3. It is not
possible to mix mcp23s08 and mcp23s17 on the same chipselect. Set at
least one bit to 1 for SPI chips.
- spi-max-frequency = The maximum frequency this chip is able to handle
Example I2C:
gpiom1: gpio@20 {
compatible = "mcp,mcp23017";
gpio-controller;
#gpio-cells = <2>;
reg = <0x20>;
};
Example SPI:
gpiom1: gpio@0 {
compatible = "mcp,mcp23s17";
gpio-controller;
#gpio-cells = <2>;
spi-present-mask = <0x01>;
reg = <0>;
spi-max-frequency = <1000000>;
};
...@@ -21,7 +21,10 @@ Required properties: ...@@ -21,7 +21,10 @@ Required properties:
OMAP specific properties: OMAP specific properties:
- ti,hwmods: Name of the hwmod associated to the GPIO: - ti,hwmods: Name of the hwmod associated to the GPIO:
"gpio<X>", <X> being the 1-based instance number from the HW spec "gpio<X>", <X> being the 1-based instance number
from the HW spec.
- ti,gpio-always-on: Indicates if a GPIO bank is always powered and
so will never lose its logic state.
Example: Example:
......
...@@ -297,12 +297,21 @@ config GPIO_GE_FPGA ...@@ -297,12 +297,21 @@ config GPIO_GE_FPGA
config GPIO_LYNXPOINT config GPIO_LYNXPOINT
bool "Intel Lynxpoint GPIO support" bool "Intel Lynxpoint GPIO support"
depends on ACPI depends on ACPI && X86
select IRQ_DOMAIN select IRQ_DOMAIN
help help
driver for GPIO functionality on Intel Lynxpoint PCH chipset driver for GPIO functionality on Intel Lynxpoint PCH chipset
Requires ACPI device enumeration code to set up a platform device. Requires ACPI device enumeration code to set up a platform device.
config GPIO_GRGPIO
tristate "Aeroflex Gaisler GRGPIO support"
depends on OF
select GPIO_GENERIC
select IRQ_DOMAIN
help
Select this to support Aeroflex Gaisler GRGPIO cores from the GRLIB
VHDL IP core library.
comment "I2C GPIO expanders:" comment "I2C GPIO expanders:"
config GPIO_ARIZONA config GPIO_ARIZONA
......
...@@ -25,6 +25,7 @@ obj-$(CONFIG_ARCH_DAVINCI) += gpio-davinci.o ...@@ -25,6 +25,7 @@ obj-$(CONFIG_ARCH_DAVINCI) += gpio-davinci.o
obj-$(CONFIG_GPIO_EM) += gpio-em.o obj-$(CONFIG_GPIO_EM) += gpio-em.o
obj-$(CONFIG_GPIO_EP93XX) += gpio-ep93xx.o obj-$(CONFIG_GPIO_EP93XX) += gpio-ep93xx.o
obj-$(CONFIG_GPIO_GE_FPGA) += gpio-ge.o obj-$(CONFIG_GPIO_GE_FPGA) += gpio-ge.o
obj-$(CONFIG_GPIO_GRGPIO) += gpio-grgpio.o
obj-$(CONFIG_GPIO_ICH) += gpio-ich.o obj-$(CONFIG_GPIO_ICH) += gpio-ich.o
obj-$(CONFIG_GPIO_IT8761E) += gpio-it8761e.o obj-$(CONFIG_GPIO_IT8761E) += gpio-it8761e.o
obj-$(CONFIG_GPIO_JANZ_TTL) += gpio-janz-ttl.o obj-$(CONFIG_GPIO_JANZ_TTL) += gpio-janz-ttl.o
......
...@@ -137,7 +137,7 @@ static int gen_74x164_probe(struct spi_device *spi) ...@@ -137,7 +137,7 @@ static int gen_74x164_probe(struct spi_device *spi)
mutex_init(&chip->lock); mutex_init(&chip->lock);
dev_set_drvdata(&spi->dev, chip); spi_set_drvdata(spi, chip);
chip->spi = spi; chip->spi = spi;
...@@ -176,7 +176,7 @@ static int gen_74x164_probe(struct spi_device *spi) ...@@ -176,7 +176,7 @@ static int gen_74x164_probe(struct spi_device *spi)
return ret; return ret;
exit_destroy: exit_destroy:
dev_set_drvdata(&spi->dev, NULL); spi_set_drvdata(spi, NULL);
mutex_destroy(&chip->lock); mutex_destroy(&chip->lock);
return ret; return ret;
} }
...@@ -186,11 +186,11 @@ static int gen_74x164_remove(struct spi_device *spi) ...@@ -186,11 +186,11 @@ static int gen_74x164_remove(struct spi_device *spi)
struct gen_74x164_chip *chip; struct gen_74x164_chip *chip;
int ret; int ret;
chip = dev_get_drvdata(&spi->dev); chip = spi_get_drvdata(spi);
if (chip == NULL) if (chip == NULL)
return -ENODEV; return -ENODEV;
dev_set_drvdata(&spi->dev, NULL); spi_set_drvdata(spi, NULL);
ret = gpiochip_remove(&chip->gpio_chip); ret = gpiochip_remove(&chip->gpio_chip);
if (!ret) if (!ret)
......
...@@ -105,7 +105,7 @@ static int adp5520_gpio_probe(struct platform_device *pdev) ...@@ -105,7 +105,7 @@ static int adp5520_gpio_probe(struct platform_device *pdev)
return -ENODEV; return -ENODEV;
} }
dev = kzalloc(sizeof(*dev), GFP_KERNEL); dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
if (dev == NULL) { if (dev == NULL) {
dev_err(&pdev->dev, "failed to alloc memory\n"); dev_err(&pdev->dev, "failed to alloc memory\n");
return -ENOMEM; return -ENOMEM;
...@@ -163,7 +163,6 @@ static int adp5520_gpio_probe(struct platform_device *pdev) ...@@ -163,7 +163,6 @@ static int adp5520_gpio_probe(struct platform_device *pdev)
return 0; return 0;
err: err:
kfree(dev);
return ret; return ret;
} }
...@@ -180,7 +179,6 @@ static int adp5520_gpio_remove(struct platform_device *pdev) ...@@ -180,7 +179,6 @@ static int adp5520_gpio_remove(struct platform_device *pdev)
return ret; return ret;
} }
kfree(dev);
return 0; return 0;
} }
......
...@@ -231,10 +231,12 @@ static int em_gio_irq_domain_map(struct irq_domain *h, unsigned int virq, ...@@ -231,10 +231,12 @@ static int em_gio_irq_domain_map(struct irq_domain *h, unsigned int virq,
static struct irq_domain_ops em_gio_irq_domain_ops = { static struct irq_domain_ops em_gio_irq_domain_ops = {
.map = em_gio_irq_domain_map, .map = em_gio_irq_domain_map,
.xlate = irq_domain_xlate_twocell,
}; };
static int em_gio_probe(struct platform_device *pdev) static int em_gio_probe(struct platform_device *pdev)
{ {
struct gpio_em_config pdata_dt;
struct gpio_em_config *pdata = pdev->dev.platform_data; struct gpio_em_config *pdata = pdev->dev.platform_data;
struct em_gio_priv *p; struct em_gio_priv *p;
struct resource *io[2], *irq[2]; struct resource *io[2], *irq[2];
...@@ -243,7 +245,7 @@ static int em_gio_probe(struct platform_device *pdev) ...@@ -243,7 +245,7 @@ static int em_gio_probe(struct platform_device *pdev)
const char *name = dev_name(&pdev->dev); const char *name = dev_name(&pdev->dev);
int ret; int ret;
p = kzalloc(sizeof(*p), GFP_KERNEL); p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
if (!p) { if (!p) {
dev_err(&pdev->dev, "failed to allocate driver data\n"); dev_err(&pdev->dev, "failed to allocate driver data\n");
ret = -ENOMEM; ret = -ENOMEM;
...@@ -259,24 +261,45 @@ static int em_gio_probe(struct platform_device *pdev) ...@@ -259,24 +261,45 @@ static int em_gio_probe(struct platform_device *pdev)
irq[0] = platform_get_resource(pdev, IORESOURCE_IRQ, 0); irq[0] = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
irq[1] = platform_get_resource(pdev, IORESOURCE_IRQ, 1); irq[1] = platform_get_resource(pdev, IORESOURCE_IRQ, 1);
if (!io[0] || !io[1] || !irq[0] || !irq[1] || !pdata) { if (!io[0] || !io[1] || !irq[0] || !irq[1]) {
dev_err(&pdev->dev, "missing IRQ, IOMEM or configuration\n"); dev_err(&pdev->dev, "missing IRQ or IOMEM\n");
ret = -EINVAL; ret = -EINVAL;
goto err1; goto err0;
} }
p->base0 = ioremap_nocache(io[0]->start, resource_size(io[0])); p->base0 = devm_ioremap_nocache(&pdev->dev, io[0]->start,
resource_size(io[0]));
if (!p->base0) { if (!p->base0) {
dev_err(&pdev->dev, "failed to remap low I/O memory\n"); dev_err(&pdev->dev, "failed to remap low I/O memory\n");
ret = -ENXIO; ret = -ENXIO;
goto err1; goto err0;
} }
p->base1 = ioremap_nocache(io[1]->start, resource_size(io[1])); p->base1 = devm_ioremap_nocache(&pdev->dev, io[1]->start,
resource_size(io[1]));
if (!p->base1) { if (!p->base1) {
dev_err(&pdev->dev, "failed to remap high I/O memory\n"); dev_err(&pdev->dev, "failed to remap high I/O memory\n");
ret = -ENXIO; ret = -ENXIO;
goto err2; goto err0;
}
if (!pdata) {
memset(&pdata_dt, 0, sizeof(pdata_dt));
pdata = &pdata_dt;
if (of_property_read_u32(pdev->dev.of_node, "ngpios",
&pdata->number_of_pins)) {
dev_err(&pdev->dev, "Missing ngpios OF property\n");
ret = -EINVAL;
goto err0;
}
ret = of_alias_get_id(pdev->dev.of_node, "gpio");
if (ret < 0) {
dev_err(&pdev->dev, "Couldn't get OF id\n");
goto err0;
}
pdata->gpio_base = ret * 32; /* 32 GPIOs per instance */
} }
gpio_chip = &p->gpio_chip; gpio_chip = &p->gpio_chip;
...@@ -306,40 +329,32 @@ static int em_gio_probe(struct platform_device *pdev) ...@@ -306,40 +329,32 @@ static int em_gio_probe(struct platform_device *pdev)
if (!p->irq_domain) { if (!p->irq_domain) {
ret = -ENXIO; ret = -ENXIO;
dev_err(&pdev->dev, "cannot initialize irq domain\n"); dev_err(&pdev->dev, "cannot initialize irq domain\n");
goto err3; goto err0;
} }
if (request_irq(irq[0]->start, em_gio_irq_handler, 0, name, p)) { if (devm_request_irq(&pdev->dev, irq[0]->start,
em_gio_irq_handler, 0, name, p)) {
dev_err(&pdev->dev, "failed to request low IRQ\n"); dev_err(&pdev->dev, "failed to request low IRQ\n");
ret = -ENOENT; ret = -ENOENT;
goto err4; goto err1;
} }
if (request_irq(irq[1]->start, em_gio_irq_handler, 0, name, p)) { if (devm_request_irq(&pdev->dev, irq[1]->start,
em_gio_irq_handler, 0, name, p)) {
dev_err(&pdev->dev, "failed to request high IRQ\n"); dev_err(&pdev->dev, "failed to request high IRQ\n");
ret = -ENOENT; ret = -ENOENT;
goto err5; goto err1;
} }
ret = gpiochip_add(gpio_chip); ret = gpiochip_add(gpio_chip);
if (ret) { if (ret) {
dev_err(&pdev->dev, "failed to add GPIO controller\n"); dev_err(&pdev->dev, "failed to add GPIO controller\n");
goto err6; goto err1;
} }
return 0; return 0;
err6:
free_irq(irq[1]->start, pdev);
err5:
free_irq(irq[0]->start, pdev);
err4:
irq_domain_remove(p->irq_domain);
err3:
iounmap(p->base1);
err2:
iounmap(p->base0);
err1: err1:
kfree(p); irq_domain_remove(p->irq_domain);
err0: err0:
return ret; return ret;
} }
...@@ -347,34 +362,43 @@ static int em_gio_probe(struct platform_device *pdev) ...@@ -347,34 +362,43 @@ static int em_gio_probe(struct platform_device *pdev)
static int em_gio_remove(struct platform_device *pdev) static int em_gio_remove(struct platform_device *pdev)
{ {
struct em_gio_priv *p = platform_get_drvdata(pdev); struct em_gio_priv *p = platform_get_drvdata(pdev);
struct resource *irq[2];
int ret; int ret;
ret = gpiochip_remove(&p->gpio_chip); ret = gpiochip_remove(&p->gpio_chip);
if (ret) if (ret)
return ret; return ret;
irq[0] = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
irq[1] = platform_get_resource(pdev, IORESOURCE_IRQ, 1);
free_irq(irq[1]->start, pdev);
free_irq(irq[0]->start, pdev);
irq_domain_remove(p->irq_domain); irq_domain_remove(p->irq_domain);
iounmap(p->base1);
iounmap(p->base0);
kfree(p);
return 0; return 0;
} }
static const struct of_device_id em_gio_dt_ids[] = {
{ .compatible = "renesas,em-gio", },
{},
};
MODULE_DEVICE_TABLE(of, em_gio_dt_ids);
static struct platform_driver em_gio_device_driver = { static struct platform_driver em_gio_device_driver = {
.probe = em_gio_probe, .probe = em_gio_probe,
.remove = em_gio_remove, .remove = em_gio_remove,
.driver = { .driver = {
.name = "em_gio", .name = "em_gio",
.of_match_table = em_gio_dt_ids,
.owner = THIS_MODULE,
} }
}; };
module_platform_driver(em_gio_device_driver); static int __init em_gio_init(void)
{
return platform_driver_register(&em_gio_device_driver);
}
postcore_initcall(em_gio_init);
static void __exit em_gio_exit(void)
{
platform_driver_unregister(&em_gio_device_driver);
}
module_exit(em_gio_exit);
MODULE_AUTHOR("Magnus Damm"); MODULE_AUTHOR("Magnus Damm");
MODULE_DESCRIPTION("Renesas Emma Mobile GIO Driver"); MODULE_DESCRIPTION("Renesas Emma Mobile GIO Driver");
......
...@@ -104,6 +104,26 @@ static unsigned long bgpio_read64(void __iomem *reg) ...@@ -104,6 +104,26 @@ static unsigned long bgpio_read64(void __iomem *reg)
} }
#endif /* BITS_PER_LONG >= 64 */ #endif /* BITS_PER_LONG >= 64 */
static void bgpio_write16be(void __iomem *reg, unsigned long data)
{
iowrite16be(data, reg);
}
static unsigned long bgpio_read16be(void __iomem *reg)
{
return ioread16be(reg);
}
static void bgpio_write32be(void __iomem *reg, unsigned long data)
{
iowrite32be(data, reg);
}
static unsigned long bgpio_read32be(void __iomem *reg)
{
return ioread32be(reg);
}
static unsigned long bgpio_pin2mask(struct bgpio_chip *bgc, unsigned int pin) static unsigned long bgpio_pin2mask(struct bgpio_chip *bgc, unsigned int pin)
{ {
return 1 << pin; return 1 << pin;
...@@ -249,7 +269,8 @@ static int bgpio_dir_out_inv(struct gpio_chip *gc, unsigned int gpio, int val) ...@@ -249,7 +269,8 @@ static int bgpio_dir_out_inv(struct gpio_chip *gc, unsigned int gpio, int val)
static int bgpio_setup_accessors(struct device *dev, static int bgpio_setup_accessors(struct device *dev,
struct bgpio_chip *bgc, struct bgpio_chip *bgc,
bool be) bool bit_be,
bool byte_be)
{ {
switch (bgc->bits) { switch (bgc->bits) {
...@@ -258,17 +279,33 @@ static int bgpio_setup_accessors(struct device *dev, ...@@ -258,17 +279,33 @@ static int bgpio_setup_accessors(struct device *dev,
bgc->write_reg = bgpio_write8; bgc->write_reg = bgpio_write8;
break; break;
case 16: case 16:
if (byte_be) {
bgc->read_reg = bgpio_read16be;
bgc->write_reg = bgpio_write16be;
} else {
bgc->read_reg = bgpio_read16; bgc->read_reg = bgpio_read16;
bgc->write_reg = bgpio_write16; bgc->write_reg = bgpio_write16;
}
break; break;
case 32: case 32:
if (byte_be) {
bgc->read_reg = bgpio_read32be;
bgc->write_reg = bgpio_write32be;
} else {
bgc->read_reg = bgpio_read32; bgc->read_reg = bgpio_read32;
bgc->write_reg = bgpio_write32; bgc->write_reg = bgpio_write32;
}
break; break;
#if BITS_PER_LONG >= 64 #if BITS_PER_LONG >= 64
case 64: case 64:
if (byte_be) {
dev_err(dev,
"64 bit big endian byte order unsupported\n");
return -EINVAL;
} else {
bgc->read_reg = bgpio_read64; bgc->read_reg = bgpio_read64;
bgc->write_reg = bgpio_write64; bgc->write_reg = bgpio_write64;
}
break; break;
#endif /* BITS_PER_LONG >= 64 */ #endif /* BITS_PER_LONG >= 64 */
default: default:
...@@ -276,7 +313,7 @@ static int bgpio_setup_accessors(struct device *dev, ...@@ -276,7 +313,7 @@ static int bgpio_setup_accessors(struct device *dev,
return -EINVAL; return -EINVAL;
} }
bgc->pin2mask = be ? bgpio_pin2mask_be : bgpio_pin2mask; bgc->pin2mask = bit_be ? bgpio_pin2mask_be : bgpio_pin2mask;
return 0; return 0;
} }
...@@ -353,11 +390,7 @@ static int bgpio_setup_direction(struct bgpio_chip *bgc, ...@@ -353,11 +390,7 @@ static int bgpio_setup_direction(struct bgpio_chip *bgc,
int bgpio_remove(struct bgpio_chip *bgc) int bgpio_remove(struct bgpio_chip *bgc)
{ {
int err = gpiochip_remove(&bgc->gc); return gpiochip_remove(&bgc->gc);
kfree(bgc);
return err;
} }
EXPORT_SYMBOL_GPL(bgpio_remove); EXPORT_SYMBOL_GPL(bgpio_remove);
...@@ -385,7 +418,8 @@ int bgpio_init(struct bgpio_chip *bgc, struct device *dev, ...@@ -385,7 +418,8 @@ int bgpio_init(struct bgpio_chip *bgc, struct device *dev,
if (ret) if (ret)
return ret; return ret;
ret = bgpio_setup_accessors(dev, bgc, flags & BGPIOF_BIG_ENDIAN); ret = bgpio_setup_accessors(dev, bgc, flags & BGPIOF_BIG_ENDIAN,
flags & BGPIOF_BIG_ENDIAN_BYTE_ORDER);
if (ret) if (ret)
return ret; return ret;
......
/*
* Driver for Aeroflex Gaisler GRGPIO General Purpose I/O cores.
*
* 2013 (c) Aeroflex Gaisler AB
*
* This driver supports the GRGPIO GPIO core available in the GRLIB VHDL
* IP core library.
*
* Full documentation of the GRGPIO core can be found here:
* http://www.gaisler.com/products/grlib/grip.pdf
*
* See "Documentation/devicetree/bindings/gpio/gpio-grgpio.txt" for
* information on open firmware properties.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*
* Contributors: Andreas Larsson <andreas@gaisler.com>
*/
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/spinlock.h>
#include <linux/io.h>
#include <linux/of.h>
#include <linux/of_gpio.h>
#include <linux/of_platform.h>
#include <linux/gpio.h>
#include <linux/slab.h>
#include <linux/err.h>
#include <linux/basic_mmio_gpio.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
#define GRGPIO_MAX_NGPIO 32
#define GRGPIO_DATA 0x00
#define GRGPIO_OUTPUT 0x04
#define GRGPIO_DIR 0x08
#define GRGPIO_IMASK 0x0c
#define GRGPIO_IPOL 0x10
#define GRGPIO_IEDGE 0x14
#define GRGPIO_BYPASS 0x18
#define GRGPIO_IMAP_BASE 0x20
/* Structure for an irq of the core - called an underlying irq */
struct grgpio_uirq {
u8 refcnt; /* Reference counter to manage requesting/freeing of uirq */
u8 uirq; /* Underlying irq of the gpio driver */
};
/*
* Structure for an irq of a gpio line handed out by this driver. The index is
* used to map to the corresponding underlying irq.
*/
struct grgpio_lirq {
s8 index; /* Index into struct grgpio_priv's uirqs, or -1 */
u8 irq; /* irq for the gpio line */
};
struct grgpio_priv {
struct bgpio_chip bgc;
void __iomem *regs;
struct device *dev;
u32 imask; /* irq mask shadow register */
/*
* The grgpio core can have multiple "underlying" irqs. The gpio lines
* can be mapped to any one or none of these underlying irqs
* independently of each other. This driver sets up an irq domain and
* hands out separate irqs to each gpio line
*/
struct irq_domain *domain;
/*
* This array contains information on each underlying irq, each
* irq of the grgpio core itself.
*/
struct grgpio_uirq uirqs[GRGPIO_MAX_NGPIO];
/*
* This array contains information for each gpio line on the irqs
* obtains from this driver. An index value of -1 for a certain gpio
* line indicates that the line has no irq. Otherwise the index connects
* the irq to the underlying irq by pointing into the uirqs array.
*/
struct grgpio_lirq lirqs[GRGPIO_MAX_NGPIO];
};
static inline struct grgpio_priv *grgpio_gc_to_priv(struct gpio_chip *gc)
{
struct bgpio_chip *bgc = to_bgpio_chip(gc);
return container_of(bgc, struct grgpio_priv, bgc);
}
static void grgpio_set_imask(struct grgpio_priv *priv, unsigned int offset,
int val)
{
struct bgpio_chip *bgc = &priv->bgc;
unsigned long mask = bgc->pin2mask(bgc, offset);
unsigned long flags;
spin_lock_irqsave(&bgc->lock, flags);
if (val)
priv->imask |= mask;
else
priv->imask &= ~mask;
bgc->write_reg(priv->regs + GRGPIO_IMASK, priv->imask);
spin_unlock_irqrestore(&bgc->lock, flags);
}
static int grgpio_to_irq(struct gpio_chip *gc, unsigned offset)
{
struct grgpio_priv *priv = grgpio_gc_to_priv(gc);
if (offset > gc->ngpio)
return -ENXIO;
if (priv->lirqs[offset].index < 0)
return -ENXIO;
return irq_create_mapping(priv->domain, offset);
}
/* -------------------- IRQ chip functions -------------------- */
static int grgpio_irq_set_type(struct irq_data *d, unsigned int type)
{
struct grgpio_priv *priv = irq_data_get_irq_chip_data(d);
unsigned long flags;
u32 mask = BIT(d->hwirq);
u32 ipol;
u32 iedge;
u32 pol;
u32 edge;
switch (type) {
case IRQ_TYPE_LEVEL_LOW:
pol = 0;
edge = 0;
break;
case IRQ_TYPE_LEVEL_HIGH:
pol = mask;
edge = 0;
break;
case IRQ_TYPE_EDGE_FALLING:
pol = 0;
edge = mask;
break;
case IRQ_TYPE_EDGE_RISING:
pol = mask;
edge = mask;
break;
default:
return -EINVAL;
}
spin_lock_irqsave(&priv->bgc.lock, flags);
ipol = priv->bgc.read_reg(priv->regs + GRGPIO_IPOL) & ~mask;
iedge = priv->bgc.read_reg(priv->regs + GRGPIO_IEDGE) & ~mask;
priv->bgc.write_reg(priv->regs + GRGPIO_IPOL, ipol | pol);
priv->bgc.write_reg(priv->regs + GRGPIO_IEDGE, iedge | edge);
spin_unlock_irqrestore(&priv->bgc.lock, flags);
return 0;
}
static void grgpio_irq_mask(struct irq_data *d)
{
struct grgpio_priv *priv = irq_data_get_irq_chip_data(d);
int offset = d->hwirq;
grgpio_set_imask(priv, offset, 0);
}
static void grgpio_irq_unmask(struct irq_data *d)
{
struct grgpio_priv *priv = irq_data_get_irq_chip_data(d);
int offset = d->hwirq;
grgpio_set_imask(priv, offset, 1);
}
static struct irq_chip grgpio_irq_chip = {
.name = "grgpio",
.irq_mask = grgpio_irq_mask,
.irq_unmask = grgpio_irq_unmask,
.irq_set_type = grgpio_irq_set_type,
};
static irqreturn_t grgpio_irq_handler(int irq, void *dev)
{
struct grgpio_priv *priv = dev;
int ngpio = priv->bgc.gc.ngpio;
unsigned long flags;
int i;
int match = 0;
spin_lock_irqsave(&priv->bgc.lock, flags);
/*
* For each gpio line, call its interrupt handler if it its underlying
* irq matches the current irq that is handled.
*/
for (i = 0; i < ngpio; i++) {
struct grgpio_lirq *lirq = &priv->lirqs[i];
if (priv->imask & BIT(i) && lirq->index >= 0 &&
priv->uirqs[lirq->index].uirq == irq) {
generic_handle_irq(lirq->irq);
match = 1;
}
}
spin_unlock_irqrestore(&priv->bgc.lock, flags);
if (!match)
dev_warn(priv->dev, "No gpio line matched irq %d\n", irq);
return IRQ_HANDLED;
}
/*
* This function will be called as a consequence of the call to
* irq_create_mapping in grgpio_to_irq
*/
int grgpio_irq_map(struct irq_domain *d, unsigned int irq,
irq_hw_number_t hwirq)
{
struct grgpio_priv *priv = d->host_data;
struct grgpio_lirq *lirq;
struct grgpio_uirq *uirq;
unsigned long flags;
int offset = hwirq;
int ret = 0;
if (!priv)
return -EINVAL;
lirq = &priv->lirqs[offset];
if (lirq->index < 0)
return -EINVAL;
dev_dbg(priv->dev, "Mapping irq %d for gpio line %d\n",
irq, offset);
spin_lock_irqsave(&priv->bgc.lock, flags);
/* Request underlying irq if not already requested */
lirq->irq = irq;
uirq = &priv->uirqs[lirq->index];
if (uirq->refcnt == 0) {
ret = request_irq(uirq->uirq, grgpio_irq_handler, 0,
dev_name(priv->dev), priv);
if (ret) {
dev_err(priv->dev,
"Could not request underlying irq %d\n",
uirq->uirq);
spin_unlock_irqrestore(&priv->bgc.lock, flags);
return ret;
}
}
uirq->refcnt++;
spin_unlock_irqrestore(&priv->bgc.lock, flags);
/* Setup irq */
irq_set_chip_data(irq, priv);
irq_set_chip_and_handler(irq, &grgpio_irq_chip,
handle_simple_irq);
irq_clear_status_flags(irq, IRQ_NOREQUEST);
#ifdef CONFIG_ARM
set_irq_flags(irq, IRQF_VALID);
#else
irq_set_noprobe(irq);
#endif
return ret;
}
void grgpio_irq_unmap(struct irq_domain *d, unsigned int irq)
{
struct grgpio_priv *priv = d->host_data;
int index;
struct grgpio_lirq *lirq;
struct grgpio_uirq *uirq;
unsigned long flags;
int ngpio = priv->bgc.gc.ngpio;
int i;
#ifdef CONFIG_ARM
set_irq_flags(irq, 0);
#endif
irq_set_chip_and_handler(irq, NULL, NULL);
irq_set_chip_data(irq, NULL);
spin_lock_irqsave(&priv->bgc.lock, flags);
/* Free underlying irq if last user unmapped */
index = -1;
for (i = 0; i < ngpio; i++) {
lirq = &priv->lirqs[i];
if (lirq->irq == irq) {
grgpio_set_imask(priv, i, 0);
lirq->irq = 0;
index = lirq->index;
break;
}
}
WARN_ON(index < 0);
if (index >= 0) {
uirq = &priv->uirqs[lirq->index];
uirq->refcnt--;
if (uirq->refcnt == 0)
free_irq(uirq->uirq, priv);
}
spin_unlock_irqrestore(&priv->bgc.lock, flags);
}
static struct irq_domain_ops grgpio_irq_domain_ops = {
.map = grgpio_irq_map,
.unmap = grgpio_irq_unmap,
};
/* ------------------------------------------------------------ */
static int grgpio_probe(struct platform_device *ofdev)
{
struct device_node *np = ofdev->dev.of_node;
void __iomem *regs;
struct gpio_chip *gc;
struct bgpio_chip *bgc;
struct grgpio_priv *priv;
struct resource *res;
int err;
u32 prop;
s32 *irqmap;
int size;
int i;
priv = devm_kzalloc(&ofdev->dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
regs = devm_ioremap_resource(&ofdev->dev, res);
if (IS_ERR(regs))
return PTR_ERR(regs);
bgc = &priv->bgc;
err = bgpio_init(bgc, &ofdev->dev, 4, regs + GRGPIO_DATA,
regs + GRGPIO_OUTPUT, NULL, regs + GRGPIO_DIR, NULL,
BGPIOF_BIG_ENDIAN_BYTE_ORDER);
if (err) {
dev_err(&ofdev->dev, "bgpio_init() failed\n");
return err;
}
priv->regs = regs;
priv->imask = bgc->read_reg(regs + GRGPIO_IMASK);
priv->dev = &ofdev->dev;
gc = &bgc->gc;
gc->of_node = np;
gc->owner = THIS_MODULE;
gc->to_irq = grgpio_to_irq;
gc->label = np->full_name;
gc->base = -1;
err = of_property_read_u32(np, "nbits", &prop);
if (err || prop <= 0 || prop > GRGPIO_MAX_NGPIO) {
gc->ngpio = GRGPIO_MAX_NGPIO;
dev_dbg(&ofdev->dev,
"No or invalid nbits property: assume %d\n", gc->ngpio);
} else {
gc->ngpio = prop;
}
/*
* The irqmap contains the index values indicating which underlying irq,
* if anyone, is connected to that line
*/
irqmap = (s32 *)of_get_property(np, "irqmap", &size);
if (irqmap) {
if (size < gc->ngpio) {
dev_err(&ofdev->dev,
"irqmap shorter than ngpio (%d < %d)\n",
size, gc->ngpio);
return -EINVAL;
}
priv->domain = irq_domain_add_linear(np, gc->ngpio,
&grgpio_irq_domain_ops,
priv);
if (!priv->domain) {
dev_err(&ofdev->dev, "Could not add irq domain\n");
return -EINVAL;
}
for (i = 0; i < gc->ngpio; i++) {
struct grgpio_lirq *lirq;
int ret;
lirq = &priv->lirqs[i];
lirq->index = irqmap[i];
if (lirq->index < 0)
continue;
ret = platform_get_irq(ofdev, lirq->index);
if (ret <= 0) {
/*
* Continue without irq functionality for that
* gpio line
*/
dev_err(priv->dev,
"Failed to get irq for offset %d\n", i);
continue;
}
priv->uirqs[lirq->index].uirq = ret;
}
}
platform_set_drvdata(ofdev, priv);
err = gpiochip_add(gc);
if (err) {
dev_err(&ofdev->dev, "Could not add gpiochip\n");
return err;
}
dev_info(&ofdev->dev, "regs=0x%p, base=%d, ngpio=%d, irqs=%s\n",
priv->regs, gc->base, gc->ngpio, priv->domain ? "on" : "off");
return 0;
}
static int grgpio_remove(struct platform_device *ofdev)
{
struct grgpio_priv *priv = platform_get_drvdata(ofdev);
unsigned long flags;
int i;
int ret = 0;
spin_lock_irqsave(&priv->bgc.lock, flags);
if (priv->domain) {
for (i = 0; i < GRGPIO_MAX_NGPIO; i++) {
if (priv->uirqs[i].refcnt != 0) {
ret = -EBUSY;
goto out;
}
}
}
ret = gpiochip_remove(&priv->bgc.gc);
if (ret)
goto out;
if (priv->domain)
irq_domain_remove(priv->domain);
out:
spin_unlock_irqrestore(&priv->bgc.lock, flags);
return ret;
}
static struct of_device_id grgpio_match[] = {
{.name = "GAISLER_GPIO"},
{.name = "01_01a"},
{},
};
MODULE_DEVICE_TABLE(of, grgpio_match);
static struct platform_driver grgpio_driver = {
.driver = {
.name = "grgpio",
.owner = THIS_MODULE,
.of_match_table = grgpio_match,
},
.probe = grgpio_probe,
.remove = grgpio_remove,
};
module_platform_driver(grgpio_driver);
MODULE_AUTHOR("Aeroflex Gaisler AB.");
MODULE_DESCRIPTION("Driver for Aeroflex Gaisler GRGPIO");
MODULE_LICENSE("GPL");
...@@ -130,14 +130,11 @@ static int ichx_read_bit(int reg, unsigned nr) ...@@ -130,14 +130,11 @@ static int ichx_read_bit(int reg, unsigned nr)
static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr) static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr)
{ {
return ichx_priv.use_gpio & (1 << (nr / 32)); return !!(ichx_priv.use_gpio & (1 << (nr / 32)));
} }
static int ichx_gpio_direction_input(struct gpio_chip *gpio, unsigned nr) static int ichx_gpio_direction_input(struct gpio_chip *gpio, unsigned nr)
{ {
if (!ichx_gpio_check_available(gpio, nr))
return -ENXIO;
/* /*
* Try setting pin as an input and verify it worked since many pins * Try setting pin as an input and verify it worked since many pins
* are output-only. * are output-only.
...@@ -151,9 +148,6 @@ static int ichx_gpio_direction_input(struct gpio_chip *gpio, unsigned nr) ...@@ -151,9 +148,6 @@ static int ichx_gpio_direction_input(struct gpio_chip *gpio, unsigned nr)
static int ichx_gpio_direction_output(struct gpio_chip *gpio, unsigned nr, static int ichx_gpio_direction_output(struct gpio_chip *gpio, unsigned nr,
int val) int val)
{ {
if (!ichx_gpio_check_available(gpio, nr))
return -ENXIO;
/* Set GPIO output value. */ /* Set GPIO output value. */
ichx_write_bit(GPIO_LVL, nr, val, 0); ichx_write_bit(GPIO_LVL, nr, val, 0);
...@@ -169,9 +163,6 @@ static int ichx_gpio_direction_output(struct gpio_chip *gpio, unsigned nr, ...@@ -169,9 +163,6 @@ static int ichx_gpio_direction_output(struct gpio_chip *gpio, unsigned nr,
static int ichx_gpio_get(struct gpio_chip *chip, unsigned nr) static int ichx_gpio_get(struct gpio_chip *chip, unsigned nr)
{ {
if (!ichx_gpio_check_available(chip, nr))
return -ENXIO;
return ichx_read_bit(GPIO_LVL, nr); return ichx_read_bit(GPIO_LVL, nr);
} }
...@@ -180,9 +171,6 @@ static int ich6_gpio_get(struct gpio_chip *chip, unsigned nr) ...@@ -180,9 +171,6 @@ static int ich6_gpio_get(struct gpio_chip *chip, unsigned nr)
unsigned long flags; unsigned long flags;
u32 data; u32 data;
if (!ichx_gpio_check_available(chip, nr))
return -ENXIO;
/* /*
* GPI 0 - 15 need to be read from the power management registers on * GPI 0 - 15 need to be read from the power management registers on
* a ICH6/3100 bridge. * a ICH6/3100 bridge.
...@@ -207,6 +195,9 @@ static int ich6_gpio_get(struct gpio_chip *chip, unsigned nr) ...@@ -207,6 +195,9 @@ static int ich6_gpio_get(struct gpio_chip *chip, unsigned nr)
static int ichx_gpio_request(struct gpio_chip *chip, unsigned nr) static int ichx_gpio_request(struct gpio_chip *chip, unsigned nr)
{ {
if (!ichx_gpio_check_available(chip, nr))
return -ENXIO;
/* /*
* Note we assume the BIOS properly set a bridge's USE value. Some * Note we assume the BIOS properly set a bridge's USE value. Some
* chips (eg Intel 3100) have bogus USE values though, so first see if * chips (eg Intel 3100) have bogus USE values though, so first see if
......
...@@ -533,7 +533,7 @@ static int lpc32xx_of_xlate(struct gpio_chip *gc, ...@@ -533,7 +533,7 @@ static int lpc32xx_of_xlate(struct gpio_chip *gc,
{ {
/* Is this the correct bank? */ /* Is this the correct bank? */
u32 bank = gpiospec->args[0]; u32 bank = gpiospec->args[0];
if ((bank > ARRAY_SIZE(lpc32xx_gpiochip) || if ((bank >= ARRAY_SIZE(lpc32xx_gpiochip) ||
(gc != &lpc32xx_gpiochip[bank].chip))) (gc != &lpc32xx_gpiochip[bank].chip)))
return -EINVAL; return -EINVAL;
......
...@@ -32,6 +32,7 @@ ...@@ -32,6 +32,7 @@
#include <linux/acpi.h> #include <linux/acpi.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/pm_runtime.h> #include <linux/pm_runtime.h>
#include <linux/io.h>
/* LynxPoint chipset has support for 94 gpio pins */ /* LynxPoint chipset has support for 94 gpio pins */
......
...@@ -41,7 +41,7 @@ static int max7300_probe(struct i2c_client *client, ...@@ -41,7 +41,7 @@ static int max7300_probe(struct i2c_client *client,
I2C_FUNC_SMBUS_BYTE_DATA)) I2C_FUNC_SMBUS_BYTE_DATA))
return -EIO; return -EIO;
ts = kzalloc(sizeof(struct max7301), GFP_KERNEL); ts = devm_kzalloc(&client->dev, sizeof(struct max7301), GFP_KERNEL);
if (!ts) if (!ts)
return -ENOMEM; return -ENOMEM;
...@@ -50,8 +50,6 @@ static int max7300_probe(struct i2c_client *client, ...@@ -50,8 +50,6 @@ static int max7300_probe(struct i2c_client *client,
ts->dev = &client->dev; ts->dev = &client->dev;
ret = __max730x_probe(ts); ret = __max730x_probe(ts);
if (ret)
kfree(ts);
return ret; return ret;
} }
......
...@@ -56,12 +56,13 @@ static int max7301_probe(struct spi_device *spi) ...@@ -56,12 +56,13 @@ static int max7301_probe(struct spi_device *spi)
int ret; int ret;
/* bits_per_word cannot be configured in platform data */ /* bits_per_word cannot be configured in platform data */
if (spi->dev.platform_data)
spi->bits_per_word = 16; spi->bits_per_word = 16;
ret = spi_setup(spi); ret = spi_setup(spi);
if (ret < 0) if (ret < 0)
return ret; return ret;
ts = kzalloc(sizeof(struct max7301), GFP_KERNEL); ts = devm_kzalloc(&spi->dev, sizeof(struct max7301), GFP_KERNEL);
if (!ts) if (!ts)
return -ENOMEM; return -ENOMEM;
...@@ -70,8 +71,6 @@ static int max7301_probe(struct spi_device *spi) ...@@ -70,8 +71,6 @@ static int max7301_probe(struct spi_device *spi)
ts->dev = &spi->dev; ts->dev = &spi->dev;
ret = __max730x_probe(ts); ret = __max730x_probe(ts);
if (ret)
kfree(ts);
return ret; return ret;
} }
......
...@@ -589,7 +589,8 @@ static int max732x_probe(struct i2c_client *client, ...@@ -589,7 +589,8 @@ static int max732x_probe(struct i2c_client *client,
return -EINVAL; return -EINVAL;
} }
chip = kzalloc(sizeof(struct max732x_chip), GFP_KERNEL); chip = devm_kzalloc(&client->dev, sizeof(struct max732x_chip),
GFP_KERNEL);
if (chip == NULL) if (chip == NULL)
return -ENOMEM; return -ENOMEM;
chip->client = client; chip->client = client;
...@@ -647,7 +648,6 @@ static int max732x_probe(struct i2c_client *client, ...@@ -647,7 +648,6 @@ static int max732x_probe(struct i2c_client *client,
out_failed: out_failed:
max732x_irq_teardown(chip); max732x_irq_teardown(chip);
kfree(chip);
return ret; return ret;
} }
...@@ -680,7 +680,6 @@ static int max732x_remove(struct i2c_client *client) ...@@ -680,7 +680,6 @@ static int max732x_remove(struct i2c_client *client)
if (chip->client_dummy) if (chip->client_dummy)
i2c_unregister_device(chip->client_dummy); i2c_unregister_device(chip->client_dummy);
kfree(chip);
return 0; return 0;
} }
......
...@@ -101,13 +101,13 @@ static int mc33880_probe(struct spi_device *spi) ...@@ -101,13 +101,13 @@ static int mc33880_probe(struct spi_device *spi)
if (ret < 0) if (ret < 0)
return ret; return ret;
mc = kzalloc(sizeof(struct mc33880), GFP_KERNEL); mc = devm_kzalloc(&spi->dev, sizeof(struct mc33880), GFP_KERNEL);
if (!mc) if (!mc)
return -ENOMEM; return -ENOMEM;
mutex_init(&mc->lock); mutex_init(&mc->lock);
dev_set_drvdata(&spi->dev, mc); spi_set_drvdata(spi, mc);
mc->spi = spi; mc->spi = spi;
...@@ -130,7 +130,8 @@ static int mc33880_probe(struct spi_device *spi) ...@@ -130,7 +130,8 @@ static int mc33880_probe(struct spi_device *spi)
ret = mc33880_write_config(mc); ret = mc33880_write_config(mc);
if (ret) { if (ret) {
printk(KERN_ERR "Failed writing to " DRIVER_NAME ": %d\n", ret); dev_err(&spi->dev, "Failed writing to " DRIVER_NAME ": %d\n",
ret);
goto exit_destroy; goto exit_destroy;
} }
...@@ -141,9 +142,8 @@ static int mc33880_probe(struct spi_device *spi) ...@@ -141,9 +142,8 @@ static int mc33880_probe(struct spi_device *spi)
return ret; return ret;
exit_destroy: exit_destroy:
dev_set_drvdata(&spi->dev, NULL); spi_set_drvdata(spi, NULL);
mutex_destroy(&mc->lock); mutex_destroy(&mc->lock);
kfree(mc);
return ret; return ret;
} }
...@@ -152,17 +152,16 @@ static int mc33880_remove(struct spi_device *spi) ...@@ -152,17 +152,16 @@ static int mc33880_remove(struct spi_device *spi)
struct mc33880 *mc; struct mc33880 *mc;
int ret; int ret;
mc = dev_get_drvdata(&spi->dev); mc = spi_get_drvdata(spi);
if (mc == NULL) if (mc == NULL)
return -ENODEV; return -ENODEV;
dev_set_drvdata(&spi->dev, NULL); spi_set_drvdata(spi, NULL);
ret = gpiochip_remove(&mc->chip); ret = gpiochip_remove(&mc->chip);
if (!ret) { if (!ret)
mutex_destroy(&mc->lock); mutex_destroy(&mc->lock);
kfree(mc); else
} else
dev_err(&spi->dev, "Failed to remove the GPIO controller: %d\n", dev_err(&spi->dev, "Failed to remove the GPIO controller: %d\n",
ret); ret);
......
...@@ -12,6 +12,8 @@ ...@@ -12,6 +12,8 @@
#include <linux/spi/mcp23s08.h> #include <linux/spi/mcp23s08.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <asm/byteorder.h> #include <asm/byteorder.h>
#include <linux/of.h>
#include <linux/of_device.h>
/** /**
* MCP types supported by driver * MCP types supported by driver
...@@ -383,6 +385,10 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev, ...@@ -383,6 +385,10 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev,
mcp->chip.direction_output = mcp23s08_direction_output; mcp->chip.direction_output = mcp23s08_direction_output;
mcp->chip.set = mcp23s08_set; mcp->chip.set = mcp23s08_set;
mcp->chip.dbg_show = mcp23s08_dbg_show; mcp->chip.dbg_show = mcp23s08_dbg_show;
#ifdef CONFIG_OF
mcp->chip.of_gpio_n_cells = 2;
mcp->chip.of_node = dev->of_node;
#endif
switch (type) { switch (type) {
#ifdef CONFIG_SPI_MASTER #ifdef CONFIG_SPI_MASTER
...@@ -473,6 +479,35 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev, ...@@ -473,6 +479,35 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev,
/*----------------------------------------------------------------------*/ /*----------------------------------------------------------------------*/
#ifdef CONFIG_OF
#ifdef CONFIG_SPI_MASTER
static struct of_device_id mcp23s08_spi_of_match[] = {
{
.compatible = "mcp,mcp23s08", .data = (void *) MCP_TYPE_S08,
},
{
.compatible = "mcp,mcp23s17", .data = (void *) MCP_TYPE_S17,
},
{ },
};
MODULE_DEVICE_TABLE(of, mcp23s08_spi_of_match);
#endif
#if IS_ENABLED(CONFIG_I2C)
static struct of_device_id mcp23s08_i2c_of_match[] = {
{
.compatible = "mcp,mcp23008", .data = (void *) MCP_TYPE_008,
},
{
.compatible = "mcp,mcp23017", .data = (void *) MCP_TYPE_017,
},
{ },
};
MODULE_DEVICE_TABLE(of, mcp23s08_i2c_of_match);
#endif
#endif /* CONFIG_OF */
#if IS_ENABLED(CONFIG_I2C) #if IS_ENABLED(CONFIG_I2C)
static int mcp230xx_probe(struct i2c_client *client, static int mcp230xx_probe(struct i2c_client *client,
...@@ -480,21 +515,31 @@ static int mcp230xx_probe(struct i2c_client *client, ...@@ -480,21 +515,31 @@ static int mcp230xx_probe(struct i2c_client *client,
{ {
struct mcp23s08_platform_data *pdata; struct mcp23s08_platform_data *pdata;
struct mcp23s08 *mcp; struct mcp23s08 *mcp;
int status; int status, base, pullups;
const struct of_device_id *match;
match = of_match_device(of_match_ptr(mcp23s08_i2c_of_match),
&client->dev);
if (match) {
base = -1;
pullups = 0;
} else {
pdata = client->dev.platform_data; pdata = client->dev.platform_data;
if (!pdata || !gpio_is_valid(pdata->base)) { if (!pdata || !gpio_is_valid(pdata->base)) {
dev_dbg(&client->dev, "invalid or missing platform data\n"); dev_dbg(&client->dev,
"invalid or missing platform data\n");
return -EINVAL; return -EINVAL;
} }
base = pdata->base;
pullups = pdata->chip[0].pullups;
}
mcp = kzalloc(sizeof *mcp, GFP_KERNEL); mcp = kzalloc(sizeof *mcp, GFP_KERNEL);
if (!mcp) if (!mcp)
return -ENOMEM; return -ENOMEM;
status = mcp23s08_probe_one(mcp, &client->dev, client, client->addr, status = mcp23s08_probe_one(mcp, &client->dev, client, client->addr,
id->driver_data, pdata->base, id->driver_data, base, pullups);
pdata->chip[0].pullups);
if (status) if (status)
goto fail; goto fail;
...@@ -531,6 +576,7 @@ static struct i2c_driver mcp230xx_driver = { ...@@ -531,6 +576,7 @@ static struct i2c_driver mcp230xx_driver = {
.driver = { .driver = {
.name = "mcp230xx", .name = "mcp230xx",
.owner = THIS_MODULE, .owner = THIS_MODULE,
.of_match_table = of_match_ptr(mcp23s08_i2c_of_match),
}, },
.probe = mcp230xx_probe, .probe = mcp230xx_probe,
.remove = mcp230xx_remove, .remove = mcp230xx_remove,
...@@ -565,13 +611,34 @@ static int mcp23s08_probe(struct spi_device *spi) ...@@ -565,13 +611,34 @@ static int mcp23s08_probe(struct spi_device *spi)
unsigned chips = 0; unsigned chips = 0;
struct mcp23s08_driver_data *data; struct mcp23s08_driver_data *data;
int status, type; int status, type;
unsigned base; unsigned base = -1,
ngpio = 0,
pullups[ARRAY_SIZE(pdata->chip)];
const struct of_device_id *match;
u32 spi_present_mask = 0;
match = of_match_device(of_match_ptr(mcp23s08_spi_of_match), &spi->dev);
if (match) {
type = (int)match->data;
status = of_property_read_u32(spi->dev.of_node,
"mcp,spi-present-mask", &spi_present_mask);
if (status) {
dev_err(&spi->dev, "DT has no spi-present-mask\n");
return -ENODEV;
}
if ((spi_present_mask <= 0) || (spi_present_mask >= 256)) {
dev_err(&spi->dev, "invalid spi-present-mask\n");
return -ENODEV;
}
for (addr = 0; addr < ARRAY_SIZE(pdata->chip); addr++)
pullups[addr] = 0;
} else {
type = spi_get_device_id(spi)->driver_data; type = spi_get_device_id(spi)->driver_data;
pdata = spi->dev.platform_data; pdata = spi->dev.platform_data;
if (!pdata || !gpio_is_valid(pdata->base)) { if (!pdata || !gpio_is_valid(pdata->base)) {
dev_dbg(&spi->dev, "invalid or missing platform data\n"); dev_dbg(&spi->dev,
"invalid or missing platform data\n");
return -EINVAL; return -EINVAL;
} }
...@@ -584,31 +651,38 @@ static int mcp23s08_probe(struct spi_device *spi) ...@@ -584,31 +651,38 @@ static int mcp23s08_probe(struct spi_device *spi)
"mcp23s08 only supports address 0..3\n"); "mcp23s08 only supports address 0..3\n");
return -EINVAL; return -EINVAL;
} }
spi_present_mask |= 1 << addr;
pullups[addr] = pdata->chip[addr].pullups;
} }
if (!chips) if (!chips)
return -ENODEV; return -ENODEV;
base = pdata->base;
}
data = kzalloc(sizeof *data + chips * sizeof(struct mcp23s08), data = kzalloc(sizeof *data + chips * sizeof(struct mcp23s08),
GFP_KERNEL); GFP_KERNEL);
if (!data) if (!data)
return -ENOMEM; return -ENOMEM;
spi_set_drvdata(spi, data); spi_set_drvdata(spi, data);
base = pdata->base;
for (addr = 0; addr < ARRAY_SIZE(pdata->chip); addr++) { for (addr = 0; addr < ARRAY_SIZE(pdata->chip); addr++) {
if (!pdata->chip[addr].is_present) if (!(spi_present_mask & (1 << addr)))
continue; continue;
chips--; chips--;
data->mcp[addr] = &data->chip[chips]; data->mcp[addr] = &data->chip[chips];
status = mcp23s08_probe_one(data->mcp[addr], &spi->dev, spi, status = mcp23s08_probe_one(data->mcp[addr], &spi->dev, spi,
0x40 | (addr << 1), type, base, 0x40 | (addr << 1), type, base,
pdata->chip[addr].pullups); pullups[addr]);
if (status < 0) if (status < 0)
goto fail; goto fail;
if (base != -1)
base += (type == MCP_TYPE_S17) ? 16 : 8; base += (type == MCP_TYPE_S17) ? 16 : 8;
ngpio += (type == MCP_TYPE_S17) ? 16 : 8;
} }
data->ngpio = base - pdata->base; data->ngpio = ngpio;
/* NOTE: these chips have a relatively sane IRQ framework, with /* NOTE: these chips have a relatively sane IRQ framework, with
* per-signal masking and level/edge triggering. It's not yet * per-signal masking and level/edge triggering. It's not yet
...@@ -668,6 +742,7 @@ static struct spi_driver mcp23s08_driver = { ...@@ -668,6 +742,7 @@ static struct spi_driver mcp23s08_driver = {
.driver = { .driver = {
.name = "mcp23s08", .name = "mcp23s08",
.owner = THIS_MODULE, .owner = THIS_MODULE,
.of_match_table = of_match_ptr(mcp23s08_spi_of_match),
}, },
}; };
......
...@@ -117,7 +117,7 @@ static inline void __iomem *mvebu_gpioreg_edge_cause(struct mvebu_gpio_chip *mvc ...@@ -117,7 +117,7 @@ static inline void __iomem *mvebu_gpioreg_edge_cause(struct mvebu_gpio_chip *mvc
{ {
int cpu; int cpu;
switch(mvchip->soc_variant) { switch (mvchip->soc_variant) {
case MVEBU_GPIO_SOC_VARIANT_ORION: case MVEBU_GPIO_SOC_VARIANT_ORION:
case MVEBU_GPIO_SOC_VARIANT_MV78200: case MVEBU_GPIO_SOC_VARIANT_MV78200:
return mvchip->membase + GPIO_EDGE_CAUSE_OFF; return mvchip->membase + GPIO_EDGE_CAUSE_OFF;
...@@ -133,7 +133,7 @@ static inline void __iomem *mvebu_gpioreg_edge_mask(struct mvebu_gpio_chip *mvch ...@@ -133,7 +133,7 @@ static inline void __iomem *mvebu_gpioreg_edge_mask(struct mvebu_gpio_chip *mvch
{ {
int cpu; int cpu;
switch(mvchip->soc_variant) { switch (mvchip->soc_variant) {
case MVEBU_GPIO_SOC_VARIANT_ORION: case MVEBU_GPIO_SOC_VARIANT_ORION:
return mvchip->membase + GPIO_EDGE_MASK_OFF; return mvchip->membase + GPIO_EDGE_MASK_OFF;
case MVEBU_GPIO_SOC_VARIANT_MV78200: case MVEBU_GPIO_SOC_VARIANT_MV78200:
...@@ -151,7 +151,7 @@ static void __iomem *mvebu_gpioreg_level_mask(struct mvebu_gpio_chip *mvchip) ...@@ -151,7 +151,7 @@ static void __iomem *mvebu_gpioreg_level_mask(struct mvebu_gpio_chip *mvchip)
{ {
int cpu; int cpu;
switch(mvchip->soc_variant) { switch (mvchip->soc_variant) {
case MVEBU_GPIO_SOC_VARIANT_ORION: case MVEBU_GPIO_SOC_VARIANT_ORION:
return mvchip->membase + GPIO_LEVEL_MASK_OFF; return mvchip->membase + GPIO_LEVEL_MASK_OFF;
case MVEBU_GPIO_SOC_VARIANT_MV78200: case MVEBU_GPIO_SOC_VARIANT_MV78200:
...@@ -401,7 +401,7 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type) ...@@ -401,7 +401,7 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
/* /*
* Configure interrupt polarity. * Configure interrupt polarity.
*/ */
switch(type) { switch (type) {
case IRQ_TYPE_EDGE_RISING: case IRQ_TYPE_EDGE_RISING:
case IRQ_TYPE_LEVEL_HIGH: case IRQ_TYPE_LEVEL_HIGH:
u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip)); u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
...@@ -470,18 +470,76 @@ static void mvebu_gpio_irq_handler(unsigned int irq, struct irq_desc *desc) ...@@ -470,18 +470,76 @@ static void mvebu_gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
} }
} }
#ifdef CONFIG_DEBUG_FS
#include <linux/seq_file.h>
static void mvebu_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
{
struct mvebu_gpio_chip *mvchip =
container_of(chip, struct mvebu_gpio_chip, chip);
u32 out, io_conf, blink, in_pol, data_in, cause, edg_msk, lvl_msk;
int i;
out = readl_relaxed(mvebu_gpioreg_out(mvchip));
io_conf = readl_relaxed(mvebu_gpioreg_io_conf(mvchip));
blink = readl_relaxed(mvebu_gpioreg_blink(mvchip));
in_pol = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
data_in = readl_relaxed(mvebu_gpioreg_data_in(mvchip));
cause = readl_relaxed(mvebu_gpioreg_edge_cause(mvchip));
edg_msk = readl_relaxed(mvebu_gpioreg_edge_mask(mvchip));
lvl_msk = readl_relaxed(mvebu_gpioreg_level_mask(mvchip));
for (i = 0; i < chip->ngpio; i++) {
const char *label;
u32 msk;
bool is_out;
label = gpiochip_is_requested(chip, i);
if (!label)
continue;
msk = 1 << i;
is_out = !(io_conf & msk);
seq_printf(s, " gpio-%-3d (%-20.20s)", chip->base + i, label);
if (is_out) {
seq_printf(s, " out %s %s\n",
out & msk ? "hi" : "lo",
blink & msk ? "(blink )" : "");
continue;
}
seq_printf(s, " in %s (act %s) - IRQ",
(data_in ^ in_pol) & msk ? "hi" : "lo",
in_pol & msk ? "lo" : "hi");
if (!((edg_msk | lvl_msk) & msk)) {
seq_printf(s, " disabled\n");
continue;
}
if (edg_msk & msk)
seq_printf(s, " edge ");
if (lvl_msk & msk)
seq_printf(s, " level");
seq_printf(s, " (%s)\n", cause & msk ? "pending" : "clear ");
}
}
#else
#define mvebu_gpio_dbg_show NULL
#endif
static struct of_device_id mvebu_gpio_of_match[] = { static struct of_device_id mvebu_gpio_of_match[] = {
{ {
.compatible = "marvell,orion-gpio", .compatible = "marvell,orion-gpio",
.data = (void*) MVEBU_GPIO_SOC_VARIANT_ORION, .data = (void *) MVEBU_GPIO_SOC_VARIANT_ORION,
}, },
{ {
.compatible = "marvell,mv78200-gpio", .compatible = "marvell,mv78200-gpio",
.data = (void*) MVEBU_GPIO_SOC_VARIANT_MV78200, .data = (void *) MVEBU_GPIO_SOC_VARIANT_MV78200,
}, },
{ {
.compatible = "marvell,armadaxp-gpio", .compatible = "marvell,armadaxp-gpio",
.data = (void*) MVEBU_GPIO_SOC_VARIANT_ARMADAXP, .data = (void *) MVEBU_GPIO_SOC_VARIANT_ARMADAXP,
}, },
{ {
/* sentinel */ /* sentinel */
...@@ -509,13 +567,13 @@ static int mvebu_gpio_probe(struct platform_device *pdev) ...@@ -509,13 +567,13 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
soc_variant = MVEBU_GPIO_SOC_VARIANT_ORION; soc_variant = MVEBU_GPIO_SOC_VARIANT_ORION;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (! res) { if (!res) {
dev_err(&pdev->dev, "Cannot get memory resource\n"); dev_err(&pdev->dev, "Cannot get memory resource\n");
return -ENODEV; return -ENODEV;
} }
mvchip = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_gpio_chip), GFP_KERNEL); mvchip = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_gpio_chip), GFP_KERNEL);
if (! mvchip){ if (!mvchip) {
dev_err(&pdev->dev, "Cannot allocate memory\n"); dev_err(&pdev->dev, "Cannot allocate memory\n");
return -ENOMEM; return -ENOMEM;
} }
...@@ -550,6 +608,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) ...@@ -550,6 +608,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
mvchip->chip.ngpio = ngpios; mvchip->chip.ngpio = ngpios;
mvchip->chip.can_sleep = 0; mvchip->chip.can_sleep = 0;
mvchip->chip.of_node = np; mvchip->chip.of_node = np;
mvchip->chip.dbg_show = mvebu_gpio_dbg_show;
spin_lock_init(&mvchip->lock); spin_lock_init(&mvchip->lock);
mvchip->membase = devm_ioremap_resource(&pdev->dev, res); mvchip->membase = devm_ioremap_resource(&pdev->dev, res);
...@@ -560,7 +619,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) ...@@ -560,7 +619,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
* per-CPU registers */ * per-CPU registers */
if (soc_variant == MVEBU_GPIO_SOC_VARIANT_ARMADAXP) { if (soc_variant == MVEBU_GPIO_SOC_VARIANT_ARMADAXP) {
res = platform_get_resource(pdev, IORESOURCE_MEM, 1); res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
if (! res) { if (!res) {
dev_err(&pdev->dev, "Cannot get memory resource\n"); dev_err(&pdev->dev, "Cannot get memory resource\n");
return -ENODEV; return -ENODEV;
} }
...@@ -574,7 +633,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) ...@@ -574,7 +633,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
/* /*
* Mask and clear GPIO interrupts. * Mask and clear GPIO interrupts.
*/ */
switch(soc_variant) { switch (soc_variant) {
case MVEBU_GPIO_SOC_VARIANT_ORION: case MVEBU_GPIO_SOC_VARIANT_ORION:
writel_relaxed(0, mvchip->membase + GPIO_EDGE_CAUSE_OFF); writel_relaxed(0, mvchip->membase + GPIO_EDGE_CAUSE_OFF);
writel_relaxed(0, mvchip->membase + GPIO_EDGE_MASK_OFF); writel_relaxed(0, mvchip->membase + GPIO_EDGE_MASK_OFF);
...@@ -632,7 +691,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) ...@@ -632,7 +691,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
gc = irq_alloc_generic_chip("mvebu_gpio_irq", 2, mvchip->irqbase, gc = irq_alloc_generic_chip("mvebu_gpio_irq", 2, mvchip->irqbase,
mvchip->membase, handle_level_irq); mvchip->membase, handle_level_irq);
if (! gc) { if (!gc) {
dev_err(&pdev->dev, "Cannot allocate generic irq_chip\n"); dev_err(&pdev->dev, "Cannot allocate generic irq_chip\n");
return -ENOMEM; return -ENOMEM;
} }
......
...@@ -52,7 +52,6 @@ struct gpio_bank { ...@@ -52,7 +52,6 @@ struct gpio_bank {
struct list_head node; struct list_head node;
void __iomem *base; void __iomem *base;
u16 irq; u16 irq;
int irq_base;
struct irq_domain *domain; struct irq_domain *domain;
u32 non_wakeup_gpios; u32 non_wakeup_gpios;
u32 enabled_non_wakeup_gpios; u32 enabled_non_wakeup_gpios;
...@@ -88,7 +87,14 @@ struct gpio_bank { ...@@ -88,7 +87,14 @@ struct gpio_bank {
static int irq_to_gpio(struct gpio_bank *bank, unsigned int gpio_irq) static int irq_to_gpio(struct gpio_bank *bank, unsigned int gpio_irq)
{ {
return gpio_irq - bank->irq_base + bank->chip.base; return bank->chip.base + gpio_irq;
}
static int omap_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
{
struct gpio_bank *bank = container_of(chip, struct gpio_bank, chip);
return irq_find_mapping(bank->domain, offset);
} }
static void _set_gpio_direction(struct gpio_bank *bank, int gpio, int is_input) static void _set_gpio_direction(struct gpio_bank *bank, int gpio, int is_input)
...@@ -420,13 +426,16 @@ static int gpio_irq_type(struct irq_data *d, unsigned type) ...@@ -420,13 +426,16 @@ static int gpio_irq_type(struct irq_data *d, unsigned type)
int retval; int retval;
unsigned long flags; unsigned long flags;
if (WARN_ON(!bank->mod_usage))
return -EINVAL;
#ifdef CONFIG_ARCH_OMAP1 #ifdef CONFIG_ARCH_OMAP1
if (d->irq > IH_MPUIO_BASE) if (d->irq > IH_MPUIO_BASE)
gpio = OMAP_MPUIO(d->irq - IH_MPUIO_BASE); gpio = OMAP_MPUIO(d->irq - IH_MPUIO_BASE);
#endif #endif
if (!gpio) if (!gpio)
gpio = irq_to_gpio(bank, d->irq); gpio = irq_to_gpio(bank, d->hwirq);
if (type & ~IRQ_TYPE_SENSE_MASK) if (type & ~IRQ_TYPE_SENSE_MASK)
return -EINVAL; return -EINVAL;
...@@ -579,7 +588,7 @@ static void _reset_gpio(struct gpio_bank *bank, int gpio) ...@@ -579,7 +588,7 @@ static void _reset_gpio(struct gpio_bank *bank, int gpio)
static int gpio_wake_enable(struct irq_data *d, unsigned int enable) static int gpio_wake_enable(struct irq_data *d, unsigned int enable)
{ {
struct gpio_bank *bank = irq_data_get_irq_chip_data(d); struct gpio_bank *bank = irq_data_get_irq_chip_data(d);
unsigned int gpio = irq_to_gpio(bank, d->irq); unsigned int gpio = irq_to_gpio(bank, d->hwirq);
return _set_gpio_wakeup(bank, gpio, enable); return _set_gpio_wakeup(bank, gpio, enable);
} }
...@@ -679,7 +688,7 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) ...@@ -679,7 +688,7 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
{ {
void __iomem *isr_reg = NULL; void __iomem *isr_reg = NULL;
u32 isr; u32 isr;
unsigned int gpio_irq, gpio_index; unsigned int bit;
struct gpio_bank *bank; struct gpio_bank *bank;
int unmasked = 0; int unmasked = 0;
struct irq_chip *chip = irq_desc_get_chip(desc); struct irq_chip *chip = irq_desc_get_chip(desc);
...@@ -693,7 +702,7 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) ...@@ -693,7 +702,7 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
if (WARN_ON(!isr_reg)) if (WARN_ON(!isr_reg))
goto exit; goto exit;
while(1) { while (1) {
u32 isr_saved, level_mask = 0; u32 isr_saved, level_mask = 0;
u32 enabled; u32 enabled;
...@@ -720,14 +729,9 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) ...@@ -720,14 +729,9 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
if (!isr) if (!isr)
break; break;
gpio_irq = bank->irq_base; while (isr) {
for (; isr != 0; isr >>= 1, gpio_irq++) { bit = __ffs(isr);
int gpio = irq_to_gpio(bank, gpio_irq); isr &= ~(1 << bit);
if (!(isr & 1))
continue;
gpio_index = GPIO_INDEX(bank, gpio);
/* /*
* Some chips can't respond to both rising and falling * Some chips can't respond to both rising and falling
...@@ -736,10 +740,10 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) ...@@ -736,10 +740,10 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
* to respond to the IRQ for the opposite direction. * to respond to the IRQ for the opposite direction.
* This will be indicated in the bank toggle_mask. * This will be indicated in the bank toggle_mask.
*/ */
if (bank->toggle_mask & (1 << gpio_index)) if (bank->toggle_mask & (1 << bit))
_toggle_gpio_edge_triggering(bank, gpio_index); _toggle_gpio_edge_triggering(bank, bit);
generic_handle_irq(gpio_irq); generic_handle_irq(irq_find_mapping(bank->domain, bit));
} }
} }
/* if bank has any level sensitive GPIO pin interrupt /* if bank has any level sensitive GPIO pin interrupt
...@@ -755,7 +759,7 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) ...@@ -755,7 +759,7 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
static void gpio_irq_shutdown(struct irq_data *d) static void gpio_irq_shutdown(struct irq_data *d)
{ {
struct gpio_bank *bank = irq_data_get_irq_chip_data(d); struct gpio_bank *bank = irq_data_get_irq_chip_data(d);
unsigned int gpio = irq_to_gpio(bank, d->irq); unsigned int gpio = irq_to_gpio(bank, d->hwirq);
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&bank->lock, flags); spin_lock_irqsave(&bank->lock, flags);
...@@ -766,7 +770,7 @@ static void gpio_irq_shutdown(struct irq_data *d) ...@@ -766,7 +770,7 @@ static void gpio_irq_shutdown(struct irq_data *d)
static void gpio_ack_irq(struct irq_data *d) static void gpio_ack_irq(struct irq_data *d)
{ {
struct gpio_bank *bank = irq_data_get_irq_chip_data(d); struct gpio_bank *bank = irq_data_get_irq_chip_data(d);
unsigned int gpio = irq_to_gpio(bank, d->irq); unsigned int gpio = irq_to_gpio(bank, d->hwirq);
_clear_gpio_irqstatus(bank, gpio); _clear_gpio_irqstatus(bank, gpio);
} }
...@@ -774,7 +778,7 @@ static void gpio_ack_irq(struct irq_data *d) ...@@ -774,7 +778,7 @@ static void gpio_ack_irq(struct irq_data *d)
static void gpio_mask_irq(struct irq_data *d) static void gpio_mask_irq(struct irq_data *d)
{ {
struct gpio_bank *bank = irq_data_get_irq_chip_data(d); struct gpio_bank *bank = irq_data_get_irq_chip_data(d);
unsigned int gpio = irq_to_gpio(bank, d->irq); unsigned int gpio = irq_to_gpio(bank, d->hwirq);
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&bank->lock, flags); spin_lock_irqsave(&bank->lock, flags);
...@@ -786,7 +790,7 @@ static void gpio_mask_irq(struct irq_data *d) ...@@ -786,7 +790,7 @@ static void gpio_mask_irq(struct irq_data *d)
static void gpio_unmask_irq(struct irq_data *d) static void gpio_unmask_irq(struct irq_data *d)
{ {
struct gpio_bank *bank = irq_data_get_irq_chip_data(d); struct gpio_bank *bank = irq_data_get_irq_chip_data(d);
unsigned int gpio = irq_to_gpio(bank, d->irq); unsigned int gpio = irq_to_gpio(bank, d->hwirq);
unsigned int irq_mask = GPIO_BIT(bank, gpio); unsigned int irq_mask = GPIO_BIT(bank, gpio);
u32 trigger = irqd_get_trigger_type(d); u32 trigger = irqd_get_trigger_type(d);
unsigned long flags; unsigned long flags;
...@@ -952,14 +956,6 @@ static void gpio_set(struct gpio_chip *chip, unsigned offset, int value) ...@@ -952,14 +956,6 @@ static void gpio_set(struct gpio_chip *chip, unsigned offset, int value)
spin_unlock_irqrestore(&bank->lock, flags); spin_unlock_irqrestore(&bank->lock, flags);
} }
static int gpio_2irq(struct gpio_chip *chip, unsigned offset)
{
struct gpio_bank *bank;
bank = container_of(chip, struct gpio_bank, chip);
return bank->irq_base + offset;
}
/*---------------------------------------------------------------------*/ /*---------------------------------------------------------------------*/
static void __init omap_gpio_show_rev(struct gpio_bank *bank) static void __init omap_gpio_show_rev(struct gpio_bank *bank)
...@@ -1056,7 +1052,7 @@ static void omap_gpio_chip_init(struct gpio_bank *bank) ...@@ -1056,7 +1052,7 @@ static void omap_gpio_chip_init(struct gpio_bank *bank)
bank->chip.direction_output = gpio_output; bank->chip.direction_output = gpio_output;
bank->chip.set_debounce = gpio_debounce; bank->chip.set_debounce = gpio_debounce;
bank->chip.set = gpio_set; bank->chip.set = gpio_set;
bank->chip.to_irq = gpio_2irq; bank->chip.to_irq = omap_gpio_to_irq;
if (bank->is_mpuio) { if (bank->is_mpuio) {
bank->chip.label = "mpuio"; bank->chip.label = "mpuio";
if (bank->regs->wkup_en) if (bank->regs->wkup_en)
...@@ -1071,15 +1067,16 @@ static void omap_gpio_chip_init(struct gpio_bank *bank) ...@@ -1071,15 +1067,16 @@ static void omap_gpio_chip_init(struct gpio_bank *bank)
gpiochip_add(&bank->chip); gpiochip_add(&bank->chip);
for (j = bank->irq_base; j < bank->irq_base + bank->width; j++) { for (j = 0; j < bank->width; j++) {
irq_set_lockdep_class(j, &gpio_lock_class); int irq = irq_create_mapping(bank->domain, j);
irq_set_chip_data(j, bank); irq_set_lockdep_class(irq, &gpio_lock_class);
irq_set_chip_data(irq, bank);
if (bank->is_mpuio) { if (bank->is_mpuio) {
omap_mpuio_alloc_gc(bank, j, bank->width); omap_mpuio_alloc_gc(bank, irq, bank->width);
} else { } else {
irq_set_chip(j, &gpio_irq_chip); irq_set_chip_and_handler(irq, &gpio_irq_chip,
irq_set_handler(j, handle_simple_irq); handle_simple_irq);
set_irq_flags(j, IRQF_VALID); set_irq_flags(irq, IRQF_VALID);
} }
} }
irq_set_chained_handler(bank->irq, gpio_irq_handler); irq_set_chained_handler(bank->irq, gpio_irq_handler);
...@@ -1096,7 +1093,6 @@ static int omap_gpio_probe(struct platform_device *pdev) ...@@ -1096,7 +1093,6 @@ static int omap_gpio_probe(struct platform_device *pdev)
const struct omap_gpio_platform_data *pdata; const struct omap_gpio_platform_data *pdata;
struct resource *res; struct resource *res;
struct gpio_bank *bank; struct gpio_bank *bank;
int ret = 0;
match = of_match_device(of_match_ptr(omap_gpio_match), dev); match = of_match_device(of_match_ptr(omap_gpio_match), dev);
...@@ -1123,20 +1119,22 @@ static int omap_gpio_probe(struct platform_device *pdev) ...@@ -1123,20 +1119,22 @@ static int omap_gpio_probe(struct platform_device *pdev)
bank->width = pdata->bank_width; bank->width = pdata->bank_width;
bank->is_mpuio = pdata->is_mpuio; bank->is_mpuio = pdata->is_mpuio;
bank->non_wakeup_gpios = pdata->non_wakeup_gpios; bank->non_wakeup_gpios = pdata->non_wakeup_gpios;
bank->loses_context = pdata->loses_context;
bank->regs = pdata->regs; bank->regs = pdata->regs;
#ifdef CONFIG_OF_GPIO #ifdef CONFIG_OF_GPIO
bank->chip.of_node = of_node_get(node); bank->chip.of_node = of_node_get(node);
#endif #endif
if (node) {
bank->irq_base = irq_alloc_descs(-1, 0, bank->width, 0); if (!of_property_read_bool(node, "ti,gpio-always-on"))
if (bank->irq_base < 0) { bank->loses_context = true;
dev_err(dev, "Couldn't allocate IRQ numbers\n"); } else {
return -ENODEV; bank->loses_context = pdata->loses_context;
} }
bank->domain = irq_domain_add_legacy(node, bank->width, bank->irq_base,
0, &irq_domain_simple_ops, NULL); bank->domain = irq_domain_add_linear(node, bank->width,
&irq_domain_simple_ops, NULL);
if (!bank->domain)
return -ENODEV;
if (bank->regs->set_dataout && bank->regs->clr_dataout) if (bank->regs->set_dataout && bank->regs->clr_dataout)
bank->set_dataout = _set_gpio_dataout_reg; bank->set_dataout = _set_gpio_dataout_reg;
...@@ -1149,18 +1147,21 @@ static int omap_gpio_probe(struct platform_device *pdev) ...@@ -1149,18 +1147,21 @@ static int omap_gpio_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (unlikely(!res)) { if (unlikely(!res)) {
dev_err(dev, "Invalid mem resource\n"); dev_err(dev, "Invalid mem resource\n");
irq_domain_remove(bank->domain);
return -ENODEV; return -ENODEV;
} }
if (!devm_request_mem_region(dev, res->start, resource_size(res), if (!devm_request_mem_region(dev, res->start, resource_size(res),
pdev->name)) { pdev->name)) {
dev_err(dev, "Region already claimed\n"); dev_err(dev, "Region already claimed\n");
irq_domain_remove(bank->domain);
return -EBUSY; return -EBUSY;
} }
bank->base = devm_ioremap(dev, res->start, resource_size(res)); bank->base = devm_ioremap(dev, res->start, resource_size(res));
if (!bank->base) { if (!bank->base) {
dev_err(dev, "Could not ioremap\n"); dev_err(dev, "Could not ioremap\n");
irq_domain_remove(bank->domain);
return -ENOMEM; return -ENOMEM;
} }
...@@ -1184,7 +1185,7 @@ static int omap_gpio_probe(struct platform_device *pdev) ...@@ -1184,7 +1185,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
list_add_tail(&bank->node, &omap_gpio_list); list_add_tail(&bank->node, &omap_gpio_list);
return ret; return 0;
} }
#ifdef CONFIG_ARCH_OMAP2PLUS #ifdef CONFIG_ARCH_OMAP2PLUS
...@@ -1262,9 +1263,9 @@ static int omap_gpio_runtime_resume(struct device *dev) ...@@ -1262,9 +1263,9 @@ static int omap_gpio_runtime_resume(struct device *dev)
{ {
struct platform_device *pdev = to_platform_device(dev); struct platform_device *pdev = to_platform_device(dev);
struct gpio_bank *bank = platform_get_drvdata(pdev); struct gpio_bank *bank = platform_get_drvdata(pdev);
int context_lost_cnt_after;
u32 l = 0, gen, gen0, gen1; u32 l = 0, gen, gen0, gen1;
unsigned long flags; unsigned long flags;
int c;
spin_lock_irqsave(&bank->lock, flags); spin_lock_irqsave(&bank->lock, flags);
_gpio_dbck_enable(bank); _gpio_dbck_enable(bank);
...@@ -1280,26 +1281,25 @@ static int omap_gpio_runtime_resume(struct device *dev) ...@@ -1280,26 +1281,25 @@ static int omap_gpio_runtime_resume(struct device *dev)
__raw_writel(bank->context.risingdetect, __raw_writel(bank->context.risingdetect,
bank->base + bank->regs->risingdetect); bank->base + bank->regs->risingdetect);
if (bank->get_context_loss_count) { if (bank->loses_context) {
context_lost_cnt_after = if (!bank->get_context_loss_count) {
bank->get_context_loss_count(bank->dev); omap_gpio_restore_context(bank);
if (context_lost_cnt_after != bank->context_loss_count) { } else {
c = bank->get_context_loss_count(bank->dev);
if (c != bank->context_loss_count) {
omap_gpio_restore_context(bank); omap_gpio_restore_context(bank);
} else { } else {
spin_unlock_irqrestore(&bank->lock, flags); spin_unlock_irqrestore(&bank->lock, flags);
return 0; return 0;
} }
} }
}
if (!bank->workaround_enabled) { if (!bank->workaround_enabled) {
spin_unlock_irqrestore(&bank->lock, flags); spin_unlock_irqrestore(&bank->lock, flags);
return 0; return 0;
} }
__raw_writel(bank->context.fallingdetect,
bank->base + bank->regs->fallingdetect);
__raw_writel(bank->context.risingdetect,
bank->base + bank->regs->risingdetect);
l = __raw_readl(bank->base + bank->regs->datain); l = __raw_readl(bank->base + bank->regs->datain);
/* /*
......
...@@ -146,8 +146,7 @@ static int pca953x_write_regs(struct pca953x_chip *chip, int reg, u8 *val) ...@@ -146,8 +146,7 @@ static int pca953x_write_regs(struct pca953x_chip *chip, int reg, u8 *val)
ret = i2c_smbus_write_i2c_block_data(chip->client, ret = i2c_smbus_write_i2c_block_data(chip->client,
(reg << bank_shift) | REG_ADDR_AI, (reg << bank_shift) | REG_ADDR_AI,
NBANK(chip), val); NBANK(chip), val);
} } else {
else {
switch (chip->chip_type) { switch (chip->chip_type) {
case PCA953X_TYPE: case PCA953X_TYPE:
ret = i2c_smbus_write_word_data(chip->client, ret = i2c_smbus_write_word_data(chip->client,
......
...@@ -45,6 +45,7 @@ static const struct i2c_device_id pcf857x_id[] = { ...@@ -45,6 +45,7 @@ static const struct i2c_device_id pcf857x_id[] = {
{ "pca9675", 16 }, { "pca9675", 16 },
{ "max7328", 8 }, { "max7328", 8 },
{ "max7329", 8 }, { "max7329", 8 },
{ "tca9554", 8 },
{ } { }
}; };
MODULE_DEVICE_TABLE(i2c, pcf857x_id); MODULE_DEVICE_TABLE(i2c, pcf857x_id);
...@@ -267,7 +268,7 @@ static int pcf857x_probe(struct i2c_client *client, ...@@ -267,7 +268,7 @@ static int pcf857x_probe(struct i2c_client *client,
} }
/* Allocate, initialize, and register this gpio_chip. */ /* Allocate, initialize, and register this gpio_chip. */
gpio = kzalloc(sizeof *gpio, GFP_KERNEL); gpio = devm_kzalloc(&client->dev, sizeof(*gpio), GFP_KERNEL);
if (!gpio) if (!gpio)
return -ENOMEM; return -ENOMEM;
...@@ -390,7 +391,6 @@ static int pcf857x_probe(struct i2c_client *client, ...@@ -390,7 +391,6 @@ static int pcf857x_probe(struct i2c_client *client,
if (pdata && client->irq) if (pdata && client->irq)
pcf857x_irq_domain_cleanup(gpio); pcf857x_irq_domain_cleanup(gpio);
kfree(gpio);
return status; return status;
} }
...@@ -415,9 +415,7 @@ static int pcf857x_remove(struct i2c_client *client) ...@@ -415,9 +415,7 @@ static int pcf857x_remove(struct i2c_client *client)
pcf857x_irq_domain_cleanup(gpio); pcf857x_irq_domain_cleanup(gpio);
status = gpiochip_remove(&gpio->chip); status = gpiochip_remove(&gpio->chip);
if (status == 0) if (status)
kfree(gpio);
else
dev_err(&client->dev, "%s --> %d\n", "remove", status); dev_err(&client->dev, "%s --> %d\n", "remove", status);
return status; return status;
} }
......
...@@ -628,7 +628,7 @@ static int pxa_gpio_probe(struct platform_device *pdev) ...@@ -628,7 +628,7 @@ static int pxa_gpio_probe(struct platform_device *pdev)
for_each_gpio_chip(gpio, c) { for_each_gpio_chip(gpio, c) {
writel_relaxed(0, c->regbase + GFER_OFFSET); writel_relaxed(0, c->regbase + GFER_OFFSET);
writel_relaxed(0, c->regbase + GRER_OFFSET); writel_relaxed(0, c->regbase + GRER_OFFSET);
writel_relaxed(~0,c->regbase + GEDR_OFFSET); writel_relaxed(~0, c->regbase + GEDR_OFFSET);
/* unmask GPIO edge detect for AP side */ /* unmask GPIO edge detect for AP side */
if (gpio_is_mmp_type(gpio_type)) if (gpio_is_mmp_type(gpio_type))
writel_relaxed(~0, c->regbase + ED_MASK_OFFSET); writel_relaxed(~0, c->regbase + ED_MASK_OFFSET);
...@@ -712,7 +712,7 @@ static void pxa_gpio_resume(void) ...@@ -712,7 +712,7 @@ static void pxa_gpio_resume(void)
for_each_gpio_chip(gpio, c) { for_each_gpio_chip(gpio, c) {
/* restore level with set/clear */ /* restore level with set/clear */
writel_relaxed( c->saved_gplr, c->regbase + GPSR_OFFSET); writel_relaxed(c->saved_gplr, c->regbase + GPSR_OFFSET);
writel_relaxed(~c->saved_gplr, c->regbase + GPCR_OFFSET); writel_relaxed(~c->saved_gplr, c->regbase + GPCR_OFFSET);
writel_relaxed(c->saved_grer, c->regbase + GRER_OFFSET); writel_relaxed(c->saved_grer, c->regbase + GRER_OFFSET);
......
...@@ -3030,6 +3030,7 @@ static __init int samsung_gpiolib_init(void) ...@@ -3030,6 +3030,7 @@ static __init int samsung_gpiolib_init(void)
{ .compatible = "samsung,exynos4x12-pinctrl", }, { .compatible = "samsung,exynos4x12-pinctrl", },
{ .compatible = "samsung,exynos5250-pinctrl", }, { .compatible = "samsung,exynos5250-pinctrl", },
{ .compatible = "samsung,exynos5440-pinctrl", }, { .compatible = "samsung,exynos5440-pinctrl", },
{ }
}; };
for_each_matching_node(pctrl_np, exynos_pinctrl_ids) for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
if (pctrl_np && of_device_is_available(pctrl_np)) if (pctrl_np && of_device_is_available(pctrl_np))
......
...@@ -125,13 +125,17 @@ static int sch_gpio_resume_direction_in(struct gpio_chip *gc, ...@@ -125,13 +125,17 @@ static int sch_gpio_resume_direction_in(struct gpio_chip *gc,
unsigned gpio_num) unsigned gpio_num)
{ {
u8 curr_dirs; u8 curr_dirs;
unsigned short offset, bit;
spin_lock(&gpio_lock); spin_lock(&gpio_lock);
curr_dirs = inb(gpio_ba + RGIO); offset = RGIO + gpio_num / 8;
bit = gpio_num % 8;
if (!(curr_dirs & (1 << gpio_num))) curr_dirs = inb(gpio_ba + offset);
outb(curr_dirs | (1 << gpio_num) , gpio_ba + RGIO);
if (!(curr_dirs & (1 << bit)))
outb(curr_dirs | (1 << bit), gpio_ba + offset);
spin_unlock(&gpio_lock); spin_unlock(&gpio_lock);
return 0; return 0;
...@@ -139,22 +143,31 @@ static int sch_gpio_resume_direction_in(struct gpio_chip *gc, ...@@ -139,22 +143,31 @@ static int sch_gpio_resume_direction_in(struct gpio_chip *gc,
static int sch_gpio_resume_get(struct gpio_chip *gc, unsigned gpio_num) static int sch_gpio_resume_get(struct gpio_chip *gc, unsigned gpio_num)
{ {
return !!(inb(gpio_ba + RGLV) & (1 << gpio_num)); unsigned short offset, bit;
offset = RGLV + gpio_num / 8;
bit = gpio_num % 8;
return !!(inb(gpio_ba + offset) & (1 << bit));
} }
static void sch_gpio_resume_set(struct gpio_chip *gc, static void sch_gpio_resume_set(struct gpio_chip *gc,
unsigned gpio_num, int val) unsigned gpio_num, int val)
{ {
u8 curr_vals; u8 curr_vals;
unsigned short offset, bit;
spin_lock(&gpio_lock); spin_lock(&gpio_lock);
curr_vals = inb(gpio_ba + RGLV); offset = RGLV + gpio_num / 8;
bit = gpio_num % 8;
curr_vals = inb(gpio_ba + offset);
if (val) if (val)
outb(curr_vals | (1 << gpio_num), gpio_ba + RGLV); outb(curr_vals | (1 << bit), gpio_ba + offset);
else else
outb((curr_vals & ~(1 << gpio_num)), gpio_ba + RGLV); outb((curr_vals & ~(1 << bit)), gpio_ba + offset);
spin_unlock(&gpio_lock); spin_unlock(&gpio_lock);
} }
...@@ -163,14 +176,18 @@ static int sch_gpio_resume_direction_out(struct gpio_chip *gc, ...@@ -163,14 +176,18 @@ static int sch_gpio_resume_direction_out(struct gpio_chip *gc,
unsigned gpio_num, int val) unsigned gpio_num, int val)
{ {
u8 curr_dirs; u8 curr_dirs;
unsigned short offset, bit;
sch_gpio_resume_set(gc, gpio_num, val); sch_gpio_resume_set(gc, gpio_num, val);
offset = RGIO + gpio_num / 8;
bit = gpio_num % 8;
spin_lock(&gpio_lock); spin_lock(&gpio_lock);
curr_dirs = inb(gpio_ba + RGIO); curr_dirs = inb(gpio_ba + offset);
if (curr_dirs & (1 << gpio_num)) if (curr_dirs & (1 << bit))
outb(curr_dirs & ~(1 << gpio_num), gpio_ba + RGIO); outb(curr_dirs & ~(1 << bit), gpio_ba + offset);
spin_unlock(&gpio_lock); spin_unlock(&gpio_lock);
return 0; return 0;
...@@ -207,10 +224,8 @@ static int sch_gpio_probe(struct platform_device *pdev) ...@@ -207,10 +224,8 @@ static int sch_gpio_probe(struct platform_device *pdev)
case PCI_DEVICE_ID_INTEL_SCH_LPC: case PCI_DEVICE_ID_INTEL_SCH_LPC:
sch_gpio_core.base = 0; sch_gpio_core.base = 0;
sch_gpio_core.ngpio = 10; sch_gpio_core.ngpio = 10;
sch_gpio_resume.base = 10; sch_gpio_resume.base = 10;
sch_gpio_resume.ngpio = 4; sch_gpio_resume.ngpio = 4;
/* /*
* GPIO[6:0] enabled by default * GPIO[6:0] enabled by default
* GPIO7 is configured by the CMC as SLPIOVR * GPIO7 is configured by the CMC as SLPIOVR
...@@ -227,7 +242,6 @@ static int sch_gpio_probe(struct platform_device *pdev) ...@@ -227,7 +242,6 @@ static int sch_gpio_probe(struct platform_device *pdev)
case PCI_DEVICE_ID_INTEL_ITC_LPC: case PCI_DEVICE_ID_INTEL_ITC_LPC:
sch_gpio_core.base = 0; sch_gpio_core.base = 0;
sch_gpio_core.ngpio = 5; sch_gpio_core.ngpio = 5;
sch_gpio_resume.base = 5; sch_gpio_resume.base = 5;
sch_gpio_resume.ngpio = 9; sch_gpio_resume.ngpio = 9;
break; break;
...@@ -235,7 +249,6 @@ static int sch_gpio_probe(struct platform_device *pdev) ...@@ -235,7 +249,6 @@ static int sch_gpio_probe(struct platform_device *pdev)
case PCI_DEVICE_ID_INTEL_CENTERTON_ILB: case PCI_DEVICE_ID_INTEL_CENTERTON_ILB:
sch_gpio_core.base = 0; sch_gpio_core.base = 0;
sch_gpio_core.ngpio = 21; sch_gpio_core.ngpio = 21;
sch_gpio_resume.base = 21; sch_gpio_resume.base = 21;
sch_gpio_resume.ngpio = 9; sch_gpio_resume.ngpio = 9;
break; break;
......
...@@ -414,10 +414,11 @@ static int tegra_gpio_probe(struct platform_device *pdev) ...@@ -414,10 +414,11 @@ static int tegra_gpio_probe(struct platform_device *pdev)
int j; int j;
match = of_match_device(tegra_gpio_of_match, &pdev->dev); match = of_match_device(tegra_gpio_of_match, &pdev->dev);
if (match) if (!match) {
dev_err(&pdev->dev, "Error: No device match found\n");
return -ENODEV;
}
config = (struct tegra_gpio_soc_config *)match->data; config = (struct tegra_gpio_soc_config *)match->data;
else
config = &tegra20_gpio_config;
tegra_gpio_bank_stride = config->bank_stride; tegra_gpio_bank_stride = config->bank_stride;
tegra_gpio_upper_offset = config->upper_offset; tegra_gpio_upper_offset = config->upper_offset;
...@@ -478,9 +479,7 @@ static int tegra_gpio_probe(struct platform_device *pdev) ...@@ -478,9 +479,7 @@ static int tegra_gpio_probe(struct platform_device *pdev)
} }
} }
#ifdef CONFIG_OF_GPIO
tegra_gpio_chip.of_node = pdev->dev.of_node; tegra_gpio_chip.of_node = pdev->dev.of_node;
#endif
gpiochip_add(&tegra_gpio_chip); gpiochip_add(&tegra_gpio_chip);
......
...@@ -167,8 +167,7 @@ static int timbgpio_irq_type(struct irq_data *d, unsigned trigger) ...@@ -167,8 +167,7 @@ static int timbgpio_irq_type(struct irq_data *d, unsigned trigger)
if (ver < 3) { if (ver < 3) {
ret = -EINVAL; ret = -EINVAL;
goto out; goto out;
} } else {
else {
flr |= 1 << offset; flr |= 1 << offset;
bflr |= 1 << offset; bflr |= 1 << offset;
} }
......
...@@ -133,7 +133,7 @@ static int tps65910_gpio_probe(struct platform_device *pdev) ...@@ -133,7 +133,7 @@ static int tps65910_gpio_probe(struct platform_device *pdev)
tps65910_gpio->gpio_chip.owner = THIS_MODULE; tps65910_gpio->gpio_chip.owner = THIS_MODULE;
tps65910_gpio->gpio_chip.label = tps65910->i2c_client->name; tps65910_gpio->gpio_chip.label = tps65910->i2c_client->name;
switch(tps65910_chip_id(tps65910)) { switch (tps65910_chip_id(tps65910)) {
case TPS65910: case TPS65910:
tps65910_gpio->gpio_chip.ngpio = TPS65910_NUM_GPIO; tps65910_gpio->gpio_chip.ngpio = TPS65910_NUM_GPIO;
break; break;
......
...@@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct gpio_chip *chip, ...@@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct gpio_chip *chip,
struct vprbrd *vb = gpio->vb; struct vprbrd *vb = gpio->vb;
gpio->gpiob_out |= (1 << offset); gpio->gpiob_out |= (1 << offset);
if (value)
gpio->gpiob_val |= (1 << offset);
else
gpio->gpiob_val &= ~(1 << offset);
mutex_lock(&vb->lock); mutex_lock(&vb->lock);
......
...@@ -17,6 +17,13 @@ ...@@ -17,6 +17,13 @@
#include <linux/acpi.h> #include <linux/acpi.h>
#include <linux/interrupt.h> #include <linux/interrupt.h>
struct acpi_gpio_evt_pin {
struct list_head node;
acpi_handle *evt_handle;
unsigned int pin;
unsigned int irq;
};
static int acpi_gpiochip_find(struct gpio_chip *gc, void *data) static int acpi_gpiochip_find(struct gpio_chip *gc, void *data)
{ {
if (!gc->dev) if (!gc->dev)
...@@ -54,7 +61,6 @@ int acpi_get_gpio(char *path, int pin) ...@@ -54,7 +61,6 @@ int acpi_get_gpio(char *path, int pin)
} }
EXPORT_SYMBOL_GPL(acpi_get_gpio); EXPORT_SYMBOL_GPL(acpi_get_gpio);
static irqreturn_t acpi_gpio_irq_handler(int irq, void *data) static irqreturn_t acpi_gpio_irq_handler(int irq, void *data)
{ {
acpi_handle handle = data; acpi_handle handle = data;
...@@ -64,6 +70,27 @@ static irqreturn_t acpi_gpio_irq_handler(int irq, void *data) ...@@ -64,6 +70,27 @@ static irqreturn_t acpi_gpio_irq_handler(int irq, void *data)
return IRQ_HANDLED; return IRQ_HANDLED;
} }
static irqreturn_t acpi_gpio_irq_handler_evt(int irq, void *data)
{
struct acpi_gpio_evt_pin *evt_pin = data;
struct acpi_object_list args;
union acpi_object arg;
arg.type = ACPI_TYPE_INTEGER;
arg.integer.value = evt_pin->pin;
args.count = 1;
args.pointer = &arg;
acpi_evaluate_object(evt_pin->evt_handle, NULL, &args, NULL);
return IRQ_HANDLED;
}
static void acpi_gpio_evt_dh(acpi_handle handle, void *data)
{
/* The address of this function is used as a key. */
}
/** /**
* acpi_gpiochip_request_interrupts() - Register isr for gpio chip ACPI events * acpi_gpiochip_request_interrupts() - Register isr for gpio chip ACPI events
* @chip: gpio chip * @chip: gpio chip
...@@ -73,15 +100,13 @@ static irqreturn_t acpi_gpio_irq_handler(int irq, void *data) ...@@ -73,15 +100,13 @@ static irqreturn_t acpi_gpio_irq_handler(int irq, void *data)
* chip's interrupt handler. acpi_gpiochip_request_interrupts finds out which * chip's interrupt handler. acpi_gpiochip_request_interrupts finds out which
* gpio pins have acpi event methods and assigns interrupt handlers that calls * gpio pins have acpi event methods and assigns interrupt handlers that calls
* the acpi event methods for those pins. * the acpi event methods for those pins.
*
* Interrupts are automatically freed on driver detach
*/ */
void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
{ {
struct acpi_buffer buf = {ACPI_ALLOCATE_BUFFER, NULL}; struct acpi_buffer buf = {ACPI_ALLOCATE_BUFFER, NULL};
struct acpi_resource *res; struct acpi_resource *res;
acpi_handle handle, ev_handle; acpi_handle handle, evt_handle;
struct list_head *evt_pins = NULL;
acpi_status status; acpi_status status;
unsigned int pin; unsigned int pin;
int irq, ret; int irq, ret;
...@@ -98,13 +123,30 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) ...@@ -98,13 +123,30 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
if (ACPI_FAILURE(status)) if (ACPI_FAILURE(status))
return; return;
/* If a gpio interrupt has an acpi event handler method, then status = acpi_get_handle(handle, "_EVT", &evt_handle);
* set up an interrupt handler that calls the acpi event handler if (ACPI_SUCCESS(status)) {
*/ evt_pins = kzalloc(sizeof(*evt_pins), GFP_KERNEL);
if (evt_pins) {
INIT_LIST_HEAD(evt_pins);
status = acpi_attach_data(handle, acpi_gpio_evt_dh,
evt_pins);
if (ACPI_FAILURE(status)) {
kfree(evt_pins);
evt_pins = NULL;
}
}
}
/*
* If a GPIO interrupt has an ACPI event handler method, or _EVT is
* present, set up an interrupt handler that calls the ACPI event
* handler.
*/
for (res = buf.pointer; for (res = buf.pointer;
res && (res->type != ACPI_RESOURCE_TYPE_END_TAG); res && (res->type != ACPI_RESOURCE_TYPE_END_TAG);
res = ACPI_NEXT_RESOURCE(res)) { res = ACPI_NEXT_RESOURCE(res)) {
irq_handler_t handler = NULL;
void *data;
if (res->type != ACPI_RESOURCE_TYPE_GPIO || if (res->type != ACPI_RESOURCE_TYPE_GPIO ||
res->data.gpio.connection_type != res->data.gpio.connection_type !=
...@@ -115,23 +157,42 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) ...@@ -115,23 +157,42 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
if (pin > chip->ngpio) if (pin > chip->ngpio)
continue; continue;
irq = chip->to_irq(chip, pin);
if (irq < 0)
continue;
if (pin <= 255) {
acpi_handle ev_handle;
sprintf(ev_name, "_%c%02X", sprintf(ev_name, "_%c%02X",
res->data.gpio.triggering ? 'E' : 'L', pin); res->data.gpio.triggering ? 'E' : 'L', pin);
status = acpi_get_handle(handle, ev_name, &ev_handle); status = acpi_get_handle(handle, ev_name, &ev_handle);
if (ACPI_FAILURE(status)) if (ACPI_SUCCESS(status)) {
handler = acpi_gpio_irq_handler;
data = ev_handle;
}
}
if (!handler && evt_pins) {
struct acpi_gpio_evt_pin *evt_pin;
evt_pin = kzalloc(sizeof(*evt_pin), GFP_KERNEL);
if (!evt_pin)
continue; continue;
irq = chip->to_irq(chip, pin); list_add_tail(&evt_pin->node, evt_pins);
if (irq < 0) evt_pin->evt_handle = evt_handle;
evt_pin->pin = pin;
evt_pin->irq = irq;
handler = acpi_gpio_irq_handler_evt;
data = evt_pin;
}
if (!handler)
continue; continue;
/* Assume BIOS sets the triggering, so no flags */ /* Assume BIOS sets the triggering, so no flags */
ret = devm_request_threaded_irq(chip->dev, irq, NULL, ret = devm_request_threaded_irq(chip->dev, irq, NULL, handler,
acpi_gpio_irq_handler, 0, "GPIO-signaled-ACPI-event",
0, data);
"GPIO-signaled-ACPI-event",
ev_handle);
if (ret) if (ret)
dev_err(chip->dev, dev_err(chip->dev,
"Failed to request IRQ %d ACPI event handler\n", "Failed to request IRQ %d ACPI event handler\n",
...@@ -139,3 +200,119 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) ...@@ -139,3 +200,119 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip)
} }
} }
EXPORT_SYMBOL(acpi_gpiochip_request_interrupts); EXPORT_SYMBOL(acpi_gpiochip_request_interrupts);
struct acpi_gpio_lookup {
struct acpi_gpio_info info;
int index;
int gpio;
int n;
};
static int acpi_find_gpio(struct acpi_resource *ares, void *data)
{
struct acpi_gpio_lookup *lookup = data;
if (ares->type != ACPI_RESOURCE_TYPE_GPIO)
return 1;
if (lookup->n++ == lookup->index && lookup->gpio < 0) {
const struct acpi_resource_gpio *agpio = &ares->data.gpio;
lookup->gpio = acpi_get_gpio(agpio->resource_source.string_ptr,
agpio->pin_table[0]);
lookup->info.gpioint =
agpio->connection_type == ACPI_RESOURCE_GPIO_TYPE_INT;
}
return 1;
}
/**
* acpi_get_gpio_by_index() - get a GPIO number from device resources
* @dev: pointer to a device to get GPIO from
* @index: index of GpioIo/GpioInt resource (starting from %0)
* @info: info pointer to fill in (optional)
*
* Function goes through ACPI resources for @dev and based on @index looks
* up a GpioIo/GpioInt resource, translates it to the Linux GPIO number,
* and returns it. @index matches GpioIo/GpioInt resources only so if there
* are total %3 GPIO resources, the index goes from %0 to %2.
*
* If the GPIO cannot be translated or there is an error, negative errno is
* returned.
*
* Note: if the GPIO resource has multiple entries in the pin list, this
* function only returns the first.
*/
int acpi_get_gpio_by_index(struct device *dev, int index,
struct acpi_gpio_info *info)
{
struct acpi_gpio_lookup lookup;
struct list_head resource_list;
struct acpi_device *adev;
acpi_handle handle;
int ret;
if (!dev)
return -EINVAL;
handle = ACPI_HANDLE(dev);
if (!handle || acpi_bus_get_device(handle, &adev))
return -ENODEV;
memset(&lookup, 0, sizeof(lookup));
lookup.index = index;
lookup.gpio = -ENODEV;
INIT_LIST_HEAD(&resource_list);
ret = acpi_dev_get_resources(adev, &resource_list, acpi_find_gpio,
&lookup);
if (ret < 0)
return ret;
acpi_dev_free_resource_list(&resource_list);
if (lookup.gpio >= 0 && info)
*info = lookup.info;
return lookup.gpio;
}
EXPORT_SYMBOL_GPL(acpi_get_gpio_by_index);
/**
* acpi_gpiochip_free_interrupts() - Free GPIO _EVT ACPI event interrupts.
* @chip: gpio chip
*
* Free interrupts associated with the _EVT method for the given GPIO chip.
*
* The remaining ACPI event interrupts associated with the chip are freed
* automatically.
*/
void acpi_gpiochip_free_interrupts(struct gpio_chip *chip)
{
acpi_handle handle;
acpi_status status;
struct list_head *evt_pins;
struct acpi_gpio_evt_pin *evt_pin, *ep;
if (!chip->dev || !chip->to_irq)
return;
handle = ACPI_HANDLE(chip->dev);
if (!handle)
return;
status = acpi_get_data(handle, acpi_gpio_evt_dh, (void **)&evt_pins);
if (ACPI_FAILURE(status))
return;
list_for_each_entry_safe_reverse(evt_pin, ep, evt_pins, node) {
devm_free_irq(chip->dev, evt_pin->irq, evt_pin);
list_del(&evt_pin->node);
kfree(evt_pin);
}
acpi_detach_data(handle, acpi_gpio_evt_dh);
kfree(evt_pins);
}
EXPORT_SYMBOL(acpi_gpiochip_free_interrupts);
#ifndef _LINUX_ACPI_GPIO_H_ #ifndef _LINUX_ACPI_GPIO_H_
#define _LINUX_ACPI_GPIO_H_ #define _LINUX_ACPI_GPIO_H_
#include <linux/device.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/gpio.h> #include <linux/gpio.h>
/**
* struct acpi_gpio_info - ACPI GPIO specific information
* @gpioint: if %true this GPIO is of type GpioInt otherwise type is GpioIo
*/
struct acpi_gpio_info {
bool gpioint;
};
#ifdef CONFIG_GPIO_ACPI #ifdef CONFIG_GPIO_ACPI
int acpi_get_gpio(char *path, int pin); int acpi_get_gpio(char *path, int pin);
int acpi_get_gpio_by_index(struct device *dev, int index,
struct acpi_gpio_info *info);
void acpi_gpiochip_request_interrupts(struct gpio_chip *chip); void acpi_gpiochip_request_interrupts(struct gpio_chip *chip);
void acpi_gpiochip_free_interrupts(struct gpio_chip *chip);
#else /* CONFIG_GPIO_ACPI */ #else /* CONFIG_GPIO_ACPI */
...@@ -16,7 +28,14 @@ static inline int acpi_get_gpio(char *path, int pin) ...@@ -16,7 +28,14 @@ static inline int acpi_get_gpio(char *path, int pin)
return -ENODEV; return -ENODEV;
} }
static inline int acpi_get_gpio_by_index(struct device *dev, int index,
struct acpi_gpio_info *info)
{
return -ENODEV;
}
static inline void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) { } static inline void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) { }
static inline void acpi_gpiochip_free_interrupts(struct gpio_chip *chip) { }
#endif /* CONFIG_GPIO_ACPI */ #endif /* CONFIG_GPIO_ACPI */
......
...@@ -72,5 +72,6 @@ int bgpio_init(struct bgpio_chip *bgc, struct device *dev, ...@@ -72,5 +72,6 @@ int bgpio_init(struct bgpio_chip *bgc, struct device *dev,
#define BGPIOF_BIG_ENDIAN BIT(0) #define BGPIOF_BIG_ENDIAN BIT(0)
#define BGPIOF_UNREADABLE_REG_SET BIT(1) /* reg_set is unreadable */ #define BGPIOF_UNREADABLE_REG_SET BIT(1) /* reg_set is unreadable */
#define BGPIOF_UNREADABLE_REG_DIR BIT(2) /* reg_dir is unreadable */ #define BGPIOF_UNREADABLE_REG_DIR BIT(2) /* reg_dir is unreadable */
#define BGPIOF_BIG_ENDIAN_BYTE_ORDER BIT(3)
#endif /* __BASIC_MMIO_GPIO_H */ #endif /* __BASIC_MMIO_GPIO_H */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment