Commit 31382a8d authored by Andi Kleen's avatar Andi Kleen Committed by Linus Torvalds

[PATCH] convert Linux to 4-level page tables

Extend the Linux MM to 4level page tables.

This is the core patch for mm/*, fs/*, include/linux/*

It breaks all architectures, which will be fixed in separate patches.

The conversion is quite straight forward.  All the functions walking the page
table hierarchy have been changed to deal with another level at the top.  The
additional level is called pml4. 

mm/memory.c has changed a lot because it did most of the heavy lifting here.
Most of the changes here are extensions of the previous code.  
Signed-off-by: default avatarAndi Kleen <ak@suse.de>

Converted by Nick Piggin to use the pud_t 'page upper' level between pgd
and pmd instead of Andi's pml4 level above pgd. 
Signed-off-by: default avatarNick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 5787c698
......@@ -124,7 +124,8 @@ static inline unsigned long
drm_follow_page (void *vaddr)
{
pgd_t *pgd = pgd_offset_k((unsigned long) vaddr);
pmd_t *pmd = pmd_offset(pgd, (unsigned long) vaddr);
pud_t *pud = pud_offset(pgd, (unsigned long) vaddr);
pmd_t *pmd = pmd_offset(pud, (unsigned long) vaddr);
pte_t *ptep = pte_offset_kernel(pmd, (unsigned long) vaddr);
return pte_pfn(*ptep) << PAGE_SHIFT;
}
......
......@@ -300,6 +300,7 @@ void install_arg_page(struct vm_area_struct *vma,
{
struct mm_struct *mm = vma->vm_mm;
pgd_t * pgd;
pud_t * pud;
pmd_t * pmd;
pte_t * pte;
......@@ -310,7 +311,10 @@ void install_arg_page(struct vm_area_struct *vma,
pgd = pgd_offset(mm, address);
spin_lock(&mm->page_table_lock);
pmd = pmd_alloc(mm, pgd, address);
pud = pud_alloc(mm, pgd, address);
if (!pud)
goto out;
pmd = pmd_alloc(mm, pud, address);
if (!pmd)
goto out;
pte = pte_alloc_map(mm, pmd, address);
......
......@@ -581,7 +581,8 @@ static inline void unmap_shared_mapping_range(struct address_space *mapping,
}
extern int vmtruncate(struct inode * inode, loff_t offset);
extern pmd_t *FASTCALL(__pmd_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address));
extern pud_t *FASTCALL(__pud_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address));
extern pmd_t *FASTCALL(__pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long address));
extern pte_t *FASTCALL(pte_alloc_kernel(struct mm_struct *mm, pmd_t *pmd, unsigned long address));
extern pte_t *FASTCALL(pte_alloc_map(struct mm_struct *mm, pmd_t *pmd, unsigned long address));
extern int install_page(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr, struct page *page, pgprot_t prot);
......@@ -626,15 +627,22 @@ extern struct shrinker *set_shrinker(int, shrinker_t);
extern void remove_shrinker(struct shrinker *shrinker);
/*
* On a two-level page table, this ends up being trivial. Thus the
* inlining and the symmetry break with pte_alloc_map() that does all
* On a two-level or three-level page table, this ends up being trivial. Thus
* the inlining and the symmetry break with pte_alloc_map() that does all
* of this out-of-line.
*/
static inline pmd_t *pmd_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address)
static inline pud_t *pud_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address)
{
if (pgd_none(*pgd))
return __pmd_alloc(mm, pgd, address);
return pmd_offset(pgd, address);
return __pud_alloc(mm, pgd, address);
return pud_offset(pgd, address);
}
static inline pmd_t *pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long address)
{
if (pud_none(*pud))
return __pmd_alloc(mm, pud, address);
return pmd_offset(pud, address);
}
extern void free_area_init(unsigned long * zones_size);
......
......@@ -60,14 +60,19 @@ int install_page(struct mm_struct *mm, struct vm_area_struct *vma,
pgoff_t size;
int err = -ENOMEM;
pte_t *pte;
pgd_t *pgd;
pmd_t *pmd;
pud_t *pud;
pgd_t *pgd;
pte_t pte_val;
pgd = pgd_offset(mm, addr);
spin_lock(&mm->page_table_lock);
pud = pud_alloc(mm, pgd, addr);
if (!pud)
goto err_unlock;
pmd = pmd_alloc(mm, pgd, addr);
pmd = pmd_alloc(mm, pud, addr);
if (!pmd)
goto err_unlock;
......@@ -112,14 +117,19 @@ int install_file_pte(struct mm_struct *mm, struct vm_area_struct *vma,
{
int err = -ENOMEM;
pte_t *pte;
pgd_t *pgd;
pmd_t *pmd;
pud_t *pud;
pgd_t *pgd;
pte_t pte_val;
pgd = pgd_offset(mm, addr);
spin_lock(&mm->page_table_lock);
pud = pud_alloc(mm, pgd, addr);
if (!pud)
goto err_unlock;
pmd = pmd_alloc(mm, pgd, addr);
pmd = pmd_alloc(mm, pud, addr);
if (!pmd)
goto err_unlock;
......
......@@ -34,6 +34,8 @@
*
* 16.07.99 - Support of BIGMEM added by Gerhard Wichert, Siemens AG
* (Gerhard.Wichert@pdb.siemens.de)
*
* Aug/Sep 2004 Changed to four level page tables (Andi Kleen)
*/
#include <linux/kernel_stat.h>
......@@ -120,11 +122,42 @@ static inline void clear_pmd_range(struct mmu_gather *tlb, pmd_t *pmd, unsigned
}
}
static inline void clear_pgd_range(struct mmu_gather *tlb, pgd_t *pgd, unsigned long start, unsigned long end)
static inline void clear_pud_range(struct mmu_gather *tlb, pud_t *pud, unsigned long start, unsigned long end)
{
unsigned long addr = start, next;
pmd_t *pmd, *__pmd;
if (pud_none(*pud))
return;
if (unlikely(pud_bad(*pud))) {
pud_ERROR(*pud);
pud_clear(pud);
return;
}
pmd = __pmd = pmd_offset(pud, start);
do {
next = (addr + PMD_SIZE) & PMD_MASK;
if (next > end || next <= addr)
next = end;
clear_pmd_range(tlb, pmd, addr, next);
pmd++;
addr = next;
} while (addr && (addr < end));
if (!(start & ~PUD_MASK) && !(end & ~PUD_MASK)) {
pud_clear(pud);
pmd_free_tlb(tlb, __pmd);
}
}
static inline void clear_pgd_range(struct mmu_gather *tlb, pgd_t *pgd, unsigned long start, unsigned long end)
{
unsigned long addr = start, next;
pud_t *pud, *__pud;
if (pgd_none(*pgd))
return;
if (unlikely(pgd_bad(*pgd))) {
......@@ -133,20 +166,20 @@ static inline void clear_pgd_range(struct mmu_gather *tlb, pgd_t *pgd, unsigned
return;
}
pmd = __pmd = pmd_offset(pgd, start);
pud = __pud = pud_offset(pgd, start);
do {
next = (addr + PMD_SIZE) & PMD_MASK;
next = (addr + PUD_SIZE) & PUD_MASK;
if (next > end || next <= addr)
next = end;
clear_pmd_range(tlb, pmd, addr, next);
pmd++;
clear_pud_range(tlb, pud, addr, next);
pud++;
addr = next;
} while (addr && (addr <= end - 1));
} while (addr && (addr < end));
if (!(start & ~PGDIR_MASK) && !(end & ~PGDIR_MASK)) {
pgd_clear(pgd);
pmd_free_tlb(tlb, __pmd);
pud_free_tlb(tlb, __pud);
}
}
......@@ -326,15 +359,15 @@ static int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
}
static int copy_pmd_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
pgd_t *dst_pgd, pgd_t *src_pgd, struct vm_area_struct *vma,
pud_t *dst_pud, pud_t *src_pud, struct vm_area_struct *vma,
unsigned long addr, unsigned long end)
{
pmd_t *src_pmd, *dst_pmd;
int err = 0;
unsigned long next;
src_pmd = pmd_offset(src_pgd, addr);
dst_pmd = pmd_alloc(dst_mm, dst_pgd, addr);
src_pmd = pmd_offset(src_pud, addr);
dst_pmd = pmd_alloc(dst_mm, dst_pud, addr);
if (!dst_pmd)
return -ENOMEM;
......@@ -357,6 +390,38 @@ static int copy_pmd_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
return err;
}
static int copy_pud_range(struct mm_struct *dst_mm, struct mm_struct *src_mm,
pgd_t *dst_pgd, pgd_t *src_pgd, struct vm_area_struct *vma,
unsigned long addr, unsigned long end)
{
pud_t *src_pud, *dst_pud;
int err = 0;
unsigned long next;
src_pud = pud_offset(src_pgd, addr);
dst_pud = pud_alloc(dst_mm, dst_pgd, addr);
if (!dst_pud)
return -ENOMEM;
for (; addr < end; addr = next, src_pud++, dst_pud++) {
next = (addr + PUD_SIZE) & PUD_MASK;
if (next > end)
next = end;
if (pud_none(*src_pud))
continue;
if (pud_bad(*src_pud)) {
pud_ERROR(*src_pud);
pud_clear(src_pud);
continue;
}
err = copy_pmd_range(dst_mm, src_mm, dst_pud, src_pud,
vma, addr, next);
if (err)
break;
}
return err;
}
int copy_page_range(struct mm_struct *dst, struct mm_struct *src,
struct vm_area_struct *vma)
{
......@@ -384,7 +449,7 @@ int copy_page_range(struct mm_struct *dst, struct mm_struct *src,
pgd_clear(src_pgd);
continue;
}
err = copy_pmd_range(dst, src, dst_pgd, src_pgd,
err = copy_pud_range(dst, src, dst_pgd, src_pgd,
vma, addr, next);
if (err)
break;
......@@ -481,23 +546,23 @@ static void zap_pte_range(struct mmu_gather *tlb,
}
static void zap_pmd_range(struct mmu_gather *tlb,
pgd_t * dir, unsigned long address,
pud_t *pud, unsigned long address,
unsigned long size, struct zap_details *details)
{
pmd_t * pmd;
unsigned long end;
if (pgd_none(*dir))
if (pud_none(*pud))
return;
if (unlikely(pgd_bad(*dir))) {
pgd_ERROR(*dir);
pgd_clear(dir);
if (unlikely(pud_bad(*pud))) {
pud_ERROR(*pud);
pud_clear(pud);
return;
}
pmd = pmd_offset(dir, address);
pmd = pmd_offset(pud, address);
end = address + size;
if (end > ((address + PGDIR_SIZE) & PGDIR_MASK))
end = ((address + PGDIR_SIZE) & PGDIR_MASK);
if (end > ((address + PUD_SIZE) & PUD_MASK))
end = ((address + PUD_SIZE) & PUD_MASK);
do {
zap_pte_range(tlb, pmd, address, end - address, details);
address = (address + PMD_SIZE) & PMD_MASK;
......@@ -505,20 +570,46 @@ static void zap_pmd_range(struct mmu_gather *tlb,
} while (address && (address < end));
}
static void zap_pud_range(struct mmu_gather *tlb,
pgd_t * pgd, unsigned long address,
unsigned long end, struct zap_details *details)
{
pud_t * pud;
if (pgd_none(*pgd))
return;
if (unlikely(pgd_bad(*pgd))) {
pgd_ERROR(*pgd);
pgd_clear(pgd);
return;
}
pud = pud_offset(pgd, address);
do {
zap_pmd_range(tlb, pud, address, end - address, details);
address = (address + PUD_SIZE) & PUD_MASK;
pud++;
} while (address && (address < end));
}
static void unmap_page_range(struct mmu_gather *tlb,
struct vm_area_struct *vma, unsigned long address,
unsigned long end, struct zap_details *details)
{
pgd_t * dir;
unsigned long next;
pgd_t *pgd;
int i;
BUG_ON(address >= end);
dir = pgd_offset(vma->vm_mm, address);
pgd = pgd_offset(vma->vm_mm, address);
tlb_start_vma(tlb, vma);
do {
zap_pmd_range(tlb, dir, address, end - address, details);
address = (address + PGDIR_SIZE) & PGDIR_MASK;
dir++;
} while (address && (address < end));
for (i = pgd_index(address); i <= pgd_index(end-1); i++) {
next = (address + PGDIR_SIZE) & PGDIR_MASK;
if (next <= address || next > end)
next = end;
zap_pud_range(tlb, pgd, address, next, details);
address = next;
pgd++;
}
tlb_end_vma(tlb, vma);
}
......@@ -660,6 +751,7 @@ struct page *
follow_page(struct mm_struct *mm, unsigned long address, int write)
{
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
pte_t *ptep, pte;
unsigned long pfn;
......@@ -673,13 +765,15 @@ follow_page(struct mm_struct *mm, unsigned long address, int write)
if (pgd_none(*pgd) || unlikely(pgd_bad(*pgd)))
goto out;
pmd = pmd_offset(pgd, address);
if (pmd_none(*pmd))
pud = pud_offset(pgd, address);
if (pud_none(*pud) || unlikely(pud_bad(*pud)))
goto out;
pmd = pmd_offset(pud, address);
if (pmd_none(*pmd) || unlikely(pmd_bad(*pmd)))
goto out;
if (pmd_huge(*pmd))
return follow_huge_pmd(mm, address, pmd, write);
if (unlikely(pmd_bad(*pmd)))
goto out;
ptep = pte_offset_map(pmd, address);
if (!ptep)
......@@ -723,6 +817,7 @@ untouched_anonymous_page(struct mm_struct* mm, struct vm_area_struct *vma,
unsigned long address)
{
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
/* Check if the vma is for an anonymous mapping. */
......@@ -734,8 +829,12 @@ untouched_anonymous_page(struct mm_struct* mm, struct vm_area_struct *vma,
if (pgd_none(*pgd) || unlikely(pgd_bad(*pgd)))
return 1;
pud = pud_offset(pgd, address);
if (pud_none(*pud) || unlikely(pud_bad(*pud)))
return 1;
/* Check if page middle directory entry exists. */
pmd = pmd_offset(pgd, address);
pmd = pmd_offset(pud, address);
if (pmd_none(*pmd) || unlikely(pmd_bad(*pmd)))
return 1;
......@@ -767,6 +866,7 @@ int get_user_pages(struct task_struct *tsk, struct mm_struct *mm,
unsigned long pg = start & PAGE_MASK;
struct vm_area_struct *gate_vma = get_gate_vma(tsk);
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
pte_t *pte;
if (write) /* user gate pages are read-only */
......@@ -776,7 +876,9 @@ int get_user_pages(struct task_struct *tsk, struct mm_struct *mm,
else
pgd = pgd_offset_gate(mm, pg);
BUG_ON(pgd_none(*pgd));
pmd = pmd_offset(pgd, pg);
pud = pud_offset(pgd, pg);
BUG_ON(pud_none(*pud));
pmd = pmd_offset(pud, pg);
BUG_ON(pmd_none(*pmd));
pte = pte_offset_map(pmd, pg);
BUG_ON(pte_none(*pte));
......@@ -889,16 +991,16 @@ static void zeromap_pte_range(pte_t * pte, unsigned long address,
} while (address && (address < end));
}
static inline int zeromap_pmd_range(struct mm_struct *mm, pmd_t * pmd, unsigned long address,
unsigned long size, pgprot_t prot)
static inline int zeromap_pmd_range(struct mm_struct *mm, pmd_t * pmd,
unsigned long address, unsigned long size, pgprot_t prot)
{
unsigned long base, end;
base = address & PGDIR_MASK;
address &= ~PGDIR_MASK;
base = address & PUD_MASK;
address &= ~PUD_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
if (end > PUD_SIZE)
end = PUD_SIZE;
do {
pte_t * pte = pte_alloc_map(mm, pmd, base + address);
if (!pte)
......@@ -911,31 +1013,64 @@ static inline int zeromap_pmd_range(struct mm_struct *mm, pmd_t * pmd, unsigned
return 0;
}
int zeromap_page_range(struct vm_area_struct *vma, unsigned long address, unsigned long size, pgprot_t prot)
static inline int zeromap_pud_range(struct mm_struct *mm, pud_t * pud,
unsigned long address,
unsigned long size, pgprot_t prot)
{
unsigned long base, end;
int error = 0;
base = address & PGDIR_MASK;
address &= ~PGDIR_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
do {
pmd_t * pmd = pmd_alloc(mm, pud, base + address);
error = -ENOMEM;
if (!pmd)
break;
error = zeromap_pmd_range(mm, pmd, address, end - address, prot);
if (error)
break;
address = (address + PUD_SIZE) & PUD_MASK;
pud++;
} while (address && (address < end));
return 0;
}
int zeromap_page_range(struct vm_area_struct *vma, unsigned long address,
unsigned long size, pgprot_t prot)
{
int i;
int error = 0;
pgd_t * dir;
pgd_t * pgd;
unsigned long beg = address;
unsigned long end = address + size;
unsigned long next;
struct mm_struct *mm = vma->vm_mm;
dir = pgd_offset(mm, address);
pgd = pgd_offset(mm, address);
flush_cache_range(vma, beg, end);
if (address >= end)
BUG();
BUG_ON(address >= end);
BUG_ON(end > vma->vm_end);
spin_lock(&mm->page_table_lock);
do {
pmd_t *pmd = pmd_alloc(mm, dir, address);
for (i = pgd_index(address); i <= pgd_index(end-1); i++) {
pud_t *pud = pud_alloc(mm, pgd, address);
error = -ENOMEM;
if (!pmd)
if (!pud)
break;
error = zeromap_pmd_range(mm, pmd, address, end - address, prot);
next = (address + PGDIR_SIZE) & PGDIR_MASK;
if (next <= beg || next > end)
next = end;
error = zeromap_pud_range(mm, pud, address,
next - address, prot);
if (error)
break;
address = (address + PGDIR_SIZE) & PGDIR_MASK;
dir++;
} while (address && (address < end));
address = next;
pgd++;
}
/*
* Why flush? zeromap_pte_range has a BUG_ON for !pte_none()
*/
......@@ -949,8 +1084,9 @@ int zeromap_page_range(struct vm_area_struct *vma, unsigned long address, unsign
* mappings are removed. any references to nonexistent pages results
* in null mappings (currently treated as "copy-on-access")
*/
static inline void remap_pte_range(pte_t * pte, unsigned long address, unsigned long size,
unsigned long pfn, pgprot_t prot)
static inline void
remap_pte_range(pte_t * pte, unsigned long address, unsigned long size,
unsigned long pfn, pgprot_t prot)
{
unsigned long end;
......@@ -968,22 +1104,24 @@ static inline void remap_pte_range(pte_t * pte, unsigned long address, unsigned
} while (address && (address < end));
}
static inline int remap_pmd_range(struct mm_struct *mm, pmd_t * pmd, unsigned long address, unsigned long size,
unsigned long pfn, pgprot_t prot)
static inline int
remap_pmd_range(struct mm_struct *mm, pmd_t * pmd, unsigned long address,
unsigned long size, unsigned long pfn, pgprot_t prot)
{
unsigned long base, end;
base = address & PGDIR_MASK;
address &= ~PGDIR_MASK;
base = address & PUD_MASK;
address &= ~PUD_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
pfn -= address >> PAGE_SHIFT;
if (end > PUD_SIZE)
end = PUD_SIZE;
pfn -= (address >> PAGE_SHIFT);
do {
pte_t * pte = pte_alloc_map(mm, pmd, base + address);
if (!pte)
return -ENOMEM;
remap_pte_range(pte, base + address, end - address, pfn + (address >> PAGE_SHIFT), prot);
remap_pte_range(pte, base + address, end - address,
(address >> PAGE_SHIFT) + pfn, prot);
pte_unmap(pte);
address = (address + PMD_SIZE) & PMD_MASK;
pmd++;
......@@ -991,20 +1129,50 @@ static inline int remap_pmd_range(struct mm_struct *mm, pmd_t * pmd, unsigned lo
return 0;
}
static inline int remap_pud_range(struct mm_struct *mm, pud_t * pud,
unsigned long address, unsigned long size,
unsigned long pfn, pgprot_t prot)
{
unsigned long base, end;
int error;
base = address & PGDIR_MASK;
address &= ~PGDIR_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
pfn -= address >> PAGE_SHIFT;
do {
pmd_t *pmd = pmd_alloc(mm, pud, base+address);
error = -ENOMEM;
if (!pmd)
break;
error = remap_pmd_range(mm, pmd, base + address, end - address,
(address >> PAGE_SHIFT) + pfn, prot);
if (error)
break;
address = (address + PUD_SIZE) & PUD_MASK;
pud++;
} while (address && (address < end));
return error;
}
/* Note: this is only safe if the mm semaphore is held when called. */
int remap_pfn_range(struct vm_area_struct *vma, unsigned long from, unsigned long pfn, unsigned long size, pgprot_t prot)
int remap_pfn_range(struct vm_area_struct *vma, unsigned long from,
unsigned long pfn, unsigned long size, pgprot_t prot)
{
int error = 0;
pgd_t * dir;
pgd_t *pgd;
unsigned long beg = from;
unsigned long end = from + size;
unsigned long next;
struct mm_struct *mm = vma->vm_mm;
int i;
pfn -= from >> PAGE_SHIFT;
dir = pgd_offset(mm, from);
pgd = pgd_offset(mm, from);
flush_cache_range(vma, beg, end);
if (from >= end)
BUG();
BUG_ON(from >= end);
/*
* Physically remapped pages are special. Tell the
......@@ -1015,25 +1183,32 @@ int remap_pfn_range(struct vm_area_struct *vma, unsigned long from, unsigned lon
* this region.
*/
vma->vm_flags |= VM_IO | VM_RESERVED;
spin_lock(&mm->page_table_lock);
do {
pmd_t *pmd = pmd_alloc(mm, dir, from);
for (i = pgd_index(beg); i <= pgd_index(end-1); i++) {
pud_t *pud = pud_alloc(mm, pgd, from);
error = -ENOMEM;
if (!pmd)
if (!pud)
break;
error = remap_pmd_range(mm, pmd, from, end - from, pfn + (from >> PAGE_SHIFT), prot);
next = (from + PGDIR_SIZE) & PGDIR_MASK;
if (next > end || next <= from)
next = end;
error = remap_pud_range(mm, pud, from, end - from,
pfn + (from >> PAGE_SHIFT), prot);
if (error)
break;
from = (from + PGDIR_SIZE) & PGDIR_MASK;
dir++;
} while (from && (from < end));
from = next;
pgd++;
}
/*
* Why flush? remap_pte_range has a BUG_ON for !pte_none()
*/
flush_tlb_range(vma, beg, end);
spin_unlock(&mm->page_table_lock);
return error;
}
EXPORT_SYMBOL(remap_pfn_range);
/*
......@@ -1725,13 +1900,14 @@ static inline int handle_pte_fault(struct mm_struct *mm,
* By the time we get here, we already hold the mm semaphore
*/
int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct * vma,
unsigned long address, int write_access)
unsigned long address, int write_access)
{
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
pte_t *pte;
__set_current_state(TASK_RUNNING);
pgd = pgd_offset(mm, address);
inc_page_state(pgfault);
......@@ -1742,18 +1918,63 @@ int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct * vma,
* We need the page table lock to synchronize with kswapd
* and the SMP-safe atomic PTE updates.
*/
pgd = pgd_offset(mm, address);
spin_lock(&mm->page_table_lock);
pmd = pmd_alloc(mm, pgd, address);
if (pmd) {
pte_t * pte = pte_alloc_map(mm, pmd, address);
if (pte)
return handle_pte_fault(mm, vma, address, write_access, pte, pmd);
}
pud = pud_alloc(mm, pgd, address);
if (!pud)
goto oom;
pmd = pmd_alloc(mm, pud, address);
if (!pmd)
goto oom;
pte = pte_alloc_map(mm, pmd, address);
if (!pte)
goto oom;
return handle_pte_fault(mm, vma, address, write_access, pte, pmd);
oom:
spin_unlock(&mm->page_table_lock);
return VM_FAULT_OOM;
}
#if (PTRS_PER_PGD > 1)
/*
* Allocate page upper directory.
*
* We've already handled the fast-path in-line, and we own the
* page table lock.
*
* On a two-level or three-level page table, this ends up actually being
* entirely optimized away.
*/
pud_t fastcall *__pud_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address)
{
pud_t *new;
spin_unlock(&mm->page_table_lock);
new = pud_alloc_one(mm, address);
spin_lock(&mm->page_table_lock);
if (!new)
return NULL;
/*
* Because we dropped the lock, we should re-check the
* entry, as somebody else could have populated it..
*/
if (pgd_present(*pgd)) {
pud_free(new);
goto out;
}
pgd_populate(mm, pgd, new);
out:
return pud_offset(pgd, address);
}
#endif
#if (PTRS_PER_PUD > 1)
/*
* Allocate page middle directory.
*
......@@ -1763,7 +1984,7 @@ int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct * vma,
* On a two-level page table, this ends up actually being entirely
* optimized away.
*/
pmd_t fastcall *__pmd_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address)
pmd_t fastcall *__pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long address)
{
pmd_t *new;
......@@ -1777,14 +1998,15 @@ pmd_t fastcall *__pmd_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long addr
* Because we dropped the lock, we should re-check the
* entry, as somebody else could have populated it..
*/
if (pgd_present(*pgd)) {
if (pud_present(*pud)) {
pmd_free(new);
goto out;
}
pgd_populate(mm, pgd, new);
pud_populate(mm, pud, new);
out:
return pmd_offset(pgd, address);
return pmd_offset(pud, address);
}
#endif
int make_pages_present(unsigned long addr, unsigned long end)
{
......@@ -1815,17 +2037,21 @@ struct page * vmalloc_to_page(void * vmalloc_addr)
unsigned long addr = (unsigned long) vmalloc_addr;
struct page *page = NULL;
pgd_t *pgd = pgd_offset_k(addr);
pud_t *pud;
pmd_t *pmd;
pte_t *ptep, pte;
if (!pgd_none(*pgd)) {
pmd = pmd_offset(pgd, addr);
if (!pmd_none(*pmd)) {
ptep = pte_offset_map(pmd, addr);
pte = *ptep;
if (pte_present(pte))
page = pte_page(pte);
pte_unmap(ptep);
pud = pud_offset(pgd, addr);
if (!pud_none(*pud)) {
pmd = pmd_offset(pud, addr);
if (!pmd_none(*pmd)) {
ptep = pte_offset_map(pmd, addr);
pte = *ptep;
if (pte_present(pte))
page = pte_page(pte);
pte_unmap(ptep);
}
}
}
return page;
......
......@@ -234,18 +234,29 @@ static struct mempolicy *mpol_new(int mode, unsigned long *nodes)
/* Ensure all existing pages follow the policy. */
static int
verify_pages(unsigned long addr, unsigned long end, unsigned long *nodes)
verify_pages(struct mm_struct *mm,
unsigned long addr, unsigned long end, unsigned long *nodes)
{
while (addr < end) {
struct page *p;
pte_t *pte;
pmd_t *pmd;
pgd_t *pgd = pgd_offset_k(addr);
pud_t *pud;
pgd_t *pgd;
pgd = pgd_offset(mm, addr);
if (pgd_none(*pgd)) {
addr = (addr + PGDIR_SIZE) & PGDIR_MASK;
unsigned long next = (addr + PGDIR_SIZE) & PGDIR_MASK;
if (next > addr)
break;
addr = next;
continue;
}
pud = pud_offset(pgd, addr);
if (pud_none(*pud)) {
addr = (addr + PUD_SIZE) & PUD_MASK;
continue;
}
pmd = pmd_offset(pgd, addr);
pmd = pmd_offset(pud, addr);
if (pmd_none(*pmd)) {
addr = (addr + PMD_SIZE) & PMD_MASK;
continue;
......@@ -283,7 +294,8 @@ check_range(struct mm_struct *mm, unsigned long start, unsigned long end,
if (prev && prev->vm_end < vma->vm_start)
return ERR_PTR(-EFAULT);
if ((flags & MPOL_MF_STRICT) && !is_vm_hugetlb_page(vma)) {
err = verify_pages(vma->vm_start, vma->vm_end, nodes);
err = verify_pages(vma->vm_mm,
vma->vm_start, vma->vm_end, nodes);
if (err) {
first = ERR_PTR(err);
break;
......
......@@ -62,12 +62,38 @@ change_pte_range(pmd_t *pmd, unsigned long address,
}
static inline void
change_pmd_range(pgd_t *pgd, unsigned long address,
change_pmd_range(pud_t *pud, unsigned long address,
unsigned long size, pgprot_t newprot)
{
pmd_t * pmd;
unsigned long end;
if (pud_none(*pud))
return;
if (pud_bad(*pud)) {
pud_ERROR(*pud);
pud_clear(pud);
return;
}
pmd = pmd_offset(pud, address);
address &= ~PUD_MASK;
end = address + size;
if (end > PUD_SIZE)
end = PUD_SIZE;
do {
change_pte_range(pmd, address, end - address, newprot);
address = (address + PMD_SIZE) & PMD_MASK;
pmd++;
} while (address && (address < end));
}
static inline void
change_pud_range(pgd_t *pgd, unsigned long address,
unsigned long size, pgprot_t newprot)
{
pud_t * pud;
unsigned long end;
if (pgd_none(*pgd))
return;
if (pgd_bad(*pgd)) {
......@@ -75,15 +101,15 @@ change_pmd_range(pgd_t *pgd, unsigned long address,
pgd_clear(pgd);
return;
}
pmd = pmd_offset(pgd, address);
pud = pud_offset(pgd, address);
address &= ~PGDIR_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
do {
change_pte_range(pmd, address, end - address, newprot);
address = (address + PMD_SIZE) & PMD_MASK;
pmd++;
change_pmd_range(pud, address, end - address, newprot);
address = (address + PUD_SIZE) & PUD_MASK;
pud++;
} while (address && (address < end));
}
......@@ -91,22 +117,25 @@ static void
change_protection(struct vm_area_struct *vma, unsigned long start,
unsigned long end, pgprot_t newprot)
{
pgd_t *dir;
unsigned long beg = start;
struct mm_struct *mm = current->mm;
pgd_t *pgd;
unsigned long beg = start, next;
int i;
dir = pgd_offset(current->mm, start);
pgd = pgd_offset(mm, start);
flush_cache_range(vma, beg, end);
if (start >= end)
BUG();
spin_lock(&current->mm->page_table_lock);
do {
change_pmd_range(dir, start, end - start, newprot);
start = (start + PGDIR_SIZE) & PGDIR_MASK;
dir++;
} while (start && (start < end));
BUG_ON(start >= end);
spin_lock(&mm->page_table_lock);
for (i = pgd_index(start); i <= pgd_index(end-1); i++) {
next = (start + PGDIR_SIZE) & PGDIR_MASK;
if (next <= start || next > end)
next = end;
change_pud_range(pgd, start, next - start, newprot);
start = next;
pgd++;
}
flush_tlb_range(vma, beg, end);
spin_unlock(&current->mm->page_table_lock);
return;
spin_unlock(&mm->page_table_lock);
}
static int
......
......@@ -25,19 +25,24 @@
static pte_t *get_one_pte_map_nested(struct mm_struct *mm, unsigned long addr)
{
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
pte_t *pte = NULL;
pgd = pgd_offset(mm, addr);
if (pgd_none(*pgd))
goto end;
if (pgd_bad(*pgd)) {
pgd_ERROR(*pgd);
pgd_clear(pgd);
pud = pud_offset(pgd, addr);
if (pud_none(*pud))
goto end;
if (pud_bad(*pud)) {
pud_ERROR(*pud);
pud_clear(pud);
goto end;
}
pmd = pmd_offset(pgd, addr);
pmd = pmd_offset(pud, addr);
if (pmd_none(*pmd))
goto end;
if (pmd_bad(*pmd)) {
......@@ -58,12 +63,17 @@ static pte_t *get_one_pte_map_nested(struct mm_struct *mm, unsigned long addr)
static pte_t *get_one_pte_map(struct mm_struct *mm, unsigned long addr)
{
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
pgd = pgd_offset(mm, addr);
if (pgd_none(*pgd))
return NULL;
pmd = pmd_offset(pgd, addr);
pud = pud_offset(pgd, addr);
if (pud_none(*pud))
return NULL;
pmd = pmd_offset(pud, addr);
if (!pmd_present(*pmd))
return NULL;
return pte_offset_map(pmd, addr);
......@@ -71,10 +81,17 @@ static pte_t *get_one_pte_map(struct mm_struct *mm, unsigned long addr)
static inline pte_t *alloc_one_pte_map(struct mm_struct *mm, unsigned long addr)
{
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
pte_t *pte = NULL;
pmd = pmd_alloc(mm, pgd_offset(mm, addr), addr);
pgd = pgd_offset(mm, addr);
pud = pud_alloc(mm, pgd, addr);
if (!pud)
return NULL;
pmd = pmd_alloc(mm, pud, addr);
if (pmd)
pte = pte_alloc_map(mm, pmd, addr);
return pte;
......
......@@ -67,13 +67,39 @@ static int filemap_sync_pte_range(pmd_t * pmd,
return error;
}
static inline int filemap_sync_pmd_range(pgd_t * pgd,
static inline int filemap_sync_pmd_range(pud_t * pud,
unsigned long address, unsigned long end,
struct vm_area_struct *vma, unsigned int flags)
{
pmd_t * pmd;
int error;
if (pud_none(*pud))
return 0;
if (pud_bad(*pud)) {
pud_ERROR(*pud);
pud_clear(pud);
return 0;
}
pmd = pmd_offset(pud, address);
if ((address & PUD_MASK) != (end & PUD_MASK))
end = (address & PUD_MASK) + PUD_SIZE;
error = 0;
do {
error |= filemap_sync_pte_range(pmd, address, end, vma, flags);
address = (address + PMD_SIZE) & PMD_MASK;
pmd++;
} while (address && (address < end));
return error;
}
static inline int filemap_sync_pud_range(pgd_t *pgd,
unsigned long address, unsigned long end,
struct vm_area_struct *vma, unsigned int flags)
{
pud_t *pud;
int error;
if (pgd_none(*pgd))
return 0;
if (pgd_bad(*pgd)) {
......@@ -81,14 +107,14 @@ static inline int filemap_sync_pmd_range(pgd_t * pgd,
pgd_clear(pgd);
return 0;
}
pmd = pmd_offset(pgd, address);
pud = pud_offset(pgd, address);
if ((address & PGDIR_MASK) != (end & PGDIR_MASK))
end = (address & PGDIR_MASK) + PGDIR_SIZE;
error = 0;
do {
error |= filemap_sync_pte_range(pmd, address, end, vma, flags);
address = (address + PMD_SIZE) & PMD_MASK;
pmd++;
error |= filemap_sync_pmd_range(pud, address, end, vma, flags);
address = (address + PUD_SIZE) & PUD_MASK;
pud++;
} while (address && (address < end));
return error;
}
......@@ -96,8 +122,10 @@ static inline int filemap_sync_pmd_range(pgd_t * pgd,
static int filemap_sync(struct vm_area_struct * vma, unsigned long address,
size_t size, unsigned int flags)
{
pgd_t * dir;
pgd_t *pgd;
unsigned long end = address + size;
unsigned long next;
int i;
int error = 0;
/* Aquire the lock early; it may be possible to avoid dropping
......@@ -105,7 +133,7 @@ static int filemap_sync(struct vm_area_struct * vma, unsigned long address,
*/
spin_lock(&vma->vm_mm->page_table_lock);
dir = pgd_offset(vma->vm_mm, address);
pgd = pgd_offset(vma->vm_mm, address);
flush_cache_range(vma, address, end);
/* For hugepages we can't go walking the page table normally,
......@@ -116,11 +144,14 @@ static int filemap_sync(struct vm_area_struct * vma, unsigned long address,
if (address >= end)
BUG();
do {
error |= filemap_sync_pmd_range(dir, address, end, vma, flags);
address = (address + PGDIR_SIZE) & PGDIR_MASK;
dir++;
} while (address && (address < end));
for (i = pgd_index(address); i <= pgd_index(end-1); i++) {
next = (address + PGDIR_SIZE) & PGDIR_MASK;
if (next <= address || next > end)
next = end;
error |= filemap_sync_pud_range(pgd, address, next, vma, flags);
address = next;
pgd++;
}
/*
* Why flush ? filemap_sync_pte already flushed the tlbs with the
* dirty bits.
......
......@@ -259,6 +259,7 @@ static int page_referenced_one(struct page *page,
struct mm_struct *mm = vma->vm_mm;
unsigned long address;
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
pte_t *pte;
int referenced = 0;
......@@ -275,7 +276,11 @@ static int page_referenced_one(struct page *page,
if (!pgd_present(*pgd))
goto out_unlock;
pmd = pmd_offset(pgd, address);
pud = pud_offset(pgd, address);
if (!pud_present(*pud))
goto out_unlock;
pmd = pmd_offset(pud, address);
if (!pmd_present(*pmd))
goto out_unlock;
......@@ -505,6 +510,7 @@ static int try_to_unmap_one(struct page *page, struct vm_area_struct *vma)
struct mm_struct *mm = vma->vm_mm;
unsigned long address;
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
pte_t *pte;
pte_t pteval;
......@@ -526,7 +532,11 @@ static int try_to_unmap_one(struct page *page, struct vm_area_struct *vma)
if (!pgd_present(*pgd))
goto out_unlock;
pmd = pmd_offset(pgd, address);
pud = pud_offset(pgd, address);
if (!pud_present(*pud))
goto out_unlock;
pmd = pmd_offset(pud, address);
if (!pmd_present(*pmd))
goto out_unlock;
......@@ -634,6 +644,7 @@ static void try_to_unmap_cluster(unsigned long cursor,
{
struct mm_struct *mm = vma->vm_mm;
pgd_t *pgd;
pud_t *pud;
pmd_t *pmd;
pte_t *pte;
pte_t pteval;
......@@ -659,7 +670,11 @@ static void try_to_unmap_cluster(unsigned long cursor,
if (!pgd_present(*pgd))
goto out_unlock;
pmd = pmd_offset(pgd, address);
pud = pud_offset(pgd, address);
if (!pud_present(*pud))
goto out_unlock;
pmd = pmd_offset(pud, address);
if (!pmd_present(*pmd))
goto out_unlock;
......
......@@ -486,27 +486,27 @@ static unsigned long unuse_pmd(struct vm_area_struct * vma, pmd_t *dir,
}
/* vma->vm_mm->page_table_lock is held */
static unsigned long unuse_pgd(struct vm_area_struct * vma, pgd_t *dir,
unsigned long address, unsigned long size,
static unsigned long unuse_pud(struct vm_area_struct * vma, pud_t *pud,
unsigned long address, unsigned long size, unsigned long offset,
swp_entry_t entry, struct page *page)
{
pmd_t * pmd;
unsigned long offset, end;
unsigned long end;
unsigned long foundaddr;
if (pgd_none(*dir))
if (pud_none(*pud))
return 0;
if (pgd_bad(*dir)) {
pgd_ERROR(*dir);
pgd_clear(dir);
if (pud_bad(*pud)) {
pud_ERROR(*pud);
pud_clear(pud);
return 0;
}
pmd = pmd_offset(dir, address);
offset = address & PGDIR_MASK;
address &= ~PGDIR_MASK;
pmd = pmd_offset(pud, address);
offset += address & PUD_MASK;
address &= ~PUD_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
if (end > PUD_SIZE)
end = PUD_SIZE;
if (address >= end)
BUG();
do {
......@@ -520,13 +520,49 @@ static unsigned long unuse_pgd(struct vm_area_struct * vma, pgd_t *dir,
return 0;
}
/* vma->vm_mm->page_table_lock is held */
static unsigned long unuse_pgd(struct vm_area_struct * vma, pgd_t *pgd,
unsigned long address, unsigned long size,
swp_entry_t entry, struct page *page)
{
pud_t * pud;
unsigned long offset;
unsigned long foundaddr;
unsigned long end;
if (pgd_none(*pgd))
return 0;
if (pgd_bad(*pgd)) {
pgd_ERROR(*pgd);
pgd_clear(pgd);
return 0;
}
pud = pud_offset(pgd, address);
offset = address & PGDIR_MASK;
address &= ~PGDIR_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
BUG_ON (address >= end);
do {
foundaddr = unuse_pud(vma, pud, address, end - address,
offset, entry, page);
if (foundaddr)
return foundaddr;
address = (address + PUD_SIZE) & PUD_MASK;
pud++;
} while (address && (address < end));
return 0;
}
/* vma->vm_mm->page_table_lock is held */
static unsigned long unuse_vma(struct vm_area_struct * vma,
swp_entry_t entry, struct page *page)
{
pgd_t *pgdir;
unsigned long start, end;
pgd_t *pgd;
unsigned long start, end, next;
unsigned long foundaddr;
int i;
if (page->mapping) {
start = page_address_in_vma(page, vma);
......@@ -538,15 +574,18 @@ static unsigned long unuse_vma(struct vm_area_struct * vma,
start = vma->vm_start;
end = vma->vm_end;
}
pgdir = pgd_offset(vma->vm_mm, start);
do {
foundaddr = unuse_pgd(vma, pgdir, start, end - start,
entry, page);
pgd = pgd_offset(vma->vm_mm, start);
for (i = pgd_index(start); i <= pgd_index(end-1); i++) {
next = (start + PGDIR_SIZE) & PGDIR_MASK;
if (next > end || next <= start)
next = end;
foundaddr = unuse_pgd(vma, pgd, start, next - start, entry, page);
if (foundaddr)
return foundaddr;
start = (start + PGDIR_SIZE) & PGDIR_MASK;
pgdir++;
} while (start && (start < end));
start = next;
i++;
pgd++;
}
return 0;
}
......
......@@ -56,25 +56,25 @@ static void unmap_area_pte(pmd_t *pmd, unsigned long address,
} while (address < end);
}
static void unmap_area_pmd(pgd_t *dir, unsigned long address,
static void unmap_area_pmd(pud_t *pud, unsigned long address,
unsigned long size)
{
unsigned long end;
pmd_t *pmd;
if (pgd_none(*dir))
if (pud_none(*pud))
return;
if (pgd_bad(*dir)) {
pgd_ERROR(*dir);
pgd_clear(dir);
if (pud_bad(*pud)) {
pud_ERROR(*pud);
pud_clear(pud);
return;
}
pmd = pmd_offset(dir, address);
address &= ~PGDIR_MASK;
pmd = pmd_offset(pud, address);
address &= ~PUD_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
if (end > PUD_SIZE)
end = PUD_SIZE;
do {
unmap_area_pte(pmd, address, end - address);
......@@ -83,6 +83,33 @@ static void unmap_area_pmd(pgd_t *dir, unsigned long address,
} while (address < end);
}
static void unmap_area_pud(pgd_t *pgd, unsigned long address,
unsigned long size)
{
pud_t *pud;
unsigned long end;
if (pgd_none(*pgd))
return;
if (pgd_bad(*pgd)) {
pgd_ERROR(*pgd);
pgd_clear(pgd);
return;
}
pud = pud_offset(pgd, address);
address &= ~PGDIR_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
do {
unmap_area_pmd(pud, address, end - address);
address = (address + PUD_SIZE) & PUD_MASK;
pud++;
} while (address && (address < end));
}
static int map_area_pte(pte_t *pte, unsigned long address,
unsigned long size, pgprot_t prot,
struct page ***pages)
......@@ -96,7 +123,6 @@ static int map_area_pte(pte_t *pte, unsigned long address,
do {
struct page *page = **pages;
WARN_ON(!pte_none(*pte));
if (!page)
return -ENOMEM;
......@@ -115,11 +141,11 @@ static int map_area_pmd(pmd_t *pmd, unsigned long address,
{
unsigned long base, end;
base = address & PGDIR_MASK;
address &= ~PGDIR_MASK;
base = address & PUD_MASK;
address &= ~PUD_MASK;
end = address + size;
if (end > PGDIR_SIZE)
end = PGDIR_SIZE;
if (end > PUD_SIZE)
end = PUD_SIZE;
do {
pte_t * pte = pte_alloc_kernel(&init_mm, pmd, base + address);
......@@ -134,19 +160,41 @@ static int map_area_pmd(pmd_t *pmd, unsigned long address,
return 0;
}
static int map_area_pud(pud_t *pud, unsigned long address,
unsigned long end, pgprot_t prot,
struct page ***pages)
{
do {
pmd_t *pmd = pmd_alloc(&init_mm, pud, address);
if (!pmd)
return -ENOMEM;
if (map_area_pmd(pmd, address, end - address, prot, pages))
return -ENOMEM;
address = (address + PUD_SIZE) & PUD_MASK;
pud++;
} while (address && address < end);
return 0;
}
void unmap_vm_area(struct vm_struct *area)
{
unsigned long address = (unsigned long) area->addr;
unsigned long end = (address + area->size);
pgd_t *dir;
unsigned long next;
pgd_t *pgd;
int i;
dir = pgd_offset_k(address);
pgd = pgd_offset_k(address);
flush_cache_vunmap(address, end);
do {
unmap_area_pmd(dir, address, end - address);
address = (address + PGDIR_SIZE) & PGDIR_MASK;
dir++;
} while (address && (address < end));
for (i = pgd_index(address); i <= pgd_index(end-1); i++) {
next = (address + PGDIR_SIZE) & PGDIR_MASK;
if (next <= address || next > end)
next = end;
unmap_area_pud(pgd, address, next - address);
address = next;
pgd++;
}
flush_tlb_kernel_range((unsigned long) area->addr, end);
}
......@@ -154,25 +202,30 @@ int map_vm_area(struct vm_struct *area, pgprot_t prot, struct page ***pages)
{
unsigned long address = (unsigned long) area->addr;
unsigned long end = address + (area->size-PAGE_SIZE);
pgd_t *dir;
unsigned long next;
pgd_t *pgd;
int err = 0;
int i;
dir = pgd_offset_k(address);
pgd = pgd_offset_k(address);
spin_lock(&init_mm.page_table_lock);
do {
pmd_t *pmd = pmd_alloc(&init_mm, dir, address);
if (!pmd) {
for (i = pgd_index(address); i <= pgd_index(end-1); i++) {
pud_t *pud = pud_alloc(&init_mm, pgd, address);
if (!pud) {
err = -ENOMEM;
break;
}
if (map_area_pmd(pmd, address, end - address, prot, pages)) {
next = (address + PGDIR_SIZE) & PGDIR_MASK;
if (next < address || next > end)
next = end;
if (map_area_pud(pud, address, next, prot, pages)) {
err = -ENOMEM;
break;
}
address = (address + PGDIR_SIZE) & PGDIR_MASK;
dir++;
} while (address && (address < end));
address = next;
pgd++;
}
spin_unlock(&init_mm.page_table_lock);
flush_cache_vmap((unsigned long) area->addr, end);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment