Commit 31e9992a authored by Hema HK's avatar Hema HK Committed by Felipe Balbi

usb: otg: Remove one unnecessary I2C read request.

To get the ID status there was an I2C read transfer. Removed this I2C
read transfer as this info can be used from existing variable(linkstat).
Signed-off-by: default avatarHema HK <hemahk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Paul Walmsley <paul@pwsan.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 6dc2503b
...@@ -149,7 +149,6 @@ static int twl6030_set_phy_clk(struct otg_transceiver *x, int on) ...@@ -149,7 +149,6 @@ static int twl6030_set_phy_clk(struct otg_transceiver *x, int on)
static int twl6030_phy_init(struct otg_transceiver *x) static int twl6030_phy_init(struct otg_transceiver *x)
{ {
u8 hw_state;
struct twl6030_usb *twl; struct twl6030_usb *twl;
struct device *dev; struct device *dev;
struct twl4030_usb_data *pdata; struct twl4030_usb_data *pdata;
...@@ -158,9 +157,7 @@ static int twl6030_phy_init(struct otg_transceiver *x) ...@@ -158,9 +157,7 @@ static int twl6030_phy_init(struct otg_transceiver *x)
dev = twl->dev; dev = twl->dev;
pdata = dev->platform_data; pdata = dev->platform_data;
hw_state = twl6030_readb(twl, TWL6030_MODULE_ID0, STS_HW_CONDITIONS); if (twl->linkstat == USB_EVENT_ID)
if (hw_state & STS_USB_ID)
pdata->phy_power(twl->dev, 1, 1); pdata->phy_power(twl->dev, 1, 1);
else else
pdata->phy_power(twl->dev, 0, 1); pdata->phy_power(twl->dev, 0, 1);
...@@ -290,6 +287,7 @@ static irqreturn_t twl6030_usbotg_irq(int irq, void *_twl) ...@@ -290,6 +287,7 @@ static irqreturn_t twl6030_usbotg_irq(int irq, void *_twl)
status = USB_EVENT_ID; status = USB_EVENT_ID;
twl->otg.default_a = true; twl->otg.default_a = true;
twl->otg.state = OTG_STATE_A_IDLE; twl->otg.state = OTG_STATE_A_IDLE;
twl->linkstat = status;
blocking_notifier_call_chain(&twl->otg.notifier, status, blocking_notifier_call_chain(&twl->otg.notifier, status,
twl->otg.gadget); twl->otg.gadget);
} else { } else {
...@@ -299,7 +297,6 @@ static irqreturn_t twl6030_usbotg_irq(int irq, void *_twl) ...@@ -299,7 +297,6 @@ static irqreturn_t twl6030_usbotg_irq(int irq, void *_twl)
0x1); 0x1);
} }
twl6030_writeb(twl, TWL_MODULE_USB, USB_ID_INT_LATCH_CLR, status); twl6030_writeb(twl, TWL_MODULE_USB, USB_ID_INT_LATCH_CLR, status);
twl->linkstat = status;
return IRQ_HANDLED; return IRQ_HANDLED;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment