Commit 32ca98fe authored by Petr Machata's avatar Petr Machata Committed by David S. Miller

net: ip_gre: Accept IFLA_INFO_DATA-less configuration

The fix referenced below causes a crash when an ERSPAN tunnel is created
without passing IFLA_INFO_DATA. Fix by validating passed-in data in the
same way as ipgre does.

Fixes: e1f8f78f ("net: ip_gre: Separate ERSPAN newlink / changelink callbacks")
Reported-by: syzbot+1b4ebf4dae4e510dd219@syzkaller.appspotmail.com
Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 065fd83e
...@@ -1168,6 +1168,8 @@ static int erspan_netlink_parms(struct net_device *dev, ...@@ -1168,6 +1168,8 @@ static int erspan_netlink_parms(struct net_device *dev,
err = ipgre_netlink_parms(dev, data, tb, parms, fwmark); err = ipgre_netlink_parms(dev, data, tb, parms, fwmark);
if (err) if (err)
return err; return err;
if (!data)
return 0;
if (data[IFLA_GRE_ERSPAN_VER]) { if (data[IFLA_GRE_ERSPAN_VER]) {
t->erspan_ver = nla_get_u8(data[IFLA_GRE_ERSPAN_VER]); t->erspan_ver = nla_get_u8(data[IFLA_GRE_ERSPAN_VER]);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment