Commit 34d34732 authored by Shyam Saini's avatar Shyam Saini Committed by Greg Kroah-Hartman

Staging: comedi: comedi_fops.c: Fixed coding style issue

Fixed following checkpatch.pl warnings
WARNING: Prefer WRITE_ONCE(<FOO>, <BAR>) over ACCESS_ONCE(<FOO>) = <BAR>

WARNING: Prefer READ_ONCE(<FOO>) over ACCESS_ONCE(<FOO>)
Signed-off-by: default avatarShyam Saini <mayhs11saini@gmail.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 277b8613
...@@ -312,8 +312,8 @@ static void comedi_file_reset(struct file *file) ...@@ -312,8 +312,8 @@ static void comedi_file_reset(struct file *file)
} }
cfp->last_attached = dev->attached; cfp->last_attached = dev->attached;
cfp->last_detach_count = dev->detach_count; cfp->last_detach_count = dev->detach_count;
ACCESS_ONCE(cfp->read_subdev) = read_s; WRITE_ONCE(cfp->read_subdev, read_s);
ACCESS_ONCE(cfp->write_subdev) = write_s; WRITE_ONCE(cfp->write_subdev, write_s);
} }
static void comedi_file_check(struct file *file) static void comedi_file_check(struct file *file)
...@@ -331,7 +331,7 @@ static struct comedi_subdevice *comedi_file_read_subdevice(struct file *file) ...@@ -331,7 +331,7 @@ static struct comedi_subdevice *comedi_file_read_subdevice(struct file *file)
struct comedi_file *cfp = file->private_data; struct comedi_file *cfp = file->private_data;
comedi_file_check(file); comedi_file_check(file);
return ACCESS_ONCE(cfp->read_subdev); return READ_ONCE(cfp->read_subdev);
} }
static struct comedi_subdevice *comedi_file_write_subdevice(struct file *file) static struct comedi_subdevice *comedi_file_write_subdevice(struct file *file)
...@@ -339,7 +339,7 @@ static struct comedi_subdevice *comedi_file_write_subdevice(struct file *file) ...@@ -339,7 +339,7 @@ static struct comedi_subdevice *comedi_file_write_subdevice(struct file *file)
struct comedi_file *cfp = file->private_data; struct comedi_file *cfp = file->private_data;
comedi_file_check(file); comedi_file_check(file);
return ACCESS_ONCE(cfp->write_subdev); return READ_ONCE(cfp->write_subdev);
} }
static int resize_async_buffer(struct comedi_device *dev, static int resize_async_buffer(struct comedi_device *dev,
...@@ -1992,7 +1992,7 @@ static int do_setrsubd_ioctl(struct comedi_device *dev, unsigned long arg, ...@@ -1992,7 +1992,7 @@ static int do_setrsubd_ioctl(struct comedi_device *dev, unsigned long arg,
!(s_old->async->cmd.flags & CMDF_WRITE)) !(s_old->async->cmd.flags & CMDF_WRITE))
return -EBUSY; return -EBUSY;
ACCESS_ONCE(cfp->read_subdev) = s_new; WRITE_ONCE(cfp->read_subdev, s_new);
return 0; return 0;
} }
...@@ -2034,7 +2034,7 @@ static int do_setwsubd_ioctl(struct comedi_device *dev, unsigned long arg, ...@@ -2034,7 +2034,7 @@ static int do_setwsubd_ioctl(struct comedi_device *dev, unsigned long arg,
(s_old->async->cmd.flags & CMDF_WRITE)) (s_old->async->cmd.flags & CMDF_WRITE))
return -EBUSY; return -EBUSY;
ACCESS_ONCE(cfp->write_subdev) = s_new; WRITE_ONCE(cfp->write_subdev, s_new);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment