Commit 3608c66c authored by Vivek Kutal's avatar Vivek Kutal Committed by Linus Torvalds

fbdev: *bfin*: drop unnecessary calls to memset

The dma_alloc_* functions sets the memory to 0 before returning so there
is no need to call memset after the allocation.  Also no point in clearing
the memory when disabling the buffer.
Signed-off-by: default avatarVivek Kutal <vivek.kutal@azingo.com>
Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9990bfd0
...@@ -323,7 +323,6 @@ static int bfin_bf54x_fb_release(struct fb_info *info, int user) ...@@ -323,7 +323,6 @@ static int bfin_bf54x_fb_release(struct fb_info *info, int user)
bfin_write_EPPI0_CONTROL(0); bfin_write_EPPI0_CONTROL(0);
SSYNC(); SSYNC();
disable_dma(CH_EPPI0); disable_dma(CH_EPPI0);
memset(fbi->fb_buffer, 0, info->fix.smem_len);
} }
spin_unlock(&fbi->lock); spin_unlock(&fbi->lock);
...@@ -626,8 +625,6 @@ static int __init bfin_bf54x_probe(struct platform_device *pdev) ...@@ -626,8 +625,6 @@ static int __init bfin_bf54x_probe(struct platform_device *pdev)
goto out3; goto out3;
} }
memset(info->fb_buffer, 0, fbinfo->fix.smem_len);
fbinfo->screen_base = (void *)info->fb_buffer; fbinfo->screen_base = (void *)info->fb_buffer;
fbinfo->fix.smem_start = (int)info->fb_buffer; fbinfo->fix.smem_start = (int)info->fb_buffer;
......
...@@ -242,7 +242,6 @@ static int bfin_t350mcqb_fb_release(struct fb_info *info, int user) ...@@ -242,7 +242,6 @@ static int bfin_t350mcqb_fb_release(struct fb_info *info, int user)
SSYNC(); SSYNC();
disable_dma(CH_PPI); disable_dma(CH_PPI);
bfin_t350mcqb_stop_timers(); bfin_t350mcqb_stop_timers();
memset(fbi->fb_buffer, 0, info->fix.smem_len);
} }
spin_unlock(&fbi->lock); spin_unlock(&fbi->lock);
...@@ -527,8 +526,6 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev) ...@@ -527,8 +526,6 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev)
goto out3; goto out3;
} }
memset(info->fb_buffer, 0, fbinfo->fix.smem_len);
fbinfo->screen_base = (void *)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET; fbinfo->screen_base = (void *)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET;
fbinfo->fix.smem_start = (int)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET; fbinfo->fix.smem_start = (int)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment