Commit 362b87f5 authored by Jason A. Donenfeld's avatar Jason A. Donenfeld Committed by David S. Miller

netlink: use 48 byte ctx instead of 6 signed longs for callback

People are inclined to stuff random things into cb->args[n] because it
looks like an array of integers. Sometimes people even put u64s in there
with comments noting that a certain member takes up two slots. The
horror! Really this should mirror the usage of skb->cb, which are just
48 opaque bytes suitable for casting a struct. Then people can create
their usual casting macros for accessing strongly typed members of a
struct.

As a plus, this also gives us the same amount of space on 32bit and 64bit.
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 53962bce
...@@ -192,7 +192,14 @@ struct netlink_callback { ...@@ -192,7 +192,14 @@ struct netlink_callback {
bool strict_check; bool strict_check;
u16 answer_flags; u16 answer_flags;
unsigned int prev_seq, seq; unsigned int prev_seq, seq;
union {
u8 ctx[48];
/* args is deprecated. Cast a struct over ctx instead
* for proper type safety.
*/
long args[6]; long args[6];
};
}; };
struct netlink_notify { struct netlink_notify {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment