Commit 3a73e49c authored by Ben Hutchings's avatar Ben Hutchings Committed by David S. Miller

gianfar: Reject out-of-range RX NFC locations

Currently the driver only uses location values to maintain an ordered
list of filters.  Make it reject location values >= MAX_FILER_IDX
passed to the ETHTOOL_SRXCLSRLINS command, consistent with the range
it reports for the ETHTOOL_GRXCLSRLALL command.
Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
Acked-by: default avatarSebastian Pöhn <sebastian.poehn@googlemail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6386994e
...@@ -1692,8 +1692,9 @@ static int gfar_set_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd) ...@@ -1692,8 +1692,9 @@ static int gfar_set_nfc(struct net_device *dev, struct ethtool_rxnfc *cmd)
ret = gfar_set_hash_opts(priv, cmd); ret = gfar_set_hash_opts(priv, cmd);
break; break;
case ETHTOOL_SRXCLSRLINS: case ETHTOOL_SRXCLSRLINS:
if (cmd->fs.ring_cookie != RX_CLS_FLOW_DISC && if ((cmd->fs.ring_cookie != RX_CLS_FLOW_DISC &&
cmd->fs.ring_cookie >= priv->num_rx_queues) { cmd->fs.ring_cookie >= priv->num_rx_queues) ||
cmd->fs.location >= MAX_FILER_IDX) {
ret = -EINVAL; ret = -EINVAL;
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment