Commit 3ae7359c authored by Stuart Henderson's avatar Stuart Henderson Committed by Mark Brown

ASoC: wm_adsp: Don't generate kcontrols without READ flags

User space always expects to be able to read ALSA controls, so ensure
no kcontrols are generated without an appropriate READ flag. In the case
of a read of such a control zeros will be returned.
Signed-off-by: default avatarStuart Henderson <stuarth@opensource.cirrus.com>
Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20191002084240.21589-1-ckeepax@opensource.cirrus.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2bdf194e
...@@ -1259,8 +1259,7 @@ static unsigned int wmfw_convert_flags(unsigned int in, unsigned int len) ...@@ -1259,8 +1259,7 @@ static unsigned int wmfw_convert_flags(unsigned int in, unsigned int len)
} }
if (in) { if (in) {
if (in & WMFW_CTL_FLAG_READABLE) out |= rd;
out |= rd;
if (in & WMFW_CTL_FLAG_WRITEABLE) if (in & WMFW_CTL_FLAG_WRITEABLE)
out |= wr; out |= wr;
if (in & WMFW_CTL_FLAG_VOLATILE) if (in & WMFW_CTL_FLAG_VOLATILE)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment