Commit 3de27dcf authored by Joe Lawrence's avatar Joe Lawrence Committed by Michael Ellerman

powerpc/livepatch: return -ERRNO values in save_stack_trace_tsk_reliable()

To match its x86 counterpart, save_stack_trace_tsk_reliable() should
return -EINVAL in cases that it is currently returning 1.  No caller is
currently differentiating non-zero error codes, but let's keep the
arch-specific implementations consistent.
Signed-off-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 29a77bbb
...@@ -133,7 +133,7 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk, ...@@ -133,7 +133,7 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk,
if (sp < stack_page + sizeof(struct thread_struct) || if (sp < stack_page + sizeof(struct thread_struct) ||
sp > stack_end - STACK_FRAME_MIN_SIZE) { sp > stack_end - STACK_FRAME_MIN_SIZE) {
return 1; return -EINVAL;
} }
for (firstframe = true; sp != stack_end; for (firstframe = true; sp != stack_end;
...@@ -143,16 +143,16 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk, ...@@ -143,16 +143,16 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk,
/* sanity check: ABI requires SP to be aligned 16 bytes. */ /* sanity check: ABI requires SP to be aligned 16 bytes. */
if (sp & 0xF) if (sp & 0xF)
return 1; return -EINVAL;
newsp = stack[0]; newsp = stack[0];
/* Stack grows downwards; unwinder may only go up. */ /* Stack grows downwards; unwinder may only go up. */
if (newsp <= sp) if (newsp <= sp)
return 1; return -EINVAL;
if (newsp != stack_end && if (newsp != stack_end &&
newsp > stack_end - STACK_FRAME_MIN_SIZE) { newsp > stack_end - STACK_FRAME_MIN_SIZE) {
return 1; /* invalid backlink, too far up. */ return -EINVAL; /* invalid backlink, too far up. */
} }
/* /*
...@@ -166,13 +166,13 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk, ...@@ -166,13 +166,13 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk,
/* Mark stacktraces with exception frames as unreliable. */ /* Mark stacktraces with exception frames as unreliable. */
if (sp <= stack_end - STACK_INT_FRAME_SIZE && if (sp <= stack_end - STACK_INT_FRAME_SIZE &&
stack[STACK_FRAME_MARKER] == STACK_FRAME_REGS_MARKER) { stack[STACK_FRAME_MARKER] == STACK_FRAME_REGS_MARKER) {
return 1; return -EINVAL;
} }
/* Examine the saved LR: it must point into kernel code. */ /* Examine the saved LR: it must point into kernel code. */
ip = stack[STACK_FRAME_LR_SAVE]; ip = stack[STACK_FRAME_LR_SAVE];
if (!__kernel_text_address(ip)) if (!__kernel_text_address(ip))
return 1; return -EINVAL;
/* /*
* FIXME: IMHO these tests do not belong in * FIXME: IMHO these tests do not belong in
...@@ -185,7 +185,7 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk, ...@@ -185,7 +185,7 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk,
* as unreliable. * as unreliable.
*/ */
if (ip == (unsigned long)kretprobe_trampoline) if (ip == (unsigned long)kretprobe_trampoline)
return 1; return -EINVAL;
#endif #endif
if (trace->nr_entries >= trace->max_entries) if (trace->nr_entries >= trace->max_entries)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment