Commit 3f3e7c6e authored by Ben Nizette's avatar Ben Nizette Committed by Dmitry Torokhov

Input: ads7846 - fix unsafe disable_irq

The use of disable_irq inside the handler for the interrupt being
disabled has always been dangerous.  disable_irq should wait for that
handler to complete before returning -> deadlock.

For some reason this wasn't actually the case until 3aa551c9 was merged
but since this time, the ads7846 driver has deadlocked the system on
first interrupt.

Convert the driver to use the handler-safe _nosync variant.
Signed-off-by: default avatarBen Nizette <bn@niasdigital.com>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent 180deb50
...@@ -754,7 +754,7 @@ static irqreturn_t ads7846_irq(int irq, void *handle) ...@@ -754,7 +754,7 @@ static irqreturn_t ads7846_irq(int irq, void *handle)
* that here. (The "generic irq" framework may help...) * that here. (The "generic irq" framework may help...)
*/ */
ts->irq_disabled = 1; ts->irq_disabled = 1;
disable_irq(ts->spi->irq); disable_irq_nosync(ts->spi->irq);
ts->pending = 1; ts->pending = 1;
hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_DELAY), hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_DELAY),
HRTIMER_MODE_REL); HRTIMER_MODE_REL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment