Commit 40836c48 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds

serial_8250: pci_enable_device fail is not fully handled

<rmk> talking about leaks - I noticed that the 'check return of
pci_enable_dev()' in the 8250 pci resume function finally made it in
despite my objections against it (causing stuff in higher levels to
leak).
Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 43b11d33
...@@ -2041,9 +2041,9 @@ static int pciserial_resume_one(struct pci_dev *dev) ...@@ -2041,9 +2041,9 @@ static int pciserial_resume_one(struct pci_dev *dev)
* The device may have been disabled. Re-enable it. * The device may have been disabled. Re-enable it.
*/ */
err = pci_enable_device(dev); err = pci_enable_device(dev);
/* FIXME: We cannot simply error out here */
if (err) if (err)
return err; printk(KERN_ERR "pciserial: Unable to re-enable ports, trying to continue.\n");
pciserial_resume_ports(priv); pciserial_resume_ports(priv);
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment