Commit 41d529d6 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Wolfram Sang

i2c: exynos5: Remove IRQF_ONESHOT

The drivers sets IRQF_ONESHOT and passes only a primary handler. The IRQ
is masked while the primary is handler is invoked independently of
IRQF_ONESHOT.
With IRQF_ONESHOT the core code will not force-thread the interrupt and
this is probably not intended. I *assume* that the original author copied
the IRQ registration from another driver which passed a primary and
secondary handler and removed the secondary handler but keeping the
ONESHOT flag.

Remove IRQF_ONESHOT.
Reported-by: default avatarBenjamin Rouxel <benjamin.rouxel@uva.nl>
Tested-by: default avatarBenjamin Rouxel <benjamin.rouxel@uva.nl>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Acked-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 2252c317
...@@ -791,9 +791,7 @@ static int exynos5_i2c_probe(struct platform_device *pdev) ...@@ -791,9 +791,7 @@ static int exynos5_i2c_probe(struct platform_device *pdev)
} }
ret = devm_request_irq(&pdev->dev, i2c->irq, exynos5_i2c_irq, ret = devm_request_irq(&pdev->dev, i2c->irq, exynos5_i2c_irq,
IRQF_NO_SUSPEND | IRQF_ONESHOT, IRQF_NO_SUSPEND, dev_name(&pdev->dev), i2c);
dev_name(&pdev->dev), i2c);
if (ret != 0) { if (ret != 0) {
dev_err(&pdev->dev, "cannot request HS-I2C IRQ %d\n", i2c->irq); dev_err(&pdev->dev, "cannot request HS-I2C IRQ %d\n", i2c->irq);
goto err_clk; goto err_clk;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment