Commit 428560e7 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo

perf tools: Fix report -F mispredict for data without branch info

The branch field sorting code assumes hist_entry::branch_info is
allocated, which is wrong and following perf session ends up with report
segfault.

  $ perf record ls
  $ perf report -F mispredict
  perf: Segmentation fault

Checking that hist_entry::branch_info is valid and display "N/A" string
in snprint callback if it's not.
Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1413468427-31049-4-git-send-email-jolsa@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0199d244
...@@ -471,11 +471,13 @@ struct sort_entry sort_sym_to = { ...@@ -471,11 +471,13 @@ struct sort_entry sort_sym_to = {
static int64_t static int64_t
sort__mispredict_cmp(struct hist_entry *left, struct hist_entry *right) sort__mispredict_cmp(struct hist_entry *left, struct hist_entry *right)
{ {
const unsigned char mp = left->branch_info->flags.mispred != unsigned char mp, p;
right->branch_info->flags.mispred;
const unsigned char p = left->branch_info->flags.predicted !=
right->branch_info->flags.predicted;
if (!left->branch_info || !right->branch_info)
return cmp_null(left->branch_info, right->branch_info);
mp = left->branch_info->flags.mispred != right->branch_info->flags.mispred;
p = left->branch_info->flags.predicted != right->branch_info->flags.predicted;
return mp || p; return mp || p;
} }
...@@ -483,10 +485,12 @@ static int hist_entry__mispredict_snprintf(struct hist_entry *he, char *bf, ...@@ -483,10 +485,12 @@ static int hist_entry__mispredict_snprintf(struct hist_entry *he, char *bf,
size_t size, unsigned int width){ size_t size, unsigned int width){
static const char *out = "N/A"; static const char *out = "N/A";
if (he->branch_info) {
if (he->branch_info->flags.predicted) if (he->branch_info->flags.predicted)
out = "N"; out = "N";
else if (he->branch_info->flags.mispred) else if (he->branch_info->flags.mispred)
out = "Y"; out = "Y";
}
return repsep_snprintf(bf, size, "%-*.*s", width, width, out); return repsep_snprintf(bf, size, "%-*.*s", width, width, out);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment