Commit 434ac4d5 authored by Colin Ian King's avatar Colin Ian King Committed by Bjorn Andersson

remoteproc/mediatek: fix null pointer dereference on null scp pointer

Currently when pointer scp is null a dev_err is being called that
references the pointer which is the very thing we are trying to
avoid doing. Remove the extraneous error message to avoid this
issue.

Addresses-Coverity: ("Dereference after null check")
Fixes: 63c13d61 ("remoteproc/mediatek: add SCP support for mt8183")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200918152428.27258-1-colin.king@canonical.comSigned-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent cb2d8d5b
...@@ -30,10 +30,8 @@ int scp_ipi_register(struct mtk_scp *scp, ...@@ -30,10 +30,8 @@ int scp_ipi_register(struct mtk_scp *scp,
scp_ipi_handler_t handler, scp_ipi_handler_t handler,
void *priv) void *priv)
{ {
if (!scp) { if (!scp)
dev_err(scp->dev, "scp device is not ready\n");
return -EPROBE_DEFER; return -EPROBE_DEFER;
}
if (WARN_ON(id >= SCP_IPI_MAX) || WARN_ON(handler == NULL)) if (WARN_ON(id >= SCP_IPI_MAX) || WARN_ON(handler == NULL))
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment