Commit 43636c80 authored by Tetsuo Handa's avatar Tetsuo Handa Committed by Jens Axboe

fs: ratelimit __find_get_block_slow() failure message.

When something let __find_get_block_slow() hit all_mapped path, it calls
printk() for 100+ times per a second. But there is no need to print same
message with such high frequency; it is just asking for stall warning, or
at least bloating log files.

  [  399.866302][T15342] __find_get_block_slow() failed. block=1, b_blocknr=8
  [  399.873324][T15342] b_state=0x00000029, b_size=512
  [  399.878403][T15342] device loop0 blocksize: 4096
  [  399.883296][T15342] __find_get_block_slow() failed. block=1, b_blocknr=8
  [  399.890400][T15342] b_state=0x00000029, b_size=512
  [  399.895595][T15342] device loop0 blocksize: 4096
  [  399.900556][T15342] __find_get_block_slow() failed. block=1, b_blocknr=8
  [  399.907471][T15342] b_state=0x00000029, b_size=512
  [  399.912506][T15342] device loop0 blocksize: 4096

This patch reduces frequency to up to once per a second, in addition to
concatenating three lines into one.

  [  399.866302][T15342] __find_get_block_slow() failed. block=1, b_blocknr=8, b_state=0x00000029, b_size=512, device loop0 blocksize: 4096
Signed-off-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Cc: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 30363d65
...@@ -200,6 +200,7 @@ __find_get_block_slow(struct block_device *bdev, sector_t block) ...@@ -200,6 +200,7 @@ __find_get_block_slow(struct block_device *bdev, sector_t block)
struct buffer_head *head; struct buffer_head *head;
struct page *page; struct page *page;
int all_mapped = 1; int all_mapped = 1;
static DEFINE_RATELIMIT_STATE(last_warned, HZ, 1);
index = block >> (PAGE_SHIFT - bd_inode->i_blkbits); index = block >> (PAGE_SHIFT - bd_inode->i_blkbits);
page = find_get_page_flags(bd_mapping, index, FGP_ACCESSED); page = find_get_page_flags(bd_mapping, index, FGP_ACCESSED);
...@@ -227,15 +228,15 @@ __find_get_block_slow(struct block_device *bdev, sector_t block) ...@@ -227,15 +228,15 @@ __find_get_block_slow(struct block_device *bdev, sector_t block)
* file io on the block device and getblk. It gets dealt with * file io on the block device and getblk. It gets dealt with
* elsewhere, don't buffer_error if we had some unmapped buffers * elsewhere, don't buffer_error if we had some unmapped buffers
*/ */
if (all_mapped) { ratelimit_set_flags(&last_warned, RATELIMIT_MSG_ON_RELEASE);
printk("__find_get_block_slow() failed. " if (all_mapped && __ratelimit(&last_warned)) {
"block=%llu, b_blocknr=%llu\n", printk("__find_get_block_slow() failed. block=%llu, "
(unsigned long long)block, "b_blocknr=%llu, b_state=0x%08lx, b_size=%zu, "
(unsigned long long)bh->b_blocknr); "device %pg blocksize: %d\n",
printk("b_state=0x%08lx, b_size=%zu\n", (unsigned long long)block,
bh->b_state, bh->b_size); (unsigned long long)bh->b_blocknr,
printk("device %pg blocksize: %d\n", bdev, bh->b_state, bh->b_size, bdev,
1 << bd_inode->i_blkbits); 1 << bd_inode->i_blkbits);
} }
out_unlock: out_unlock:
spin_unlock(&bd_mapping->private_lock); spin_unlock(&bd_mapping->private_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment