Commit 4415d8a5 authored by WANG Cong's avatar WANG Cong Committed by Linus Torvalds

arch/um/os-Linux/sys-i386/task_size.c: improve a bit

Improve this code a bit: check sigaction's return value and remove a useless
fflush().
Acked-by: default avatarJeff Dike <jdike@addtoit.com>
Signed-off-by: default avatarWANG Cong <wangcong@zeuux.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 074a0db8
...@@ -88,7 +88,10 @@ unsigned long os_get_task_size(void) ...@@ -88,7 +88,10 @@ unsigned long os_get_task_size(void)
sa.sa_handler = segfault; sa.sa_handler = segfault;
sigemptyset(&sa.sa_mask); sigemptyset(&sa.sa_mask);
sa.sa_flags = SA_NODEFER; sa.sa_flags = SA_NODEFER;
sigaction(SIGSEGV, &sa, &old); if (sigaction(SIGSEGV, &sa, &old)) {
perror("os_get_task_size");
exit(1);
}
if (!page_ok(bottom)) { if (!page_ok(bottom)) {
fprintf(stderr, "Address 0x%x no good?\n", fprintf(stderr, "Address 0x%x no good?\n",
...@@ -110,11 +113,12 @@ unsigned long os_get_task_size(void) ...@@ -110,11 +113,12 @@ unsigned long os_get_task_size(void)
out: out:
/* Restore the old SIGSEGV handling */ /* Restore the old SIGSEGV handling */
sigaction(SIGSEGV, &old, NULL); if (sigaction(SIGSEGV, &old, NULL)) {
perror("os_get_task_size");
exit(1);
}
top <<= UM_KERN_PAGE_SHIFT; top <<= UM_KERN_PAGE_SHIFT;
printf("0x%x\n", top); printf("0x%x\n", top);
fflush(stdout);
return top; return top;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment