Staging: hv: cleanup coding style issues in Channel.h

Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/staging/hv/Channel.c

@@ -159,7 +159,7 @@ VmbusChannelClearEvent(
 	Retrieve various channel debug info
 
 --*/
-static void
+void
 VmbusChannelGetDebugInfo(
 	VMBUS_CHANNEL				*Channel,
 	VMBUS_CHANNEL_DEBUG_INFO	*DebugInfo
@@ -203,7 +203,7 @@ VmbusChannelGetDebugInfo(
 	Open the specified channel.
 
 --*/
-static int
+int
 VmbusChannelOpen(
 	VMBUS_CHANNEL			*NewChannel,
 	u32					SendRingBufferSize,
@@ -516,7 +516,7 @@ VmbusChannelCreateGpadlHeader(
 	Estabish a GPADL for the specified buffer
 
 --*/
-static int
+int
 VmbusChannelEstablishGpadl(
 	VMBUS_CHANNEL	*Channel,
 	void *			Kbuffer,	/* from kmalloc() */
@@ -621,7 +621,7 @@ VmbusChannelEstablishGpadl(
 	Teardown the specified GPADL handle
 
 --*/
-static int
+int
 VmbusChannelTeardownGpadl(
 	VMBUS_CHANNEL	*Channel,
 	u32			GpadlHandle
@@ -682,7 +682,7 @@ VmbusChannelTeardownGpadl(
 	Close the specified channel
 
 --*/
-static void
+void
 VmbusChannelClose(
 	VMBUS_CHANNEL	*Channel
 	)
@@ -759,7 +759,7 @@ VmbusChannelClose(
 	Send the specified buffer on the given channel
 
 --*/
-static int
+int
 VmbusChannelSendPacket(
 	VMBUS_CHANNEL		*Channel,
 	const void *			Buffer,
@@ -821,7 +821,7 @@ VmbusChannelSendPacket(
 	Send a range of single-page buffer packets using a GPADL Direct packet type.
 
 --*/
-static int
+int
 VmbusChannelSendPacketPageBuffer(
 	VMBUS_CHANNEL		*Channel,
 	PAGE_BUFFER			PageBuffers[],
@@ -900,7 +900,7 @@ VmbusChannelSendPacketPageBuffer(
 	Send a multi-page buffer packet using a GPADL Direct packet type.
 
 --*/
-static int
+int
 VmbusChannelSendPacketMultiPageBuffer(
 	VMBUS_CHANNEL		*Channel,
 	MULTIPAGE_BUFFER	*MultiPageBuffer,
@@ -979,14 +979,11 @@ VmbusChannelSendPacketMultiPageBuffer(
 
 --*/
 /* TODO: Do we ever receive a gpa direct packet other than the ones we send ? */
-static int
-VmbusChannelRecvPacket(
-	VMBUS_CHANNEL		*Channel,
-	void *				Buffer,
+int VmbusChannelRecvPacket(VMBUS_CHANNEL *Channel,
+			   void *Buffer,
 			   u32 BufferLen,
-	u32*				BufferActualLen,
-	u64*				RequestId
-	)
+			   u32 *BufferActualLen,
+			   u64 *RequestId)
 {
 	VMPACKET_DESCRIPTOR desc;
 	u32 packetLen;
@@ -1057,7 +1054,7 @@ VmbusChannelRecvPacket(
 	Retrieve the raw packet on the specified channel
 
 --*/
-static int
+int
 VmbusChannelRecvPacketRaw(
 	VMBUS_CHANNEL		*Channel,
 	void *				Buffer,
@@ -1134,10 +1131,7 @@ VmbusChannelRecvPacketRaw(
 	Channel event callback
 
 --*/
-static void
-VmbusChannelOnChannelEvent(
-	VMBUS_CHANNEL		*Channel
-	)
+void VmbusChannelOnChannelEvent(VMBUS_CHANNEL *Channel)
 {
 	DumpVmbusChannel(Channel);
 	ASSERT(Channel->OnChannelCallback);
@@ -1160,7 +1154,7 @@ VmbusChannelOnChannelEvent(
 	Timer event callback
 
 --*/
-static void VmbusChannelOnTimer(unsigned long data)
+void VmbusChannelOnTimer(unsigned long data)
 {
 	VMBUS_CHANNEL *channel = (VMBUS_CHANNEL*)data;
 

drivers/staging/hv/Channel.h

@@ -28,9 +28,6 @@
 #include "include/osd.h"
 #include "ChannelMgmt.h"
 
-#pragma pack(push,1)
-
-
 /* The format must be the same as VMDATA_GPA_DIRECT */
 struct VMBUS_CHANNEL_PACKET_PAGE_BUFFER {
 	u16 Type;
@@ -41,8 +38,7 @@ struct VMBUS_CHANNEL_PACKET_PAGE_BUFFER {
 	u32 Reserved;
 	u32 RangeCount;
 	PAGE_BUFFER Range[MAX_PAGE_BUFFER_COUNT];
-};
-
+} __attribute__((packed));
 
 /* The format must be the same as VMDATA_GPA_DIRECT */
 struct VMBUS_CHANNEL_PACKET_MULITPAGE_BUFFER {
@@ -54,101 +50,64 @@ struct VMBUS_CHANNEL_PACKET_MULITPAGE_BUFFER {
 	u32 Reserved;
 	u32 RangeCount;		/* Always 1 in this case */
 	MULTIPAGE_BUFFER Range;
-};
-
-#pragma pack(pop)
+} __attribute__((packed));
 
 
-/* Routines */
-
-
-static int
-VmbusChannelOpen(
-	VMBUS_CHANNEL			*Channel,
+extern int VmbusChannelOpen(VMBUS_CHANNEL *Channel,
 			    u32 SendRingBufferSize,
 			    u32 RecvRingBufferSize,
-	void *					UserData,
+			    void *UserData,
 			    u32 UserDataLen,
 			    PFN_CHANNEL_CALLBACK pfnOnChannelCallback,
-	void *					Context
-	);
-
-static void
-VmbusChannelClose(
-	VMBUS_CHANNEL		*Channel
-	);
-
-static int
-VmbusChannelSendPacket(
-	VMBUS_CHANNEL		*Channel,
-	const void *			Buffer,
+			    void *Context);
+
+extern void VmbusChannelClose(VMBUS_CHANNEL *Channel);
+
+extern int VmbusChannelSendPacket(VMBUS_CHANNEL *Channel,
+				  const void *Buffer,
 				  u32 BufferLen,
 				  u64 RequestId,
 				  VMBUS_PACKET_TYPE Type,
-	u32				Flags
-);
+				  u32 Flags);
 
-static int
-VmbusChannelSendPacketPageBuffer(
-	VMBUS_CHANNEL		*Channel,
+extern int VmbusChannelSendPacketPageBuffer(VMBUS_CHANNEL *Channel,
 					    PAGE_BUFFER PageBuffers[],
 					    u32 PageCount,
-	void *				Buffer,
+					    void *Buffer,
 					    u32 BufferLen,
-	u64				RequestId
-	);
+					    u64 RequestId);
 
-static int
-VmbusChannelSendPacketMultiPageBuffer(
-	VMBUS_CHANNEL		*Channel,
+extern int VmbusChannelSendPacketMultiPageBuffer(VMBUS_CHANNEL *Channel,
 					MULTIPAGE_BUFFER *MultiPageBuffer,
-	void *				Buffer,
+					void *Buffer,
 					u32 BufferLen,
-	u64				RequestId
-);
-
-static int
-VmbusChannelEstablishGpadl(
-	VMBUS_CHANNEL		*Channel,
-	void *				Kbuffer,	/* from kmalloc() */
-	u32				Size,		/* page-size multiple */
-	u32				*GpadlHandle
-	);
-
-static int
-VmbusChannelTeardownGpadl(
-	VMBUS_CHANNEL	*Channel,
-	u32			GpadlHandle
-	);
-
-static int
-VmbusChannelRecvPacket(
-	VMBUS_CHANNEL		*Channel,
-	void *				Buffer,
+					u64 RequestId);
+
+extern int VmbusChannelEstablishGpadl(VMBUS_CHANNEL *Channel,
+				      void *Kbuffer,
+				      u32 Size,
+				      u32 *GpadlHandle);
+
+extern int VmbusChannelTeardownGpadl(VMBUS_CHANNEL *Channel,
+				     u32 GpadlHandle);
+
+extern int VmbusChannelRecvPacket(VMBUS_CHANNEL *Channel,
+				  void *Buffer,
 				  u32 BufferLen,
-	u32*				BufferActualLen,
-	u64*				RequestId
-	);
-
-static int
-VmbusChannelRecvPacketRaw(
-	VMBUS_CHANNEL		*Channel,
-	void *				Buffer,
+				  u32 *BufferActualLen,
+				  u64 *RequestId);
+
+extern int VmbusChannelRecvPacketRaw(VMBUS_CHANNEL *Channel,
+				     void *Buffer,
 				     u32 BufferLen,
-	u32*				BufferActualLen,
-	u64*				RequestId
-	);
-
-static void
-VmbusChannelOnChannelEvent(
-	VMBUS_CHANNEL		*Channel
-	);
-
-static void
-VmbusChannelGetDebugInfo(
-	VMBUS_CHANNEL				*Channel,
-	VMBUS_CHANNEL_DEBUG_INFO	*DebugInfo
-	);
-
-static void VmbusChannelOnTimer(unsigned long data);
+				     u32 *BufferActualLen,
+				     u64 *RequestId);
+
+extern void VmbusChannelOnChannelEvent(VMBUS_CHANNEL *Channel);
+
+extern void VmbusChannelGetDebugInfo(VMBUS_CHANNEL *Channel,
+				     VMBUS_CHANNEL_DEBUG_INFO *DebugInfo);
+
+extern void VmbusChannelOnTimer(unsigned long data);
+
 #endif /* _CHANNEL_H_ */