Commit 47f2c360 authored by David S. Miller's avatar David S. Miller

[SPARC64]: Fix X server hangs due to large pages.

This problem was introduced by changeset
14778d90

Unlike the hugetlb code paths, the normal fault code is not setup to
propagate PTE changes for large page sizes correctly like the ones we
make for I/O mappings in io_remap_pfn_range().

It is absolutely necessary to update all sub-ptes of a largepage
mapping on a fault.  Adding special handling for this would add
considerably complexity to tlb_batch_add().  So let's just side-step
the issue and forcefully dirty any writable PTEs created by
io_remap_pfn_range().

The only other real option would be to disable to large PTE code of
io_remap_pfn_range() and we really don't want to do that.

Much thanks to Mikael Pettersson for tracking down this problem and
testing debug patches.
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dc709bd1
...@@ -69,6 +69,8 @@ static inline void io_remap_pte_range(struct mm_struct *mm, pte_t * pte, ...@@ -69,6 +69,8 @@ static inline void io_remap_pte_range(struct mm_struct *mm, pte_t * pte,
} else } else
offset += PAGE_SIZE; offset += PAGE_SIZE;
if (pte_write(entry))
entry = pte_mkdirty(entry);
do { do {
BUG_ON(!pte_none(*pte)); BUG_ON(!pte_none(*pte));
set_pte_at(mm, address, pte, entry); set_pte_at(mm, address, pte, entry);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment