Commit 48e71241 authored by Elena Oat's avatar Elena Oat Committed by Greg Kroah-Hartman

Staging: rtl8188eu: Fix warning of prefer ether_addr_copy().

This patch fixes the warning produced by checkpatch "Prefer
ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)". The address that is copied is a field of
nat25_network_db_entry structure. Definition for this struct is found in
rtw_br_ext.h file. Pahole shows that the addresses are 2-byte aligned.
Signed-off-by: default avatarElena Oat <oat.elena@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2c05f00f
...@@ -409,7 +409,7 @@ static void __nat25_db_network_insert(struct adapter *priv, ...@@ -409,7 +409,7 @@ static void __nat25_db_network_insert(struct adapter *priv,
db = priv->nethash[hash]; db = priv->nethash[hash];
while (db != NULL) { while (db != NULL) {
if (!memcmp(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN)) { if (!memcmp(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN)) {
memcpy(db->macAddr, macAddr, ETH_ALEN); ether_addr_copy(db->macAddr, macAddr);
db->ageing_timer = jiffies; db->ageing_timer = jiffies;
spin_unlock_bh(&priv->br_ext_lock); spin_unlock_bh(&priv->br_ext_lock);
return; return;
...@@ -422,7 +422,7 @@ static void __nat25_db_network_insert(struct adapter *priv, ...@@ -422,7 +422,7 @@ static void __nat25_db_network_insert(struct adapter *priv,
return; return;
} }
memcpy(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN); memcpy(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN);
memcpy(db->macAddr, macAddr, ETH_ALEN); ether_addr_copy(db->macAddr, macAddr);
atomic_set(&db->use_count, 1); atomic_set(&db->use_count, 1);
db->ageing_timer = jiffies; db->ageing_timer = jiffies;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment