Commit 49ba8781 authored by J. Bruce Fields's avatar J. Bruce Fields

nfsd: eliminate final bogus case from setclientid logic

We're supposed to generate a different cl_confirm verifier for each new
client, so these to cl_confirm values should never be the same.
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
parent a186e767
...@@ -769,7 +769,7 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, ...@@ -769,7 +769,7 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
if (new == NULL) if (new == NULL)
goto out; goto out;
gen_clid(new); gen_clid(new);
} else if (!same_verf(&conf->cl_confirm, &unconf->cl_confirm)) { } else {
/* /*
* RFC 3530 14.2.33 CASE 3: * RFC 3530 14.2.33 CASE 3:
* probable client reboot; state will be removed if * probable client reboot; state will be removed if
...@@ -780,11 +780,6 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, ...@@ -780,11 +780,6 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
if (new == NULL) if (new == NULL)
goto out; goto out;
gen_clid(new); gen_clid(new);
} else {
/* No cases hit !!! */
status = nfserr_inval;
goto out;
} }
copy_verf(new, &clverifier); copy_verf(new, &clverifier);
new->cl_addr = sin->sin_addr.s_addr; new->cl_addr = sin->sin_addr.s_addr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment