Commit 4a7ce90c authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

USB: ti_usb_3410_5052.c: remove dbg() tracing calls

dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Adhir Ramjiawan <adhirramjiawan0@gmail.com>
CC: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b6b6df8a
...@@ -465,8 +465,6 @@ static void ti_release(struct usb_serial *serial) ...@@ -465,8 +465,6 @@ static void ti_release(struct usb_serial *serial)
struct ti_device *tdev = usb_get_serial_data(serial); struct ti_device *tdev = usb_get_serial_data(serial);
struct ti_port *tport; struct ti_port *tport;
dbg("%s", __func__);
for (i = 0; i < serial->num_ports; ++i) { for (i = 0; i < serial->num_ports; ++i) {
tport = usb_get_serial_port_data(serial->port[i]); tport = usb_get_serial_port_data(serial->port[i]);
if (tport) { if (tport) {
...@@ -491,8 +489,6 @@ static int ti_open(struct tty_struct *tty, struct usb_serial_port *port) ...@@ -491,8 +489,6 @@ static int ti_open(struct tty_struct *tty, struct usb_serial_port *port)
TI_PIPE_TIMEOUT_ENABLE | TI_PIPE_TIMEOUT_ENABLE |
(TI_TRANSFER_TIMEOUT << 2)); (TI_TRANSFER_TIMEOUT << 2));
dbg("%s - port %d", __func__, port->number);
if (tport == NULL) if (tport == NULL)
return -ENODEV; return -ENODEV;
...@@ -633,8 +629,6 @@ static void ti_close(struct usb_serial_port *port) ...@@ -633,8 +629,6 @@ static void ti_close(struct usb_serial_port *port)
int status; int status;
int do_unlock; int do_unlock;
dbg("%s - port %d", __func__, port->number);
tdev = usb_get_serial_data(port->serial); tdev = usb_get_serial_data(port->serial);
tport = usb_get_serial_port_data(port); tport = usb_get_serial_port_data(port);
if (tdev == NULL || tport == NULL) if (tdev == NULL || tport == NULL)
...@@ -668,8 +662,6 @@ static void ti_close(struct usb_serial_port *port) ...@@ -668,8 +662,6 @@ static void ti_close(struct usb_serial_port *port)
} }
if (do_unlock) if (do_unlock)
mutex_unlock(&tdev->td_open_close_lock); mutex_unlock(&tdev->td_open_close_lock);
dbg("%s - exit", __func__);
} }
...@@ -678,8 +670,6 @@ static int ti_write(struct tty_struct *tty, struct usb_serial_port *port, ...@@ -678,8 +670,6 @@ static int ti_write(struct tty_struct *tty, struct usb_serial_port *port,
{ {
struct ti_port *tport = usb_get_serial_port_data(port); struct ti_port *tport = usb_get_serial_port_data(port);
dbg("%s - port %d", __func__, port->number);
if (count == 0) { if (count == 0) {
dbg("%s - write request of 0 bytes", __func__); dbg("%s - write request of 0 bytes", __func__);
return 0; return 0;
...@@ -703,8 +693,6 @@ static int ti_write_room(struct tty_struct *tty) ...@@ -703,8 +693,6 @@ static int ti_write_room(struct tty_struct *tty)
int room = 0; int room = 0;
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
if (tport == NULL) if (tport == NULL)
return 0; return 0;
...@@ -724,8 +712,6 @@ static int ti_chars_in_buffer(struct tty_struct *tty) ...@@ -724,8 +712,6 @@ static int ti_chars_in_buffer(struct tty_struct *tty)
int chars = 0; int chars = 0;
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
if (tport == NULL) if (tport == NULL)
return 0; return 0;
...@@ -743,8 +729,6 @@ static void ti_throttle(struct tty_struct *tty) ...@@ -743,8 +729,6 @@ static void ti_throttle(struct tty_struct *tty)
struct usb_serial_port *port = tty->driver_data; struct usb_serial_port *port = tty->driver_data;
struct ti_port *tport = usb_get_serial_port_data(port); struct ti_port *tport = usb_get_serial_port_data(port);
dbg("%s - port %d", __func__, port->number);
if (tport == NULL) if (tport == NULL)
return; return;
...@@ -760,8 +744,6 @@ static void ti_unthrottle(struct tty_struct *tty) ...@@ -760,8 +744,6 @@ static void ti_unthrottle(struct tty_struct *tty)
struct ti_port *tport = usb_get_serial_port_data(port); struct ti_port *tport = usb_get_serial_port_data(port);
int status; int status;
dbg("%s - port %d", __func__, port->number);
if (tport == NULL) if (tport == NULL)
return; return;
...@@ -856,8 +838,6 @@ static void ti_set_termios(struct tty_struct *tty, ...@@ -856,8 +838,6 @@ static void ti_set_termios(struct tty_struct *tty,
int port_number = port->number - port->serial->minor; int port_number = port->number - port->serial->minor;
unsigned int mcr; unsigned int mcr;
dbg("%s - port %d", __func__, port->number);
cflag = tty->termios->c_cflag; cflag = tty->termios->c_cflag;
iflag = tty->termios->c_iflag; iflag = tty->termios->c_iflag;
...@@ -990,8 +970,6 @@ static int ti_tiocmget(struct tty_struct *tty) ...@@ -990,8 +970,6 @@ static int ti_tiocmget(struct tty_struct *tty)
unsigned int mcr; unsigned int mcr;
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
if (tport == NULL) if (tport == NULL)
return -ENODEV; return -ENODEV;
...@@ -1022,8 +1000,6 @@ static int ti_tiocmset(struct tty_struct *tty, ...@@ -1022,8 +1000,6 @@ static int ti_tiocmset(struct tty_struct *tty,
unsigned int mcr; unsigned int mcr;
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
if (tport == NULL) if (tport == NULL)
return -ENODEV; return -ENODEV;
...@@ -1086,8 +1062,6 @@ static void ti_interrupt_callback(struct urb *urb) ...@@ -1086,8 +1062,6 @@ static void ti_interrupt_callback(struct urb *urb)
int retval; int retval;
__u8 msr; __u8 msr;
dbg("%s", __func__);
switch (status) { switch (status) {
case 0: case 0:
break; break;
...@@ -1167,8 +1141,6 @@ static void ti_bulk_in_callback(struct urb *urb) ...@@ -1167,8 +1141,6 @@ static void ti_bulk_in_callback(struct urb *urb)
int retval = 0; int retval = 0;
struct tty_struct *tty; struct tty_struct *tty;
dbg("%s", __func__);
switch (status) { switch (status) {
case 0: case 0:
break; break;
...@@ -1235,8 +1207,6 @@ static void ti_bulk_out_callback(struct urb *urb) ...@@ -1235,8 +1207,6 @@ static void ti_bulk_out_callback(struct urb *urb)
struct usb_serial_port *port = tport->tp_port; struct usb_serial_port *port = tport->tp_port;
int status = urb->status; int status = urb->status;
dbg("%s - port %d", __func__, port->number);
tport->tp_write_urb_in_use = 0; tport->tp_write_urb_in_use = 0;
switch (status) { switch (status) {
...@@ -1289,9 +1259,6 @@ static void ti_send(struct ti_port *tport) ...@@ -1289,9 +1259,6 @@ static void ti_send(struct ti_port *tport)
struct tty_struct *tty = tty_port_tty_get(&port->port); /* FIXME */ struct tty_struct *tty = tty_port_tty_get(&port->port); /* FIXME */
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&tport->tp_lock, flags); spin_lock_irqsave(&tport->tp_lock, flags);
if (tport->tp_write_urb_in_use) if (tport->tp_write_urb_in_use)
...@@ -1368,8 +1335,6 @@ static int ti_get_lsr(struct ti_port *tport) ...@@ -1368,8 +1335,6 @@ static int ti_get_lsr(struct ti_port *tport)
int port_number = port->number - port->serial->minor; int port_number = port->number - port->serial->minor;
struct ti_port_status *data; struct ti_port_status *data;
dbg("%s - port %d", __func__, port->number);
size = sizeof(struct ti_port_status); size = sizeof(struct ti_port_status);
data = kmalloc(size, GFP_KERNEL); data = kmalloc(size, GFP_KERNEL);
if (!data) { if (!data) {
...@@ -1482,8 +1447,6 @@ static void ti_drain(struct ti_port *tport, unsigned long timeout, int flush) ...@@ -1482,8 +1447,6 @@ static void ti_drain(struct ti_port *tport, unsigned long timeout, int flush)
struct usb_serial_port *port = tport->tp_port; struct usb_serial_port *port = tport->tp_port;
wait_queue_t wait; wait_queue_t wait;
dbg("%s - port %d", __func__, port->number);
spin_lock_irq(&tport->tp_lock); spin_lock_irq(&tport->tp_lock);
/* wait for data to drain from the buffer */ /* wait for data to drain from the buffer */
...@@ -1681,7 +1644,6 @@ static int ti_download_firmware(struct ti_device *tdev) ...@@ -1681,7 +1644,6 @@ static int ti_download_firmware(struct ti_device *tdev)
const struct firmware *fw_p; const struct firmware *fw_p;
char buf[32]; char buf[32];
dbg("%s\n", __func__);
/* try ID specific firmware first, then try generic firmware */ /* try ID specific firmware first, then try generic firmware */
sprintf(buf, "ti_usb-v%04x-p%04x.fw", dev->descriptor.idVendor, sprintf(buf, "ti_usb-v%04x-p%04x.fw", dev->descriptor.idVendor,
dev->descriptor.idProduct); dev->descriptor.idProduct);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment