Commit 4b40b225 authored by Tomas Winkler's avatar Tomas Winkler Committed by Greg Kroah-Hartman

mei: client: use sizeof of variable instead of struct type

There is a possibility of bug when variable type has changed but
corresponding struct passed to the sizeof has not.

Cc: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20200723145927.882743-5-tomas.winkler@intel.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 71ae5255
// SPDX-License-Identifier: GPL-2.0 // SPDX-License-Identifier: GPL-2.0
/* /*
* Copyright (c) 2003-2019, Intel Corporation. All rights reserved. * Copyright (c) 2003-2020, Intel Corporation. All rights reserved.
* Intel Management Engine Interface (Intel MEI) Linux driver * Intel Management Engine Interface (Intel MEI) Linux driver
*/ */
...@@ -369,7 +369,7 @@ static struct mei_cl_cb *mei_io_cb_init(struct mei_cl *cl, ...@@ -369,7 +369,7 @@ static struct mei_cl_cb *mei_io_cb_init(struct mei_cl *cl,
{ {
struct mei_cl_cb *cb; struct mei_cl_cb *cb;
cb = kzalloc(sizeof(struct mei_cl_cb), GFP_KERNEL); cb = kzalloc(sizeof(*cb), GFP_KERNEL);
if (!cb) if (!cb)
return NULL; return NULL;
...@@ -552,7 +552,7 @@ int mei_cl_flush_queues(struct mei_cl *cl, const struct file *fp) ...@@ -552,7 +552,7 @@ int mei_cl_flush_queues(struct mei_cl *cl, const struct file *fp)
*/ */
static void mei_cl_init(struct mei_cl *cl, struct mei_device *dev) static void mei_cl_init(struct mei_cl *cl, struct mei_device *dev)
{ {
memset(cl, 0, sizeof(struct mei_cl)); memset(cl, 0, sizeof(*cl));
init_waitqueue_head(&cl->wait); init_waitqueue_head(&cl->wait);
init_waitqueue_head(&cl->rx_wait); init_waitqueue_head(&cl->rx_wait);
init_waitqueue_head(&cl->tx_wait); init_waitqueue_head(&cl->tx_wait);
...@@ -575,7 +575,7 @@ struct mei_cl *mei_cl_allocate(struct mei_device *dev) ...@@ -575,7 +575,7 @@ struct mei_cl *mei_cl_allocate(struct mei_device *dev)
{ {
struct mei_cl *cl; struct mei_cl *cl;
cl = kmalloc(sizeof(struct mei_cl), GFP_KERNEL); cl = kmalloc(sizeof(*cl), GFP_KERNEL);
if (!cl) if (!cl)
return NULL; return NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment