Commit 4d900f9d authored by Patrick McHardy's avatar Patrick McHardy

netfilter: xt_rateest: fix comparison with self

As noticed by Trk Edwin <edwintorok@gmail.com>:

Compiling the kernel with clang has shown this warning:

net/netfilter/xt_rateest.c:69:16: warning: self-comparison always results in a
constant value
                        ret &= pps2 == pps2;
                                    ^
Looking at the code:
if (info->flags & XT_RATEEST_MATCH_BPS)
            ret &= bps1 == bps2;
        if (info->flags & XT_RATEEST_MATCH_PPS)
            ret &= pps2 == pps2;

Judging from the MATCH_BPS case it seems to be a typo, with the intention of
comparing pps1 with pps2.

http://bugzilla.kernel.org/show_bug.cgi?id=13535Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
parent 6d62182f
...@@ -66,7 +66,7 @@ xt_rateest_mt(const struct sk_buff *skb, const struct xt_match_param *par) ...@@ -66,7 +66,7 @@ xt_rateest_mt(const struct sk_buff *skb, const struct xt_match_param *par)
if (info->flags & XT_RATEEST_MATCH_BPS) if (info->flags & XT_RATEEST_MATCH_BPS)
ret &= bps1 == bps2; ret &= bps1 == bps2;
if (info->flags & XT_RATEEST_MATCH_PPS) if (info->flags & XT_RATEEST_MATCH_PPS)
ret &= pps2 == pps2; ret &= pps1 == pps2;
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment