Commit 4ebc7182 authored by Yong Zhao's avatar Yong Zhao Committed by Oded Gabbay

drm/amdkfd: Add more error printing to help bringup v2

v2: Turned WARN into dev_warn and made the message more helpful
Signed-off-by: default avatarYong Zhao <Yong.Zhao@amd.com>
Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
parent 32fa8219
...@@ -103,6 +103,9 @@ static const struct kfd_device_info *lookup_device_info(unsigned short did) ...@@ -103,6 +103,9 @@ static const struct kfd_device_info *lookup_device_info(unsigned short did)
} }
} }
dev_warn(kfd_device, "DID %04x is missing in supported_devices\n",
did);
return NULL; return NULL;
} }
...@@ -114,8 +117,10 @@ struct kfd_dev *kgd2kfd_probe(struct kgd_dev *kgd, ...@@ -114,8 +117,10 @@ struct kfd_dev *kgd2kfd_probe(struct kgd_dev *kgd,
const struct kfd_device_info *device_info = const struct kfd_device_info *device_info =
lookup_device_info(pdev->device); lookup_device_info(pdev->device);
if (!device_info) if (!device_info) {
dev_err(kfd_device, "kgd2kfd_probe failed\n");
return NULL; return NULL;
}
kfd = kzalloc(sizeof(*kfd), GFP_KERNEL); kfd = kzalloc(sizeof(*kfd), GFP_KERNEL);
if (!kfd) if (!kfd)
...@@ -364,8 +369,11 @@ int kgd2kfd_resume(struct kfd_dev *kfd) ...@@ -364,8 +369,11 @@ int kgd2kfd_resume(struct kfd_dev *kfd)
if (kfd->init_complete) { if (kfd->init_complete) {
err = amd_iommu_init_device(kfd->pdev, pasid_limit); err = amd_iommu_init_device(kfd->pdev, pasid_limit);
if (err < 0) if (err < 0) {
dev_err(kfd_device, "failed to initialize iommu\n");
return -ENXIO; return -ENXIO;
}
amd_iommu_set_invalidate_ctx_cb(kfd->pdev, amd_iommu_set_invalidate_ctx_cb(kfd->pdev,
iommu_pasid_shutdown_callback); iommu_pasid_shutdown_callback);
amd_iommu_set_invalid_ppr_cb(kfd->pdev, iommu_invalid_ppr_cb); amd_iommu_set_invalid_ppr_cb(kfd->pdev, iommu_invalid_ppr_cb);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment