Commit 4eebff27 authored by Konstantin Khlebnikov's avatar Konstantin Khlebnikov Committed by David S. Miller

tcp_nv: fix division by zero in tcpnv_acked()

Average RTT could become zero. This happened in real life at least twice.
This patch treats zero as 1us.
Signed-off-by: default avatarKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: default avatarLawrence Brakmo <Brakmo@fb.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3a99df9a
...@@ -252,7 +252,7 @@ static void tcpnv_acked(struct sock *sk, const struct ack_sample *sample) ...@@ -252,7 +252,7 @@ static void tcpnv_acked(struct sock *sk, const struct ack_sample *sample)
/* rate in 100's bits per second */ /* rate in 100's bits per second */
rate64 = ((u64)sample->in_flight) * 8000000; rate64 = ((u64)sample->in_flight) * 8000000;
rate = (u32)div64_u64(rate64, (u64)(avg_rtt * 100)); rate = (u32)div64_u64(rate64, (u64)(avg_rtt ?: 1) * 100);
/* Remember the maximum rate seen during this RTT /* Remember the maximum rate seen during this RTT
* Note: It may be more than one RTT. This function should be * Note: It may be more than one RTT. This function should be
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment