Commit 4ffd3c73 authored by françois romieu's avatar françois romieu Committed by David S. Miller

net: batch of last_rx update avoidance in ethernet drivers.

None of those drivers uses last_rx for its own needs.

See 4dc89133 ("net: add a comment on
netdev->last_rx") for reference.
Signed-off-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Wingman Kwok <w-kwok2@ti.com>
Cc: Murali Karicheri <m-karicheri2@ti.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7852dada
...@@ -2072,7 +2072,6 @@ static int xgbe_rx_poll(struct xgbe_channel *channel, int budget) ...@@ -2072,7 +2072,6 @@ static int xgbe_rx_poll(struct xgbe_channel *channel, int budget)
skb_record_rx_queue(skb, channel->queue_index); skb_record_rx_queue(skb, channel->queue_index);
skb_mark_napi_id(skb, napi); skb_mark_napi_id(skb, napi);
netdev->last_rx = jiffies;
napi_gro_receive(napi, skb); napi_gro_receive(napi, skb);
next_packet: next_packet:
......
...@@ -500,7 +500,6 @@ static int hix5hd2_rx(struct net_device *dev, int limit) ...@@ -500,7 +500,6 @@ static int hix5hd2_rx(struct net_device *dev, int limit)
napi_gro_receive(&priv->napi, skb); napi_gro_receive(&priv->napi, skb);
dev->stats.rx_packets++; dev->stats.rx_packets++;
dev->stats.rx_bytes += skb->len; dev->stats.rx_bytes += skb->len;
dev->last_rx = jiffies;
next: next:
pos = dma_ring_incr(pos, RX_DESC_NUM); pos = dma_ring_incr(pos, RX_DESC_NUM);
} }
......
...@@ -1688,7 +1688,6 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget) ...@@ -1688,7 +1688,6 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget)
skb_mark_napi_id(skb, &rx_ring->q_vector->napi); skb_mark_napi_id(skb, &rx_ring->q_vector->napi);
i40e_receive_skb(rx_ring, skb, vlan_tag); i40e_receive_skb(rx_ring, skb, vlan_tag);
rx_ring->netdev->last_rx = jiffies;
rx_desc->wb.qword1.status_error_len = 0; rx_desc->wb.qword1.status_error_len = 0;
} while (likely(total_rx_packets < budget)); } while (likely(total_rx_packets < budget));
...@@ -1821,7 +1820,6 @@ static int i40e_clean_rx_irq_1buf(struct i40e_ring *rx_ring, int budget) ...@@ -1821,7 +1820,6 @@ static int i40e_clean_rx_irq_1buf(struct i40e_ring *rx_ring, int budget)
#endif #endif
i40e_receive_skb(rx_ring, skb, vlan_tag); i40e_receive_skb(rx_ring, skb, vlan_tag);
rx_ring->netdev->last_rx = jiffies;
rx_desc->wb.qword1.status_error_len = 0; rx_desc->wb.qword1.status_error_len = 0;
} while (likely(total_rx_packets < budget)); } while (likely(total_rx_packets < budget));
......
...@@ -1156,7 +1156,6 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget) ...@@ -1156,7 +1156,6 @@ static int i40e_clean_rx_irq_ps(struct i40e_ring *rx_ring, int budget)
skb_mark_napi_id(skb, &rx_ring->q_vector->napi); skb_mark_napi_id(skb, &rx_ring->q_vector->napi);
i40e_receive_skb(rx_ring, skb, vlan_tag); i40e_receive_skb(rx_ring, skb, vlan_tag);
rx_ring->netdev->last_rx = jiffies;
rx_desc->wb.qword1.status_error_len = 0; rx_desc->wb.qword1.status_error_len = 0;
} while (likely(total_rx_packets < budget)); } while (likely(total_rx_packets < budget));
...@@ -1271,7 +1270,6 @@ static int i40e_clean_rx_irq_1buf(struct i40e_ring *rx_ring, int budget) ...@@ -1271,7 +1270,6 @@ static int i40e_clean_rx_irq_1buf(struct i40e_ring *rx_ring, int budget)
: 0; : 0;
i40e_receive_skb(rx_ring, skb, vlan_tag); i40e_receive_skb(rx_ring, skb, vlan_tag);
rx_ring->netdev->last_rx = jiffies;
rx_desc->wb.qword1.status_error_len = 0; rx_desc->wb.qword1.status_error_len = 0;
} while (likely(total_rx_packets < budget)); } while (likely(total_rx_packets < budget));
......
...@@ -244,7 +244,6 @@ static int moxart_rx_poll(struct napi_struct *napi, int budget) ...@@ -244,7 +244,6 @@ static int moxart_rx_poll(struct napi_struct *napi, int budget)
napi_gro_receive(&priv->napi, skb); napi_gro_receive(&priv->napi, skb);
rx++; rx++;
ndev->last_rx = jiffies;
priv->stats.rx_packets++; priv->stats.rx_packets++;
priv->stats.rx_bytes += len; priv->stats.rx_bytes += len;
if (desc0 & RX_DESC0_MULTICAST) if (desc0 & RX_DESC0_MULTICAST)
......
...@@ -698,7 +698,6 @@ static int netcp_process_one_rx_packet(struct netcp_intf *netcp) ...@@ -698,7 +698,6 @@ static int netcp_process_one_rx_packet(struct netcp_intf *netcp)
} }
} }
netcp->ndev->last_rx = jiffies;
netcp->ndev->stats.rx_packets++; netcp->ndev->stats.rx_packets++;
netcp->ndev->stats.rx_bytes += skb->len; netcp->ndev->stats.rx_bytes += skb->len;
......
...@@ -721,9 +721,6 @@ static bool tile_net_poll_aux(struct tile_net_cpu *info, int index) ...@@ -721,9 +721,6 @@ static bool tile_net_poll_aux(struct tile_net_cpu *info, int index)
if (!hash_default) if (!hash_default)
__inv_buffer(buf, len); __inv_buffer(buf, len);
/* ISSUE: Is this needed? */
dev->last_rx = jiffies;
#ifdef TILE_NET_DUMP_PACKETS #ifdef TILE_NET_DUMP_PACKETS
dump_packet(buf, len, "rx"); dump_packet(buf, len, "rx");
#endif /* TILE_NET_DUMP_PACKETS */ #endif /* TILE_NET_DUMP_PACKETS */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment