Commit 5006b313 authored by Julia Lawall's avatar Julia Lawall Committed by Mark Brown

sound/soc/ep93xx/ep93xx-i2s.c: add missing kfree

Introduce a new label that includes kfree and jump to that one.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@

(
if (...) { ... when != kfree(x)
               when != x = E3
               when != E3 = x
*  return ...;
 }
... when != x = E2
    when != I(...,x,...) S
if (...) { ... when != x = E4
 kfree(x); ... return ...; }
)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarAlexander Sverdlin <subaparts@yandex.ru>
Reviewed-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: default avatarLiam Girdwood <lrg@ti.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 96101bd0
...@@ -385,14 +385,14 @@ static int ep93xx_i2s_probe(struct platform_device *pdev) ...@@ -385,14 +385,14 @@ static int ep93xx_i2s_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) { if (!res) {
err = -ENODEV; err = -ENODEV;
goto fail; goto fail_free_info;
} }
info->mem = request_mem_region(res->start, resource_size(res), info->mem = request_mem_region(res->start, resource_size(res),
pdev->name); pdev->name);
if (!info->mem) { if (!info->mem) {
err = -EBUSY; err = -EBUSY;
goto fail; goto fail_free_info;
} }
info->regs = ioremap(info->mem->start, resource_size(info->mem)); info->regs = ioremap(info->mem->start, resource_size(info->mem));
...@@ -435,6 +435,7 @@ static int ep93xx_i2s_probe(struct platform_device *pdev) ...@@ -435,6 +435,7 @@ static int ep93xx_i2s_probe(struct platform_device *pdev)
iounmap(info->regs); iounmap(info->regs);
fail_release_mem: fail_release_mem:
release_mem_region(info->mem->start, resource_size(info->mem)); release_mem_region(info->mem->start, resource_size(info->mem));
fail_free_info:
kfree(info); kfree(info);
fail: fail:
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment