Commit 50fee1de authored by Eugene Teo's avatar Eugene Teo Committed by David S. Miller

net: amend the fix for SO_BSDCOMPAT gsopt infoleak

The fix for CVE-2009-0676 (upstream commit df0bca04) is incomplete. Note
that the same problem of leaking kernel memory will reappear if someone
on some architecture uses struct timeval with some internal padding (for
example tv_sec 64-bit and tv_usec 32-bit) --- then, you are going to
leak the padded bytes to userspace.
Signed-off-by: default avatarEugene Teo <eugeneteo@kernel.sg>
Reported-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ebe47d47
...@@ -696,7 +696,7 @@ int sock_getsockopt(struct socket *sock, int level, int optname, ...@@ -696,7 +696,7 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
if (len < 0) if (len < 0)
return -EINVAL; return -EINVAL;
v.val = 0; memset(&v, 0, sizeof(v));
switch(optname) { switch(optname) {
case SO_DEBUG: case SO_DEBUG:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment