Commit 55c33dfb authored by Peter Wu's avatar Peter Wu Committed by Alexei Starovoitov

bpf: clarify when bpf_trace_printk discards lines

I opened /sys/kernel/tracing/trace once and kept reading from it.
bpf_trace_printk somehow did not seem to work, no entries were appended
to that trace file. It turns out that tracing is disabled when that file
is open. Save the next person some time and document this.

The trace file is described in Documentation/trace/ftrace.rst, however
the implication "tracing is disabled" did not immediate translate to
"bpf_trace_printk silently discards entries".
Signed-off-by: default avatarPeter Wu <peter@lekensteyn.nl>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 8050a395
...@@ -580,6 +580,8 @@ union bpf_attr { ...@@ -580,6 +580,8 @@ union bpf_attr {
* limited to five). * limited to five).
* *
* Each time the helper is called, it appends a line to the trace. * Each time the helper is called, it appends a line to the trace.
* Lines are discarded while *\/sys/kernel/debug/tracing/trace* is
* open, use *\/sys/kernel/debug/tracing/trace_pipe* to avoid this.
* The format of the trace is customizable, and the exact output * The format of the trace is customizable, and the exact output
* one will get depends on the options set in * one will get depends on the options set in
* *\/sys/kernel/debug/tracing/trace_options* (see also the * *\/sys/kernel/debug/tracing/trace_options* (see also the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment