Commit 55e5750b authored by Dave Jiang's avatar Dave Jiang Committed by Linus Torvalds

edac: ppc mpc85xx fix mc err detect

Error found by Jeff Haran.

The error detect register is 0s when no errors are detected.  The check
code is incorrect, so reverse check sense.
Reported-by: default avatarJeff Haran <jharan@Brocade.COM>
Signed-off-by: default avatarDave Jiang <djiang@mvista.com>
Signed-off-by: default avatarDoug Thompson <dougthompson@xmission.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: default avatarKumar Gala <galak@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b298cecb
...@@ -674,7 +674,7 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci) ...@@ -674,7 +674,7 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci)
int row_index; int row_index;
err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT); err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT);
if (err_detect) if (!err_detect)
return; return;
mpc85xx_mc_printk(mci, KERN_ERR, "Err Detect Register: %#8.8x\n", mpc85xx_mc_printk(mci, KERN_ERR, "Err Detect Register: %#8.8x\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment