Commit 55f780c4 authored by Mohit P. Tahiliani's avatar Mohit P. Tahiliani Committed by David S. Miller

net: sched: pie: fix commenting

Fix punctuation and logical mistakes in the comments. The
logical mistake was that "dequeue_rate" is no longer the default
way to calculate queuing delay and is not needed. The default
way to calculate queue delay was changed in commit cec2975f
("net: sched: pie: enable timestamp based delay calculation").
Signed-off-by: default avatarMohit P. Tahiliani <tahiliani@nitk.edu.in>
Signed-off-by: default avatarLeslie Monis <lesliemonis@gmail.com>
Signed-off-by: default avatarGautam Ramakrishnan <gautamramk@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b42a3d7c
...@@ -249,9 +249,9 @@ static void pie_process_dequeue(struct Qdisc *sch, struct sk_buff *skb) ...@@ -249,9 +249,9 @@ static void pie_process_dequeue(struct Qdisc *sch, struct sk_buff *skb)
} }
/* Calculate the average drain rate from this value. If queue length /* Calculate the average drain rate from this value. If queue length
* has receded to a small value viz., <= QUEUE_THRESHOLD bytes,reset * has receded to a small value viz., <= QUEUE_THRESHOLD bytes, reset
* the dq_count to -1 as we don't have enough packets to calculate the * the dq_count to -1 as we don't have enough packets to calculate the
* drain rate anymore The following if block is entered only when we * drain rate anymore. The following if block is entered only when we
* have a substantial queue built up (QUEUE_THRESHOLD bytes or more) * have a substantial queue built up (QUEUE_THRESHOLD bytes or more)
* and we calculate the drain rate for the threshold here. dq_count is * and we calculate the drain rate for the threshold here. dq_count is
* in bytes, time difference in psched_time, hence rate is in * in bytes, time difference in psched_time, hence rate is in
...@@ -329,8 +329,8 @@ static void calculate_probability(struct Qdisc *sch) ...@@ -329,8 +329,8 @@ static void calculate_probability(struct Qdisc *sch)
qdelay_old = q->vars.qdelay_old; qdelay_old = q->vars.qdelay_old;
} }
/* If qdelay is zero and qlen is not, it means qlen is very small, less /* If qdelay is zero and qlen is not, it means qlen is very small,
* than dequeue_rate, so we do not update probabilty in this round * so we do not update probabilty in this round.
*/ */
if (qdelay == 0 && qlen != 0) if (qdelay == 0 && qlen != 0)
update_prob = false; update_prob = false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment