Commit 56ea0976 authored by Vijetha Malkai's avatar Vijetha Malkai Committed by Alex Deucher

drm/amdgpu: Style fixes to PRIME code documentation

* Use consistent capitalization in the description of function arguments
* Define and consistently use the BO acronym for buffer objects
* Some minor wording improvements
Signed-off-by: default avatarVijetha Malkai <vijetha.malkai@amd.com>

[ Michel Dänzer: Made commit log more specific ]
Signed-off-by: default avatarMichel Dänzer <michel.daenzer@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 6a15f3ff
...@@ -44,10 +44,10 @@ static const struct dma_buf_ops amdgpu_dmabuf_ops; ...@@ -44,10 +44,10 @@ static const struct dma_buf_ops amdgpu_dmabuf_ops;
/** /**
* amdgpu_gem_prime_get_sg_table - &drm_driver.gem_prime_get_sg_table * amdgpu_gem_prime_get_sg_table - &drm_driver.gem_prime_get_sg_table
* implementation * implementation
* @obj: GEM buffer object * @obj: GEM buffer object (BO)
* *
* Returns: * Returns:
* A scatter/gather table for the pinned pages of the buffer object's memory. * A scatter/gather table for the pinned pages of the BO's memory.
*/ */
struct sg_table *amdgpu_gem_prime_get_sg_table(struct drm_gem_object *obj) struct sg_table *amdgpu_gem_prime_get_sg_table(struct drm_gem_object *obj)
{ {
...@@ -59,9 +59,9 @@ struct sg_table *amdgpu_gem_prime_get_sg_table(struct drm_gem_object *obj) ...@@ -59,9 +59,9 @@ struct sg_table *amdgpu_gem_prime_get_sg_table(struct drm_gem_object *obj)
/** /**
* amdgpu_gem_prime_vmap - &dma_buf_ops.vmap implementation * amdgpu_gem_prime_vmap - &dma_buf_ops.vmap implementation
* @obj: GEM buffer object * @obj: GEM BO
* *
* Sets up an in-kernel virtual mapping of the buffer object's memory. * Sets up an in-kernel virtual mapping of the BO's memory.
* *
* Returns: * Returns:
* The virtual address of the mapping or an error pointer. * The virtual address of the mapping or an error pointer.
...@@ -81,10 +81,10 @@ void *amdgpu_gem_prime_vmap(struct drm_gem_object *obj) ...@@ -81,10 +81,10 @@ void *amdgpu_gem_prime_vmap(struct drm_gem_object *obj)
/** /**
* amdgpu_gem_prime_vunmap - &dma_buf_ops.vunmap implementation * amdgpu_gem_prime_vunmap - &dma_buf_ops.vunmap implementation
* @obj: GEM buffer object * @obj: GEM BO
* @vaddr: virtual address (unused) * @vaddr: Virtual address (unused)
* *
* Tears down the in-kernel virtual mapping of the buffer object's memory. * Tears down the in-kernel virtual mapping of the BO's memory.
*/ */
void amdgpu_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr) void amdgpu_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
{ {
...@@ -95,14 +95,14 @@ void amdgpu_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr) ...@@ -95,14 +95,14 @@ void amdgpu_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
/** /**
* amdgpu_gem_prime_mmap - &drm_driver.gem_prime_mmap implementation * amdgpu_gem_prime_mmap - &drm_driver.gem_prime_mmap implementation
* @obj: GEM buffer object * @obj: GEM BO
* @vma: virtual memory area * @vma: Virtual memory area
* *
* Sets up a userspace mapping of the buffer object's memory in the given * Sets up a userspace mapping of the BO's memory in the given
* virtual memory area. * virtual memory area.
* *
* Returns: * Returns:
* 0 on success or negative error code. * 0 on success or a negative error code on failure.
*/ */
int amdgpu_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma) int amdgpu_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma)
{ {
...@@ -145,10 +145,10 @@ int amdgpu_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma ...@@ -145,10 +145,10 @@ int amdgpu_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma
* @attach: DMA-buf attachment * @attach: DMA-buf attachment
* @sg: Scatter/gather table * @sg: Scatter/gather table
* *
* Import shared DMA buffer memory exported by another device. * Imports shared DMA buffer memory exported by another device.
* *
* Returns: * Returns:
* A new GEM buffer object of the given DRM device, representing the memory * A new GEM BO of the given DRM device, representing the memory
* described by the given DMA-buf attachment and scatter/gather table. * described by the given DMA-buf attachment and scatter/gather table.
*/ */
struct drm_gem_object * struct drm_gem_object *
...@@ -191,7 +191,7 @@ amdgpu_gem_prime_import_sg_table(struct drm_device *dev, ...@@ -191,7 +191,7 @@ amdgpu_gem_prime_import_sg_table(struct drm_device *dev,
/** /**
* amdgpu_gem_map_attach - &dma_buf_ops.attach implementation * amdgpu_gem_map_attach - &dma_buf_ops.attach implementation
* @dma_buf: shared DMA buffer * @dma_buf: Shared DMA buffer
* @attach: DMA-buf attachment * @attach: DMA-buf attachment
* *
* Makes sure that the shared DMA buffer can be accessed by the target device. * Makes sure that the shared DMA buffer can be accessed by the target device.
...@@ -199,7 +199,7 @@ amdgpu_gem_prime_import_sg_table(struct drm_device *dev, ...@@ -199,7 +199,7 @@ amdgpu_gem_prime_import_sg_table(struct drm_device *dev,
* all DMA devices. * all DMA devices.
* *
* Returns: * Returns:
* 0 on success or negative error code. * 0 on success or a negative error code on failure.
*/ */
static int amdgpu_gem_map_attach(struct dma_buf *dma_buf, static int amdgpu_gem_map_attach(struct dma_buf *dma_buf,
struct dma_buf_attachment *attach) struct dma_buf_attachment *attach)
...@@ -251,11 +251,11 @@ static int amdgpu_gem_map_attach(struct dma_buf *dma_buf, ...@@ -251,11 +251,11 @@ static int amdgpu_gem_map_attach(struct dma_buf *dma_buf,
/** /**
* amdgpu_gem_map_detach - &dma_buf_ops.detach implementation * amdgpu_gem_map_detach - &dma_buf_ops.detach implementation
* @dma_buf: shared DMA buffer * @dma_buf: Shared DMA buffer
* @attach: DMA-buf attachment * @attach: DMA-buf attachment
* *
* This is called when a shared DMA buffer no longer needs to be accessible by * This is called when a shared DMA buffer no longer needs to be accessible by
* the other device. For now, simply unpins the buffer from GTT. * another device. For now, simply unpins the buffer from GTT.
*/ */
static void amdgpu_gem_map_detach(struct dma_buf *dma_buf, static void amdgpu_gem_map_detach(struct dma_buf *dma_buf,
struct dma_buf_attachment *attach) struct dma_buf_attachment *attach)
...@@ -280,10 +280,10 @@ static void amdgpu_gem_map_detach(struct dma_buf *dma_buf, ...@@ -280,10 +280,10 @@ static void amdgpu_gem_map_detach(struct dma_buf *dma_buf,
/** /**
* amdgpu_gem_prime_res_obj - &drm_driver.gem_prime_res_obj implementation * amdgpu_gem_prime_res_obj - &drm_driver.gem_prime_res_obj implementation
* @obj: GEM buffer object * @obj: GEM BO
* *
* Returns: * Returns:
* The buffer object's reservation object. * The BO's reservation object.
*/ */
struct reservation_object *amdgpu_gem_prime_res_obj(struct drm_gem_object *obj) struct reservation_object *amdgpu_gem_prime_res_obj(struct drm_gem_object *obj)
{ {
...@@ -294,15 +294,15 @@ struct reservation_object *amdgpu_gem_prime_res_obj(struct drm_gem_object *obj) ...@@ -294,15 +294,15 @@ struct reservation_object *amdgpu_gem_prime_res_obj(struct drm_gem_object *obj)
/** /**
* amdgpu_gem_begin_cpu_access - &dma_buf_ops.begin_cpu_access implementation * amdgpu_gem_begin_cpu_access - &dma_buf_ops.begin_cpu_access implementation
* @dma_buf: shared DMA buffer * @dma_buf: Shared DMA buffer
* @direction: direction of DMA transfer * @direction: Direction of DMA transfer
* *
* This is called before CPU access to the shared DMA buffer's memory. If it's * This is called before CPU access to the shared DMA buffer's memory. If it's
* a read access, the buffer is moved to the GTT domain if possible, for optimal * a read access, the buffer is moved to the GTT domain if possible, for optimal
* CPU read performance. * CPU read performance.
* *
* Returns: * Returns:
* 0 on success or negative error code. * 0 on success or a negative error code on failure.
*/ */
static int amdgpu_gem_begin_cpu_access(struct dma_buf *dma_buf, static int amdgpu_gem_begin_cpu_access(struct dma_buf *dma_buf,
enum dma_data_direction direction) enum dma_data_direction direction)
...@@ -349,14 +349,14 @@ static const struct dma_buf_ops amdgpu_dmabuf_ops = { ...@@ -349,14 +349,14 @@ static const struct dma_buf_ops amdgpu_dmabuf_ops = {
/** /**
* amdgpu_gem_prime_export - &drm_driver.gem_prime_export implementation * amdgpu_gem_prime_export - &drm_driver.gem_prime_export implementation
* @dev: DRM device * @dev: DRM device
* @gobj: GEM buffer object * @gobj: GEM BO
* @flags: flags like DRM_CLOEXEC and DRM_RDWR * @flags: Flags such as DRM_CLOEXEC and DRM_RDWR.
* *
* The main work is done by the &drm_gem_prime_export helper, which in turn * The main work is done by the &drm_gem_prime_export helper, which in turn
* uses &amdgpu_gem_prime_res_obj. * uses &amdgpu_gem_prime_res_obj.
* *
* Returns: * Returns:
* Shared DMA buffer representing the GEM buffer object from the given device. * Shared DMA buffer representing the GEM BO from the given device.
*/ */
struct dma_buf *amdgpu_gem_prime_export(struct drm_device *dev, struct dma_buf *amdgpu_gem_prime_export(struct drm_device *dev,
struct drm_gem_object *gobj, struct drm_gem_object *gobj,
...@@ -387,7 +387,7 @@ struct dma_buf *amdgpu_gem_prime_export(struct drm_device *dev, ...@@ -387,7 +387,7 @@ struct dma_buf *amdgpu_gem_prime_export(struct drm_device *dev,
* uses &amdgpu_gem_prime_import_sg_table. * uses &amdgpu_gem_prime_import_sg_table.
* *
* Returns: * Returns:
* GEM buffer object representing the shared DMA buffer for the given device. * GEM BO representing the shared DMA buffer for the given device.
*/ */
struct drm_gem_object *amdgpu_gem_prime_import(struct drm_device *dev, struct drm_gem_object *amdgpu_gem_prime_import(struct drm_device *dev,
struct dma_buf *dma_buf) struct dma_buf *dma_buf)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment