Commit 58a7295b authored by Tobias Klauser's avatar Tobias Klauser Committed by Dave Jones

[CPUFREQ] Fix sysfs_create_file return value handling

Commit 0a4b2ccc in cpufreq.git
eliminates the build warnings but does not pass on the error code of
sysfs_create_file to the function calling cpufreq_add_dev. Instead some
previous value of ret would be returned.
Signed-off-by: default avatarTobias Klauser <tklauser@distanz.ch>
Signed-off-by: default avatarDave Jones <davej@redhat.com>
parent ea487615
...@@ -826,16 +826,19 @@ static int cpufreq_add_dev (struct sys_device * sys_dev) ...@@ -826,16 +826,19 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
/* set up files for this cpu device */ /* set up files for this cpu device */
drv_attr = cpufreq_driver->attr; drv_attr = cpufreq_driver->attr;
while ((drv_attr) && (*drv_attr)) { while ((drv_attr) && (*drv_attr)) {
if (sysfs_create_file(&policy->kobj, &((*drv_attr)->attr))) ret = sysfs_create_file(&policy->kobj, &((*drv_attr)->attr));
if (ret)
goto err_out_driver_exit; goto err_out_driver_exit;
drv_attr++; drv_attr++;
} }
if (cpufreq_driver->get){ if (cpufreq_driver->get){
if (sysfs_create_file(&policy->kobj, &cpuinfo_cur_freq.attr)) ret = sysfs_create_file(&policy->kobj, &cpuinfo_cur_freq.attr);
if (ret)
goto err_out_driver_exit; goto err_out_driver_exit;
} }
if (cpufreq_driver->target){ if (cpufreq_driver->target){
if (sysfs_create_file(&policy->kobj, &scaling_cur_freq.attr)) ret = sysfs_create_file(&policy->kobj, &scaling_cur_freq.attr);
if (ret)
goto err_out_driver_exit; goto err_out_driver_exit;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment