Commit 58ef3977 authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Greg Kroah-Hartman

Staging: hv: netvsc: Cleanup error return values in rndis_filter_set_packet_filter()

Use standard Linux error codes and cleanup some error paths.
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent de6e0580
...@@ -511,7 +511,7 @@ static int rndis_filter_set_packet_filter(struct rndis_device *dev, ...@@ -511,7 +511,7 @@ static int rndis_filter_set_packet_filter(struct rndis_device *dev,
RNDIS_MESSAGE_SIZE(struct rndis_set_request) + RNDIS_MESSAGE_SIZE(struct rndis_set_request) +
sizeof(u32)); sizeof(u32));
if (!request) { if (!request) {
ret = -1; ret = -ENOMEM;
goto Cleanup; goto Cleanup;
} }
...@@ -531,7 +531,6 @@ static int rndis_filter_set_packet_filter(struct rndis_device *dev, ...@@ -531,7 +531,6 @@ static int rndis_filter_set_packet_filter(struct rndis_device *dev,
t = wait_for_completion_timeout(&request->wait_event, 5*HZ); t = wait_for_completion_timeout(&request->wait_event, 5*HZ);
if (t == 0) { if (t == 0) {
ret = -1;
dev_err(&dev->net_dev->dev->device, dev_err(&dev->net_dev->dev->device,
"timeout before we got a set response...\n"); "timeout before we got a set response...\n");
/* /*
...@@ -540,8 +539,6 @@ static int rndis_filter_set_packet_filter(struct rndis_device *dev, ...@@ -540,8 +539,6 @@ static int rndis_filter_set_packet_filter(struct rndis_device *dev,
*/ */
goto Exit; goto Exit;
} else { } else {
if (ret > 0)
ret = 0;
set_complete = &request->response_msg.msg.set_complete; set_complete = &request->response_msg.msg.set_complete;
status = set_complete->status; status = set_complete->status;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment