Commit 5f65d5a6 authored by Chris Wilson's avatar Chris Wilson

drm/i915/selftests: Teach timelines to take intel_gt as its argument

The timelines selftests are [mostly] hardware centric and so want to use
the gt as its target.
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191016113840.1106-1-chris@chris-wilson.co.uk
parent bb3d4c9d
...@@ -35,7 +35,7 @@ static unsigned long hwsp_cacheline(struct intel_timeline *tl) ...@@ -35,7 +35,7 @@ static unsigned long hwsp_cacheline(struct intel_timeline *tl)
#define CACHELINES_PER_PAGE (PAGE_SIZE / CACHELINE_BYTES) #define CACHELINES_PER_PAGE (PAGE_SIZE / CACHELINE_BYTES)
struct mock_hwsp_freelist { struct mock_hwsp_freelist {
struct drm_i915_private *i915; struct intel_gt *gt;
struct radix_tree_root cachelines; struct radix_tree_root cachelines;
struct intel_timeline **history; struct intel_timeline **history;
unsigned long count, max; unsigned long count, max;
...@@ -68,7 +68,7 @@ static int __mock_hwsp_timeline(struct mock_hwsp_freelist *state, ...@@ -68,7 +68,7 @@ static int __mock_hwsp_timeline(struct mock_hwsp_freelist *state,
unsigned long cacheline; unsigned long cacheline;
int err; int err;
tl = intel_timeline_create(&state->i915->gt, NULL); tl = intel_timeline_create(state->gt, NULL);
if (IS_ERR(tl)) if (IS_ERR(tl))
return PTR_ERR(tl); return PTR_ERR(tl);
...@@ -106,6 +106,7 @@ static int __mock_hwsp_timeline(struct mock_hwsp_freelist *state, ...@@ -106,6 +106,7 @@ static int __mock_hwsp_timeline(struct mock_hwsp_freelist *state,
static int mock_hwsp_freelist(void *arg) static int mock_hwsp_freelist(void *arg)
{ {
struct mock_hwsp_freelist state; struct mock_hwsp_freelist state;
struct drm_i915_private *i915;
const struct { const struct {
const char *name; const char *name;
unsigned int flags; unsigned int flags;
...@@ -117,12 +118,14 @@ static int mock_hwsp_freelist(void *arg) ...@@ -117,12 +118,14 @@ static int mock_hwsp_freelist(void *arg)
unsigned int na; unsigned int na;
int err = 0; int err = 0;
i915 = mock_gem_device();
if (!i915)
return -ENOMEM;
INIT_RADIX_TREE(&state.cachelines, GFP_KERNEL); INIT_RADIX_TREE(&state.cachelines, GFP_KERNEL);
state.prng = I915_RND_STATE_INITIALIZER(i915_selftest.random_seed); state.prng = I915_RND_STATE_INITIALIZER(i915_selftest.random_seed);
state.i915 = mock_gem_device(); state.gt = &i915->gt;
if (!state.i915)
return -ENOMEM;
/* /*
* Create a bunch of timelines and check that their HWSP do not overlap. * Create a bunch of timelines and check that their HWSP do not overlap.
...@@ -151,7 +154,7 @@ static int mock_hwsp_freelist(void *arg) ...@@ -151,7 +154,7 @@ static int mock_hwsp_freelist(void *arg)
__mock_hwsp_record(&state, na, NULL); __mock_hwsp_record(&state, na, NULL);
kfree(state.history); kfree(state.history);
err_put: err_put:
drm_dev_put(&state.i915->drm); drm_dev_put(&i915->drm);
return err; return err;
} }
...@@ -476,11 +479,11 @@ tl_write(struct intel_timeline *tl, struct intel_engine_cs *engine, u32 value) ...@@ -476,11 +479,11 @@ tl_write(struct intel_timeline *tl, struct intel_engine_cs *engine, u32 value)
} }
static struct intel_timeline * static struct intel_timeline *
checked_intel_timeline_create(struct drm_i915_private *i915) checked_intel_timeline_create(struct intel_gt *gt)
{ {
struct intel_timeline *tl; struct intel_timeline *tl;
tl = intel_timeline_create(&i915->gt, NULL); tl = intel_timeline_create(gt, NULL);
if (IS_ERR(tl)) if (IS_ERR(tl))
return tl; return tl;
...@@ -497,7 +500,7 @@ checked_intel_timeline_create(struct drm_i915_private *i915) ...@@ -497,7 +500,7 @@ checked_intel_timeline_create(struct drm_i915_private *i915)
static int live_hwsp_engine(void *arg) static int live_hwsp_engine(void *arg)
{ {
#define NUM_TIMELINES 4096 #define NUM_TIMELINES 4096
struct drm_i915_private *i915 = arg; struct intel_gt *gt = arg;
struct intel_timeline **timelines; struct intel_timeline **timelines;
struct intel_engine_cs *engine; struct intel_engine_cs *engine;
enum intel_engine_id id; enum intel_engine_id id;
...@@ -516,7 +519,7 @@ static int live_hwsp_engine(void *arg) ...@@ -516,7 +519,7 @@ static int live_hwsp_engine(void *arg)
return -ENOMEM; return -ENOMEM;
count = 0; count = 0;
for_each_engine(engine, i915, id) { for_each_engine(engine, gt->i915, id) {
if (!intel_engine_can_store_dword(engine)) if (!intel_engine_can_store_dword(engine))
continue; continue;
...@@ -526,7 +529,7 @@ static int live_hwsp_engine(void *arg) ...@@ -526,7 +529,7 @@ static int live_hwsp_engine(void *arg)
struct intel_timeline *tl; struct intel_timeline *tl;
struct i915_request *rq; struct i915_request *rq;
tl = checked_intel_timeline_create(i915); tl = checked_intel_timeline_create(gt);
if (IS_ERR(tl)) { if (IS_ERR(tl)) {
err = PTR_ERR(tl); err = PTR_ERR(tl);
break; break;
...@@ -548,7 +551,7 @@ static int live_hwsp_engine(void *arg) ...@@ -548,7 +551,7 @@ static int live_hwsp_engine(void *arg)
break; break;
} }
if (igt_flush_test(i915)) if (igt_flush_test(gt->i915))
err = -EIO; err = -EIO;
for (n = 0; n < count; n++) { for (n = 0; n < count; n++) {
...@@ -570,7 +573,7 @@ static int live_hwsp_engine(void *arg) ...@@ -570,7 +573,7 @@ static int live_hwsp_engine(void *arg)
static int live_hwsp_alternate(void *arg) static int live_hwsp_alternate(void *arg)
{ {
#define NUM_TIMELINES 4096 #define NUM_TIMELINES 4096
struct drm_i915_private *i915 = arg; struct intel_gt *gt = arg;
struct intel_timeline **timelines; struct intel_timeline **timelines;
struct intel_engine_cs *engine; struct intel_engine_cs *engine;
enum intel_engine_id id; enum intel_engine_id id;
...@@ -591,14 +594,14 @@ static int live_hwsp_alternate(void *arg) ...@@ -591,14 +594,14 @@ static int live_hwsp_alternate(void *arg)
count = 0; count = 0;
for (n = 0; n < NUM_TIMELINES; n++) { for (n = 0; n < NUM_TIMELINES; n++) {
for_each_engine(engine, i915, id) { for_each_engine(engine, gt->i915, id) {
struct intel_timeline *tl; struct intel_timeline *tl;
struct i915_request *rq; struct i915_request *rq;
if (!intel_engine_can_store_dword(engine)) if (!intel_engine_can_store_dword(engine))
continue; continue;
tl = checked_intel_timeline_create(i915); tl = checked_intel_timeline_create(gt);
if (IS_ERR(tl)) { if (IS_ERR(tl)) {
intel_engine_pm_put(engine); intel_engine_pm_put(engine);
err = PTR_ERR(tl); err = PTR_ERR(tl);
...@@ -620,7 +623,7 @@ static int live_hwsp_alternate(void *arg) ...@@ -620,7 +623,7 @@ static int live_hwsp_alternate(void *arg)
} }
out: out:
if (igt_flush_test(i915)) if (igt_flush_test(gt->i915))
err = -EIO; err = -EIO;
for (n = 0; n < count; n++) { for (n = 0; n < count; n++) {
...@@ -641,8 +644,7 @@ static int live_hwsp_alternate(void *arg) ...@@ -641,8 +644,7 @@ static int live_hwsp_alternate(void *arg)
static int live_hwsp_wrap(void *arg) static int live_hwsp_wrap(void *arg)
{ {
struct drm_i915_private *i915 = arg; struct intel_gt *gt = arg;
struct intel_gt *gt = &i915->gt;
struct intel_engine_cs *engine; struct intel_engine_cs *engine;
struct intel_timeline *tl; struct intel_timeline *tl;
enum intel_engine_id id; enum intel_engine_id id;
...@@ -740,7 +742,7 @@ static int live_hwsp_wrap(void *arg) ...@@ -740,7 +742,7 @@ static int live_hwsp_wrap(void *arg)
} }
out: out:
if (igt_flush_test(i915)) if (igt_flush_test(gt->i915))
err = -EIO; err = -EIO;
intel_timeline_unpin(tl); intel_timeline_unpin(tl);
...@@ -751,7 +753,7 @@ static int live_hwsp_wrap(void *arg) ...@@ -751,7 +753,7 @@ static int live_hwsp_wrap(void *arg)
static int live_hwsp_recycle(void *arg) static int live_hwsp_recycle(void *arg)
{ {
struct drm_i915_private *i915 = arg; struct intel_gt *gt = arg;
struct intel_engine_cs *engine; struct intel_engine_cs *engine;
enum intel_engine_id id; enum intel_engine_id id;
unsigned long count; unsigned long count;
...@@ -764,7 +766,7 @@ static int live_hwsp_recycle(void *arg) ...@@ -764,7 +766,7 @@ static int live_hwsp_recycle(void *arg)
*/ */
count = 0; count = 0;
for_each_engine(engine, i915, id) { for_each_engine(engine, gt->i915, id) {
IGT_TIMEOUT(end_time); IGT_TIMEOUT(end_time);
if (!intel_engine_can_store_dword(engine)) if (!intel_engine_can_store_dword(engine))
...@@ -776,7 +778,7 @@ static int live_hwsp_recycle(void *arg) ...@@ -776,7 +778,7 @@ static int live_hwsp_recycle(void *arg)
struct intel_timeline *tl; struct intel_timeline *tl;
struct i915_request *rq; struct i915_request *rq;
tl = checked_intel_timeline_create(i915); tl = checked_intel_timeline_create(gt);
if (IS_ERR(tl)) { if (IS_ERR(tl)) {
err = PTR_ERR(tl); err = PTR_ERR(tl);
break; break;
...@@ -831,5 +833,5 @@ int intel_timeline_live_selftests(struct drm_i915_private *i915) ...@@ -831,5 +833,5 @@ int intel_timeline_live_selftests(struct drm_i915_private *i915)
if (intel_gt_is_wedged(&i915->gt)) if (intel_gt_is_wedged(&i915->gt))
return 0; return 0;
return i915_live_subtests(tests, i915); return intel_gt_live_subtests(tests, &i915->gt);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment