Commit 6116c303 authored by Joe Lawrence's avatar Joe Lawrence Committed by Jiri Kosina

livepatch: move transition "complete" notice into klp_complete_transition()

klp_complete_transition() performs a bit of housework before a
transition to KLP_PATCHED or KLP_UNPATCHED is actually completed
(including post-(un)patch callbacks).  To be consistent, move the
transition "complete" kernel log notice out of
klp_try_complete_transition() and into klp_complete_transition().
Suggested-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Acked-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
Acked-by: default avatarMiroslav Benes <mbenes@suse.cz>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 93862e38
...@@ -136,6 +136,9 @@ static void klp_complete_transition(void) ...@@ -136,6 +136,9 @@ static void klp_complete_transition(void)
klp_post_unpatch_callback(obj); klp_post_unpatch_callback(obj);
} }
pr_notice("'%s': %s complete\n", klp_transition_patch->mod->name,
klp_target_state == KLP_PATCHED ? "patching" : "unpatching");
/* /*
* See complementary comment in __klp_enable_patch() for why we * See complementary comment in __klp_enable_patch() for why we
* keep the module reference for immediate patches. * keep the module reference for immediate patches.
...@@ -423,9 +426,6 @@ void klp_try_complete_transition(void) ...@@ -423,9 +426,6 @@ void klp_try_complete_transition(void)
} }
success: success:
pr_notice("'%s': %s complete\n", klp_transition_patch->mod->name,
klp_target_state == KLP_PATCHED ? "patching" : "unpatching");
/* we're done, now cleanup the data structures */ /* we're done, now cleanup the data structures */
klp_complete_transition(); klp_complete_transition();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment