Commit 625f6949 authored by Ming Lei's avatar Ming Lei Committed by Greg Kroah-Hartman

USB: remove interface parameter of usb_reset_composite_device

From the current implementation of usb_reset_composite_device
function, the iface parameter is no longer useful. This function
doesn't do something special for the iface usb_interface,compared
with other interfaces in the usb_device. So remove the parameter
and fix the related caller.
Signed-off-by: default avatarMing Lei <tom.leiming@gmail.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 33578bd7
...@@ -122,7 +122,7 @@ static void hid_reset(struct work_struct *work) ...@@ -122,7 +122,7 @@ static void hid_reset(struct work_struct *work)
dev_dbg(&usbhid->intf->dev, "resetting device\n"); dev_dbg(&usbhid->intf->dev, "resetting device\n");
rc = rc_lock = usb_lock_device_for_reset(hid_to_usb_dev(hid), usbhid->intf); rc = rc_lock = usb_lock_device_for_reset(hid_to_usb_dev(hid), usbhid->intf);
if (rc_lock >= 0) { if (rc_lock >= 0) {
rc = usb_reset_composite_device(hid_to_usb_dev(hid), usbhid->intf); rc = usb_reset_composite_device(hid_to_usb_dev(hid));
if (rc_lock) if (rc_lock)
usb_unlock_device(hid_to_usb_dev(hid)); usb_unlock_device(hid_to_usb_dev(hid));
} }
......
...@@ -872,7 +872,7 @@ static int proc_connectinfo(struct dev_state *ps, void __user *arg) ...@@ -872,7 +872,7 @@ static int proc_connectinfo(struct dev_state *ps, void __user *arg)
static int proc_resetdevice(struct dev_state *ps) static int proc_resetdevice(struct dev_state *ps)
{ {
return usb_reset_composite_device(ps->dev, NULL); return usb_reset_composite_device(ps->dev);
} }
static int proc_setintf(struct dev_state *ps, void __user *arg) static int proc_setintf(struct dev_state *ps, void __user *arg)
......
...@@ -2712,7 +2712,7 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1, ...@@ -2712,7 +2712,7 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1,
#endif #endif
} else { } else {
status = usb_reset_composite_device(udev, NULL); status = usb_reset_composite_device(udev);
} }
usb_unlock_device(udev); usb_unlock_device(udev);
...@@ -2940,7 +2940,7 @@ static void hub_events(void) ...@@ -2940,7 +2940,7 @@ static void hub_events(void)
dev_dbg (hub_dev, "resetting for error %d\n", dev_dbg (hub_dev, "resetting for error %d\n",
hub->error); hub->error);
ret = usb_reset_composite_device(hdev, intf); ret = usb_reset_composite_device(hdev);
if (ret) { if (ret) {
dev_dbg (hub_dev, dev_dbg (hub_dev,
"error resetting hub: %d\n", ret); "error resetting hub: %d\n", ret);
...@@ -3355,7 +3355,6 @@ EXPORT_SYMBOL_GPL(usb_reset_device); ...@@ -3355,7 +3355,6 @@ EXPORT_SYMBOL_GPL(usb_reset_device);
/** /**
* usb_reset_composite_device - warn interface drivers and perform a USB port reset * usb_reset_composite_device - warn interface drivers and perform a USB port reset
* @udev: device to reset (not in SUSPENDED or NOTATTACHED state) * @udev: device to reset (not in SUSPENDED or NOTATTACHED state)
* @iface: interface bound to the driver making the request (optional)
* *
* Warns all drivers bound to registered interfaces (using their pre_reset * Warns all drivers bound to registered interfaces (using their pre_reset
* method), performs the port reset, and then lets the drivers know that * method), performs the port reset, and then lets the drivers know that
...@@ -3368,8 +3367,7 @@ EXPORT_SYMBOL_GPL(usb_reset_device); ...@@ -3368,8 +3367,7 @@ EXPORT_SYMBOL_GPL(usb_reset_device);
* For calls that might not occur during probe(), drivers should lock * For calls that might not occur during probe(), drivers should lock
* the device using usb_lock_device_for_reset(). * the device using usb_lock_device_for_reset().
*/ */
int usb_reset_composite_device(struct usb_device *udev, int usb_reset_composite_device(struct usb_device *udev)
struct usb_interface *iface)
{ {
int ret; int ret;
int i; int i;
...@@ -3385,9 +3383,6 @@ int usb_reset_composite_device(struct usb_device *udev, ...@@ -3385,9 +3383,6 @@ int usb_reset_composite_device(struct usb_device *udev,
/* Prevent autosuspend during the reset */ /* Prevent autosuspend during the reset */
usb_autoresume_device(udev); usb_autoresume_device(udev);
if (iface && iface->condition != USB_INTERFACE_BINDING)
iface = NULL;
if (config) { if (config) {
for (i = 0; i < config->desc.bNumInterfaces; ++i) { for (i = 0; i < config->desc.bNumInterfaces; ++i) {
struct usb_interface *cintf = config->interface[i]; struct usb_interface *cintf = config->interface[i];
......
...@@ -1172,8 +1172,7 @@ int usb_stor_port_reset(struct us_data *us) ...@@ -1172,8 +1172,7 @@ int usb_stor_port_reset(struct us_data *us)
result = -EIO; result = -EIO;
US_DEBUGP("No reset during disconnect\n"); US_DEBUGP("No reset during disconnect\n");
} else { } else {
result = usb_reset_composite_device( result = usb_reset_composite_device(us->pusb_dev);
us->pusb_dev, us->pusb_intf);
US_DEBUGP("usb_reset_composite_device returns %d\n", US_DEBUGP("usb_reset_composite_device returns %d\n",
result); result);
} }
......
...@@ -497,8 +497,7 @@ extern int usb_lock_device_for_reset(struct usb_device *udev, ...@@ -497,8 +497,7 @@ extern int usb_lock_device_for_reset(struct usb_device *udev,
/* USB port reset for device reinitialization */ /* USB port reset for device reinitialization */
extern int usb_reset_device(struct usb_device *dev); extern int usb_reset_device(struct usb_device *dev);
extern int usb_reset_composite_device(struct usb_device *dev, extern int usb_reset_composite_device(struct usb_device *dev);
struct usb_interface *iface);
extern struct usb_device *usb_find_device(u16 vendor_id, u16 product_id); extern struct usb_device *usb_find_device(u16 vendor_id, u16 product_id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment