Commit 62dea077 authored by Breno Leitao's avatar Breno Leitao Committed by Michael Ellerman

powerpc/powernv: Mark function as __noreturn

There is a mismatch between function pnv_platform_error_reboot() definition
and declaration regarding function modifiers. In the declaration part, it
contains the function attribute __noreturn, while function definition
itself lacks it.

This was reported by sparse tool as an error:

  arch/powerpc/platforms/powernv/opal.c:538:6: error: symbol 'pnv_platform_error_reboot' redeclared with different type (originally declared at arch/powerpc/platforms/powernv/powernv.h:11) - different modifiers

I checked and the function is already being considered as being 'noreturn'
by the compiler, thus, I understand this patch does not change any code
being generated.
Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent fc35ef12
...@@ -535,7 +535,7 @@ static int opal_recover_mce(struct pt_regs *regs, ...@@ -535,7 +535,7 @@ static int opal_recover_mce(struct pt_regs *regs,
return recovered; return recovered;
} }
void pnv_platform_error_reboot(struct pt_regs *regs, const char *msg) void __noreturn pnv_platform_error_reboot(struct pt_regs *regs, const char *msg)
{ {
panic_flush_kmsg_start(); panic_flush_kmsg_start();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment